-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: System Message Moved This Expense Appears Greyed Out When User Goes Offline #80298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp80298-android-hybrid-001.mp4Android: mWeb Chrome80298-mweb-chrome-001.mp4iOS: HybridApp80298-ios-hybrid-001.mp4iOS: mWeb Safari80298-mweb-safari-001.mp4MacOS: Chrome / Safari80298-web-chrome-001.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nkdengineer for the PR.
@cead22 Changes LGTM and works well.
Over to you. Thanks.
trjExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Unless the action was taken offline and pending, it shouldn't appear like so!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.8-0 🚀
|
Explanation of Change
fix: System Message Moved This Expense Appears Greyed Out When User Goes Offline
Fixed Issues
$ #79862
PROPOSAL: #79862 (comment)
Tests
Preconditions
Steps:
moved this reportsystem message isn't greyed outOffline tests
None
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-23.at.10.40.52.mov
Android: mWeb Chrome
Screen.Recording.2026-01-23.at.10.41.31.mov
iOS: Native
Screen.Recording.2026-01-23.at.10.39.58.mov
iOS: mWeb Safari
Screen.Recording.2026-01-23.at.10.40.37.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-23.at.10.38.15.mov