chore: Migrate icons UI controls & actions to lazy loading by tedward-23 · Pull Request #80440 · Expensify/App

tedward-23 · 2026-01-25T06:24:02Z

Explanation of Change

Migrate icons UI controls & actions to lazy loading

Fixed Issues

$ #75253
PROPOSAL: #75253 (comment)

Tests

Pin icon

Open any chat
Click on the chat header to open Report Details
Verify the Pin icon displays correctly in the promoted actions bar

Send icon

Open any chat
Type a message in the compose area
Verify the Send button icon displays correctly

Trashcan icon

Go to Settings → Workspaces → Select a workspace
Navigate to Per diem and click on any rate
Verify the Delete option shows the Trashcan icon correctly

Copy icon

Go to Settings → Profile
Verify the Copy icon displays next to your email address

QrCode icon

Go to Settings → Share
Verify the QR Code icon displays correctly on the share screen

Checkmark icon

Create a new expense (click + → Submit expense)
Tap on participant selection
Select a participant
Verify the Checkmark icon displays on the selected item

Plus icon

Verify the + button displays correctly in the bottom navigation bar
Go to Settings → Workspaces
Verify the New workspace option shows the Plus icon

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Demo.mp4

melvin-bot · 2026-01-25T06:24:09Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2026-01-25T14:55:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-01-02.at.14.25.29.mp4

Android: mWeb Chrome

CleanShot.2026-01-02.at.14.25.29.mp4

iOS: HybridApp

CleanShot.2026-01-02.at.14.24.08.mp4

iOS: mWeb Safari

CleanShot.2026-01-02.at.14.27.18.mp4

MacOS: Chrome / Safari

CleanShot.2026-01-02.at.14.37.46.mp4

suneox

This change set is the same as the previous PR, created to resolve the signed commit issue.

mollfpr · 2026-01-26T17:51:36Z

Thanks @tdy2k for creating new PR! Just need to resolve the conflict!

codecov · 2026-01-26T17:57:02Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/AnimatedSubmitButton/index.tsx	`68.00% <100.00%> (+0.65%)`	⬆️
...ts/Attachments/AttachmentCarousel/CarouselItem.tsx	`88.88% <100.00%> (+0.65%)`	⬆️
src/components/Checkbox.tsx	`89.65% <100.00%> (+0.36%)`	⬆️
src/components/ConfirmContent.tsx	`82.50% <100.00%> (+0.44%)`	⬆️
...rc/components/Icon/chunks/expensify-icons.chunk.ts	`0.00% <ø> (ø)`
src/components/LHNOptionsList/LHNOptionsList.tsx	`87.50% <100.00%> (ø)`
.../LocationErrorMessage/BaseLocationErrorMessage.tsx	`15.38% <100.00%> (+7.05%)`	⬆️
src/components/Navigation/DebugTabView.tsx	`36.66% <100.00%> (+0.71%)`	⬆️
src/components/OnboardingHelpDropdownButton.tsx	`97.05% <100.00%> (ø)`
... and 99 more
... and 22 files with indirect coverage changes

joekaufmanexpensify · 2026-01-26T22:00:00Z

No product considerations, removing my review

tedward-23 · 2026-01-31T09:12:18Z

Thanks @tdy2k for creating new PR! Just need to resolve the conflict!

Thanks @mollfpr. Finished.

tedward-23 · 2026-02-02T17:45:27Z

Friendly Bump @mollfpr before conflicts occur.

Thank you

mollfpr

Sorry for the delay, I was OOO. 🙏

Leave few comments to clarify.

mollfpr

Leave a comment and we have failing checks and conflict.

tedward-23 · 2026-02-08T13:17:58Z

Finished @mollfpr

mollfpr · 2026-02-09T05:46:05Z

@tdy2k We have a failing eslint, could you fix it? Thanks!

github-actions · 2026-02-14T16:59:23Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

tedward-23 · 2026-02-14T17:01:44Z

@tdy2k We have a failing eslint, could you fix it? Thanks!

Hello @mollfpr

I am very sorry for the force push. Accidentally misused the Github GUI feature.

tedward-23 · 2026-02-14T17:03:41Z

@mollfpr

If possible. Can we please start the workflows today and merge before monday after monday a lot of commits will arrive and I will be again forced to resolve conflicts

tedward-23 · 2026-02-16T16:00:39Z

Conflict Resolved.

tedward-23 · 2026-02-17T07:39:05Z

Bump @mollfpr

mollfpr · 2026-02-17T08:59:22Z

Checking 👀

mollfpr

LGTM! Waiting for the checks finish.

mollfpr · 2026-02-17T11:31:32Z

@tdy2k there’s a failing eslint, could you check? Thanks!

mollfpr · 2026-02-19T13:53:57Z

Bump @tdy2k

tedward-23 · 2026-02-23T07:40:12Z

@tdy2k there’s a failing eslint, could you check? Thanks!

They were unrelated it was SENTRY.

Checking it out

Thank you

…e-icons-UI-controls-and-actions-to-lazy-loading # Conflicts: # src/CONST/index.ts # src/components/Attachments/AttachmentCarousel/CarouselItem.tsx # src/components/ConnectToNetSuiteFlow/index.tsx # src/components/DistanceRequest/DistanceRequestFooter.tsx # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/MoneyRequestHeader.tsx # src/components/MoneyRequestReportView/SearchMoneyRequestReportEmptyState.tsx # src/components/TransactionItemRow/TransactionItemRowRBR.tsx # src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx # src/pages/EditReportFieldPage.tsx # src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx # src/pages/settings/AboutPage/ConsolePage.tsx # src/pages/settings/Profile/CustomStatus/StatusPage.tsx # src/pages/settings/Security/SecuritySettingsPage.tsx # src/pages/settings/Security/TwoFactorAuth/VerifyPage.tsx # src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCard.tsx # src/pages/settings/Wallet/ChooseTransferAccountPage.tsx # src/pages/workspace/WorkspaceMembersPage.tsx # src/pages/workspace/categories/WorkspaceCategoriesPage.tsx # src/pages/workspace/expensifyCard/WorkspaceCardsListLabel.tsx # src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx # src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

tedward-23 · 2026-02-25T13:30:29Z

Finished @mollfpr

Also verified npm run lint, npm run lint-changed, and npm run typecheck

Can you run the workflows and merge if possible now please?

Conflicts are becoming headache

tedward-23 · 2026-02-25T13:40:15Z

Run Prettier

Lets start.

cc @mollfpr

Hoping to merge today

mollfpr · 2026-02-25T13:42:59Z

Running the workflow.

tedward-23 · 2026-02-25T13:51:18Z

Workflows finished

github-actions · 2026-02-25T14:16:49Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-02-25T14:20:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-25T14:23:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80440.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-dc3470a-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-dc3470a-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://80440.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:23:00Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:54:33Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

tedward-23 requested review from a team as code owners January 25, 2026 06:24

melvin-bot Bot assigned tedward-23 Jan 25, 2026

melvin-bot Bot requested review from joekaufmanexpensify and suneox and removed request for a team January 25, 2026 06:24

tedward-23 mentioned this pull request Jan 25, 2026

[Due for payment][$125] Migrate icons UI controls & actions to lazy loading #75253

Closed

github-actions Bot reviewed Jan 25, 2026

View reviewed changes

Comment thread src/components/MoneyRequestHeader.tsx Outdated

suneox approved these changes Jan 25, 2026

View reviewed changes

melvin-bot Bot requested a review from mollfpr January 25, 2026 14:58

joekaufmanexpensify removed their request for review January 26, 2026 22:00

mollfpr reviewed Feb 4, 2026

View reviewed changes

tedward-23 requested a review from mollfpr February 5, 2026 15:27

mollfpr reviewed Feb 5, 2026

View reviewed changes

Comment thread src/libs/SearchUIUtils.ts Outdated

Comment thread src/pages/iou/request/step/IOURequestStepWaypoint.tsx Outdated

mollfpr previously approved these changes Feb 8, 2026

View reviewed changes

tedward-23 dismissed mollfpr’s stale review via f31b596 February 14, 2026 16:59

tedward-23 force-pushed the chore-Migrate-icons-UI-controls-and-actions-to-lazy-loading branch from 471b75c to f31b596 Compare February 14, 2026 16:59

tedward-23 requested a review from mollfpr February 14, 2026 17:03

tedward-23 requested a review from a team as a code owner February 16, 2026 15:59

chore: Migrate icons UI controls & actions to lazy loading

9293e89

tedward-23 force-pushed the chore-Migrate-icons-UI-controls-and-actions-to-lazy-loading branch from 33c954e to 9293e89 Compare February 16, 2026 16:00

mollfpr previously approved these changes Feb 17, 2026

View reviewed changes

tedward-23 dismissed mollfpr’s stale review via da80bb9 February 25, 2026 13:28

chore: run prettier

e92d953

mollfpr approved these changes Feb 25, 2026

View reviewed changes

mollfpr merged commit dc3470a into Expensify:main Feb 25, 2026
28 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

Conversation

tedward-23 commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Pin icon

Send icon

Trashcan icon

Copy icon

QrCode icon

Checkmark icon

Plus icon

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 25, 2026

Uh oh!

Uh oh!

suneox commented Jan 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Jan 26, 2026

Uh oh!

codecov Bot commented Jan 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify commented Jan 26, 2026

Uh oh!

tedward-23 commented Jan 31, 2026

Uh oh!

tedward-23 commented Feb 2, 2026

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tedward-23 commented Feb 8, 2026

Uh oh!

mollfpr commented Feb 9, 2026

Uh oh!

github-actions Bot commented Feb 14, 2026

Uh oh!

tedward-23 commented Feb 14, 2026

Uh oh!

tedward-23 commented Feb 14, 2026

Uh oh!

tedward-23 commented Feb 16, 2026

Uh oh!

tedward-23 commented Feb 17, 2026

Uh oh!

mollfpr commented Feb 17, 2026

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Feb 17, 2026

Uh oh!

mollfpr commented Feb 19, 2026

Uh oh!

tedward-23 commented Feb 23, 2026

Uh oh!

tedward-23 commented Feb 25, 2026

tedward-23 commented Jan 25, 2026 •

edited

Loading

codecov Bot commented Jan 26, 2026 •

edited by github-actions Bot

Loading