[HOLD BE] Update system messages for expenses moved to different reports by twilight2294 · Pull Request #80444 · Expensify/App

twilight2294 · 2026-01-25T10:35:16Z

Explanation of Change

Fixed Issues

$ #70485
PROPOSAL: #70485 (comment)

Tests

same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Test Case 1: No system message when moving expenses FROM a Draft report

Create a new expense on a workspace (this creates a Draft/Open report)
Before submitting the report, go to the expense and select "Move to..."
Move the expense to a different report (either another existing Draft report or a new workspace)
Open the expense thread/chat for the moved expense

Verify that There should be NO "Expense moved from [report]" system message in the expense thread

Test Case 2: System message SHOULD appear when moving expenses FROM a non-Draft report

Create an expense on a workspace
Submit the expense report (making it a Submitted/Processing report, not Draft)
As an approver or if the report is returned, move an expense from this non-Draft report to another report
Open the expense thread/chat for the moved expense

Verify that A system message SHOULD appear indicating the expense was moved from the previous report

Test Case 3: No system message when rejecting an expense

Create an expense report with multiple expenses
Submit the report for approval
As an approver, reject one of the expenses (providing a rejection reason)
The rejected expense should be moved to a new Draft report
Open the expense thread/chat for the rejected expense

Verify That There should be a "Rejected this expense" system message with the rejection reason
Verify that There should be NO additional "Expense moved to [new report]" system message

Test Case 4: No system message when held expense is moved while others are approved

Create an expense report with multiple expenses
Put a hold on one of the expenses
Submit the report for approval
As an approver, approve the report (the held expense will be moved to a new Draft report)
Open the expense thread/chat for the held expense that was moved

Verify that There should be NO "Expense moved" system message for the held expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-05.at.6.14.25.PM.mov

melvin-bot · 2026-02-02T21:09:21Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2026-02-02T21:09:48Z

@parasharrajat please begin your review, i'm having issue with emulator, i'll fix that and update the recordings and will ping you

twilight2294 · 2026-02-04T07:47:09Z

bump for review @parasharrajat

parasharrajat · 2026-02-04T07:52:17Z

Thanks for the bump... I will get on it soon.

parasharrajat · 2026-02-04T07:52:37Z

You can start adding vids for platforms...

twilight2294 · 2026-02-05T12:57:00Z

bump for review @parasharrajat , it would be better if the review can come in today / tomorrow so i can address the comments, thanks 😄

twilight2294 · 2026-02-05T13:08:12Z

I'm still working on videos, i should have them by tomorrow morning, i updated the Web video now. sorry for the delay on those ones i am having a lot of build errors

parasharrajat · 2026-02-07T12:22:37Z

src/libs/actions/Transaction.ts

+        const buildMovedAction = () => {
+            if (isSourceReportDraft) {
+                return undefined;
+            }
+            if (reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
+                return buildOptimisticUnreportedTransactionAction(transactionThreadReportID, oldReportID);
+            }
+            return buildOptimisticMovedTransactionAction(transactionThreadReportID, oldReportID);
+        };


This will also not create message for unreported expenses.

can you please rephrase what you're trying to say? do you have a question for me?

bump on the comment @parasharrajat

Don't remember why I said that. Let me test that again.

@parasharrajat any updates here ?

friendly bump @parasharrajat 😄

bump @parasharrajat

Thanks for waiting. Checking this now.

THis is the one I was talking about #80444 (comment)

JmillsExpensify

Product approved. Great QA steps, super helpful!

parasharrajat · 2026-03-07T15:51:16Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat · 2026-03-08T09:07:34Z

BUG: Move a unreported expense to a report via report field, move message does not appear.

Steps;

go to self DM.
Open any expense.
Click report field and select any workspace report.

parasharrajat · 2026-03-08T09:31:21Z

src/libs/actions/IOU/index.ts

+            // Skip creating system messages when moving to a Draft report
+            // New expense reports created for rejected expenses are always Draft reports (open status)


Are we sure about this?

parasharrajat · 2026-03-08T10:04:54Z

BUG: when we move expense via move report using create report option on move page, the move message is still shown.

Note: it seems create report option on move page is not working correctly on staging. It is creating in default workspace while it should in the one that is showin on create report button. That is a different issue. reported internally.

08.03.2026_15.32.30_REC.mp4

parasharrajat · 2026-03-08T10:13:24Z

BUG: Similiar to above, when I move expense via move to report option in the draft reports in the same worksapce, the message is shown.

Steps:

Create 2 reports in draft state in same workspace chat.
Create 2 expenses in one report.
Select one expense in first report.
Open Selected > Move to report.
Selected second report.

parasharrajat · 2026-03-08T10:14:14Z

BUG: same as above but use the report field on the expense to move to different report.

parasharrajat · 2026-03-09T11:10:10Z

@twilight2294 Some bugs.

twilight2294 · 2026-03-09T11:37:09Z

Looking at the bugs

parasharrajat · 2026-03-10T12:06:07Z

Ping me when this PR is ready @twilight2294

twilight2294 · 2026-03-11T04:55:31Z

Ping me when this PR is ready @twilight2294

Almost ready, just need to test all the bugs you posted, will do it today

twilight2294 · 2026-03-15T09:38:29Z

I have to do a final test then will ask for review

parasharrajat · 2026-03-15T10:27:24Z

Can you speed up @twilight2294?

twilight2294 · 2026-03-18T08:37:34Z

BUG: Move a unreported expense to a report via report field, move message does not appear.

Steps;

go to self DM.

Open any expense.

Click report field and select any workspace report.

This bugs seems to be unrelated to our changes, i can reproduce the same on staging. Can you file a bug report for this, thanks !

Screen.Recording.2026-03-18.at.2.06.56.PM.mov

twilight2294 · 2026-03-18T08:42:50Z

BUG: when we move expense via move report using create report option on move page, the move message is still shown.

Note: it seems create report option on move page is not working correctly on staging. It is creating in default workspace while it should in the one that is showin on create report button. That is a different issue. reported internally.

08.03.2026_15.32.30_REC.mp4

This seems BE issue, Optimistically it works correctly :

Screen.Recording.2026-03-18.at.2.11.12.PM.mov

Can you confirm please

twilight2294 · 2026-03-18T08:43:30Z

BUG: Similiar to above, when I move expense via move to report option in the draft reports in the same worksapce, the message is shown.

Steps:

Create 2 reports in draft state in same workspace chat.

Create 2 expenses in one report.

Select one expense in first report.

Open Selected > Move to report.

Selected second report.

same as ^

twilight2294 · 2026-03-18T08:45:08Z

BUG: same as above but use the report field on the expense to move to different report.

Same BE issue i think :

Screen.Recording.2026-03-18.at.2.14.05.PM.mov

twilight2294 · 2026-03-18T08:45:23Z

@parasharrajat how should we proceed, since optimistically, we're good, the BE needs to be fixed

parasharrajat · 2026-03-18T10:23:16Z

If you need backend changes, ask it on issue and tag the engineer.

twilight2294 · 2026-03-20T10:39:19Z

Here it is: #70485 (comment)

Update system messages for expenses moved to different reports

1796ab4

melvin-bot bot assigned twilight2294 Jan 25, 2026

fix test failures

1f9da1d

twilight2294 changed the title ~~Update system messages for expenses moved to different reports~~ [HOLD BE] Update system messages for expenses moved to different reports Jan 25, 2026

twilight2294 mentioned this pull request Jan 25, 2026

[$250] Update system messages for expenses moved to different reports #70485

Open

twilight2294 marked this pull request as ready for review February 2, 2026 21:09

twilight2294 requested review from a team as code owners February 2, 2026 21:09

melvin-bot bot requested a review from parasharrajat February 2, 2026 21:09

melvin-bot bot requested review from JmillsExpensify and removed request for a team February 2, 2026 21:09

twilight2294 changed the title ~~[HOLD BE] Update system messages for expenses moved to different reports~~ Update system messages for expenses moved to different reports Feb 3, 2026

twilight2294 added 2 commits February 5, 2026 16:54

Merge branch 'Expensify:main' into issue70485

5b043dc

Update IOUTest.ts

5aa597c

parasharrajat reviewed Feb 7, 2026

View reviewed changes

JmillsExpensify previously approved these changes Feb 13, 2026

View reviewed changes

Merge branch 'Expensify:main' into issue70485

26f1740

parasharrajat reviewed Mar 8, 2026

View reviewed changes

twilight2294 added 2 commits March 10, 2026 13:49

Merge branch 'Expensify:main' into issue70485

e46f413

fix bugs

bd18d42

twilight2294 dismissed JmillsExpensify’s stale review via bd18d42 March 10, 2026 08:47

twilight2294 added 2 commits March 10, 2026 14:23

Update TransactionTest.ts

40920db

Update IOUTest.ts

0b864a3

twilight2294 added 2 commits March 13, 2026 10:42

Merge branch 'Expensify:main' into issue70485

4b24e41

Merge branch 'Expensify:main' into issue70485

41ad302

twilight2294 added 2 commits March 18, 2026 12:09

Merge branch 'main' into issue70485

52908e9

Update Transaction.ts

1944deb

Merge branch 'Expensify:main' into issue70485

1bc041c

twilight2294 changed the title ~~Update system messages for expenses moved to different reports~~ [HOLD BE] Update system messages for expenses moved to different reports Mar 20, 2026

		// Skip creating system messages when moving to a Draft report
		// New expense reports created for rejected expenses are always Draft reports (open status)

Conversation

twilight2294 commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Test Case 1: No system message when moving expenses FROM a Draft report

Test Case 2: System message SHOULD appear when moving expenses FROM a non-Draft report

Test Case 3: No system message when rejecting an expense

Test Case 4: No system message when held expense is moved while others are approved

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 2, 2026

Uh oh!

twilight2294 commented Feb 2, 2026

Uh oh!

twilight2294 commented Feb 4, 2026

Uh oh!

parasharrajat commented Feb 4, 2026

Uh oh!

parasharrajat commented Feb 4, 2026

Uh oh!

twilight2294 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Mar 7, 2026

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat commented Mar 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Mar 8, 2026

Uh oh!

parasharrajat commented Mar 8, 2026

Uh oh!

parasharrajat commented Mar 9, 2026

Uh oh!

twilight2294 commented Mar 9, 2026

Uh oh!

parasharrajat commented Mar 10, 2026

Uh oh!

twilight2294 commented Mar 11, 2026

Uh oh!

twilight2294 commented Jan 25, 2026 •

edited

Loading

twilight2294 commented Feb 5, 2026 •

edited

Loading

parasharrajat Mar 7, 2026 •

edited

Loading

parasharrajat commented Mar 8, 2026 •

edited

Loading