fix: [Accessibility][Tracking] Make Element Focusable#80450
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d3e20cdcf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx
Outdated
Show resolved
Hide resolved
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
No product considerations, removing my review |
7611644 to
08df367
Compare
|
|
4bfea55 to
5275ac4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d11de5d463
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safariweb.mov |
Is it possible to fix this in a follow up PR, it needs a little more time to fix it for all platforms. The current structure of CopyToClipboard component is not accessibility friendly at all, and needs architectural fix across platforms. |
|
@TaduJR I'm fine with that being done in a follow-up / separate issue since it requires refactoring which is out of scope here. As far as the other issues I'm fine as long as CME agrees with the explanations as well. This only leaves you with the 🇪🇸 copy translation issue mentioned here, once this is resolved please tag me and I'll check then approve. |
Here @ikevin127 https://expensify.slack.com/archives/C01GTK53T8Q/p1771221065283339 |
|
@yuwenmemon Please review my previous comment before merging, related to author's comments: #80450 (comment) and #80450 (comment) 🙌 |
|
Yes, agreed we can do the copy email button stuff in a follow-up. |
|
🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀
|
|
I am not able to repo this #77251 Screen_Recording_20260224_120247_New.Expensify.Dev.mp4I even tried to close the app then re-open, it automatically focuses on the Expensify Logo |
|
Also not able to repo #77387 |
|
Not able to repo both on all platforms |
|
@TaduJR asked team to recheck |
|
@TaduJR QA team can’t reproduce both issues anymore 6e8c18d3e2ca1552c7021e5c927735f7.mp4 |
|
Thank you @IuliiaHerets! |




Explanation of Change
Fixed Issues
$ #79231
PROPOSAL: #79231 (comment)
Tests
Prerequisites: Enable VoiceOver (iOS), TalkBack (Android), or use keyboard navigation (Web with Tab key)
Social Network Links (Screen Reader: Sign in: The social network links in the footer are not focused and announced #77555)
Licenses Link - Mobile (Screen Reader: Sign in: The 'Licenses' link is not focused and announced #77543)
3-Dot Menu Focusable (Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable #77471)
Workspace Row→3-dot Menu→Next Workspace Row→3-dot MenuQR Code Image - App Download Links (Screen Readers: About and Subsections: The image of QR code is not focused and announced #77387)
Expensify Logo (Screen Reader: Sign in: The logo image is not focused and announced #77251)
Submit a Bug Link (Screen Reader: Settings-Troubleshoot: Submit a bug button not focusable. #76070)
QR Code - Settings About (Screen Reader: Settings-About: QR code is not focused and announced #74884)
Licenses Link - Web Keyboard (Screen Reader: Many Pages: The link of Licenses is not focusable with Tab key, no role announced #74872)
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260204_081035_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260204_081650_Chrome.mp4
iOS: Native
Screen.Recording.2026-02-04.at.8.19.59.in.the.morning.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-04.at.8.14.30.in.the.morning.mov