Skip to content

fix: [Accessibility][Tracking] Make Element Focusable#80450

Merged
yuwenmemon merged 9 commits intoExpensify:mainfrom
TaduJR:fix-Accessibility-Tracking-Make-Element-Focusable
Feb 17, 2026
Merged

fix: [Accessibility][Tracking] Make Element Focusable#80450
yuwenmemon merged 9 commits intoExpensify:mainfrom
TaduJR:fix-Accessibility-Tracking-Make-Element-Focusable

Conversation

@TaduJR
Copy link
Contributor

@TaduJR TaduJR commented Jan 25, 2026

Explanation of Change

Fixed Issues

$ #79231
PROPOSAL: #79231 (comment)

Tests

Prerequisites: Enable VoiceOver (iOS), TalkBack (Android), or use keyboard navigation (Web with Tab key)


  1. Social Network Links (Screen Reader: Sign in: The social network links in the footer are not focused and announced #77555)

    • Open the Expensify app (not signed in)
    • Using Android TalkBack or iOS VoiceOver, swipe to the footer social links on the sign-in page
    • Verify each link is focusable and announced with name and role (e.g., "Expensify on Facebook, link")
  2. Licenses Link - Mobile (Screen Reader: Sign in: The 'Licenses' link is not focused and announced #77543)

    • Open the Expensify app (not signed in)
    • Using Android TalkBack, navigate to the "Licenses" link in the footer
    • Verify it is focusable and announced with link role
  3. 3-Dot Menu Focusable (Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable #77471)

    • Log in and navigate to Settings > Workspaces
    • Using VoiceOver on iOS, swipe through a workspace row
    • Verify the workspace info (title, owner, badges) is announced as one group
    • Verify the 3-dot menu button is separately focusable immediately after
    • Expected focus order: Workspace Row3-dot MenuNext Workspace Row3-dot Menu
  4. QR Code Image - App Download Links (Screen Readers: About and Subsections: The image of QR code is not focused and announced #77387)

    • Log in and navigate to Settings > About > App download links
    • Using Android TalkBack or iOS VoiceOver, swipe to focus the QR code image
    • Verify it is announced as "QR code"
  5. Expensify Logo (Screen Reader: Sign in: The logo image is not focused and announced #77251)

    • Open the Expensify app (not signed in)
    • Using Android TalkBack or iOS VoiceOver, swipe to focus the Expensify logo, not the LottieAnimation
    • Verify it is announced as "Expensify"
  6. Submit a Bug Link (Screen Reader: Settings-Troubleshoot: Submit a bug button not focusable. #76070)

    • Log in and navigate to Settings > Troubleshoot
    • Using JAWS + Chrome on Windows, press Tab key to navigate to "submit a bug" link
    • Verify it is focusable and has link role
  7. QR Code - Settings About (Screen Reader: Settings-About: QR code is not focused and announced #74884)

    • Log in and navigate to Settings > About > App download links
    • Using JAWS + Chrome on Windows, press Tab key or G key to focus the QR code
    • Verify it is focusable and announced as "QR code"
  8. Licenses Link - Web Keyboard (Screen Reader: Many Pages: The link of Licenses is not focusable with Tab key, no role announced #74872)

    • On web Open the Expensify app (not signed in),
    • Using JAWS + Chrome on Windows, press Tab key to navigate to the "Licenses" link in the footer
    • Verify it is focusable via keyboard and announced with link role
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_Recording_20260204_081035_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260204_081650_Chrome.mp4
iOS: Native
Screen.Recording.2026-02-04.at.8.19.59.in.the.morning.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-04.at.8.14.30.in.the.morning.mov

@TaduJR TaduJR requested review from a team as code owners January 25, 2026 13:22
@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2026

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed request for a team January 25, 2026 13:22
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d3e20cdcf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ExpensifyWordmark.tsx 100.00% <100.00%> (ø)
...neProvider/HTMLRenderers/ConciergeLinkRenderer.tsx 0.00% <ø> (ø)
src/components/TextLink.tsx 66.66% <ø> (ø)
src/pages/signin/Socials.tsx 100.00% <ø> (ø)
src/pages/workspace/WorkspacesListPage.tsx 61.12% <ø> (-0.51%) ⬇️
src/pages/workspace/WorkspacesListRow.tsx 98.14% <100.00%> (+0.27%) ⬆️
src/components/QRShare/index.tsx 0.00% <0.00%> (ø)
src/components/QRCode.tsx 0.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

@TaduJR TaduJR marked this pull request as draft January 25, 2026 13:43
@joekaufmanexpensify
Copy link
Contributor

No product considerations, removing my review

@joekaufmanexpensify joekaufmanexpensify removed their request for review January 26, 2026 22:01
@TaduJR TaduJR force-pushed the fix-Accessibility-Tracking-Make-Element-Focusable branch from 7611644 to 08df367 Compare February 2, 2026 10:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@TaduJR TaduJR force-pushed the fix-Accessibility-Tracking-Make-Element-Focusable branch from 4bfea55 to 5275ac4 Compare February 2, 2026 10:53
@TaduJR TaduJR marked this pull request as ready for review February 2, 2026 12:07
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d11de5d463

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ikevin127
Copy link
Contributor

ikevin127 commented Feb 2, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp android
Android: mWeb Chrome android-mweb
iOS: HybridApp ios
iOS: mWeb Safari ios-mweb
MacOS: Chrome / Safari
web.mov

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 15, 2026

Copy Email Button (#77548)

@ikevin127

Is it possible to fix this in a follow up PR, it needs a little more time to fix it for all platforms. The current structure of CopyToClipboard component is not accessibility friendly at all, and needs architectural fix across platforms.

@ikevin127
Copy link
Contributor

@TaduJR I'm fine with that being done in a follow-up / separate issue since it requires refactoring which is out of scope here. As far as the other issues I'm fine as long as CME agrees with the explanations as well.

This only leaves you with the 🇪🇸 copy translation issue mentioned here, once this is resolved please tag me and I'll check then approve.

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 16, 2026

This only leaves you with the 🇪🇸 copy translation issue mentioned #80450 (comment), once this is resolved please tag me and I'll check then approve.

Here @ikevin127

https://expensify.slack.com/archives/C01GTK53T8Q/p1771221065283339

Copy link
Contributor

@ikevin127 ikevin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

@melvin-bot melvin-bot bot requested a review from yuwenmemon February 16, 2026 23:59
@ikevin127
Copy link
Contributor

@yuwenmemon Please review my previous comment before merging, related to author's comments: #80450 (comment) and #80450 (comment) 🙌

@yuwenmemon
Copy link
Contributor

Yes, agreed we can do the copy email button stuff in a follow-up.

@yuwenmemon yuwenmemon merged commit 205a330 into Expensify:main Feb 17, 2026
33 checks passed
@github-actions
Copy link
Contributor

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets
Copy link

Hi @TaduJR. QA team failed this PR for Android with 2 original issues: #77251 and #77387

1771401906142.80450A-2.mp4
1771401906133.80450A-1.mp4

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 18, 2026

Hi @TaduJR. QA team failed this PR for Android with 2 original issues: #77251 and #77387

Hi @IuliiaHerets

Hmmm I think they are platform specific issue. It works on Web.

Thanks will look in to it on follow up PR.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 24, 2026

Hi @IuliiaHerets

I am not able to repo this #77251

Screen_Recording_20260224_120247_New.Expensify.Dev.mp4

I even tried to close the app then re-open, it automatically focuses on the Expensify Logo

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 24, 2026

Also not able to repo #77387

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 24, 2026

Not able to repo both on all platforms

cc @IuliiaHerets

@IuliiaHerets
Copy link

@TaduJR asked team to recheck

@IuliiaHerets
Copy link

@TaduJR QA team can’t reproduce both issues anymore

6e8c18d3e2ca1552c7021e5c927735f7.mp4

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 24, 2026

Thank you @IuliiaHerets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants