-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix Manual/Scan tab buttons clipping at bottom in Create Expense flow #80472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Manual/Scan tab buttons clipping at bottom in Create Expense flow #80472
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I think it looks good? Do you mind sharing a quick before & after screenshot? |
|
Before fix:
After fix:
@shawnborton, thanks for the review. Is this what you asked for? |
|
Yup much better. Like I said in an earlier comment, let's also do a complete scan of the app to make sure the button styles aren't breaking anywhere given the padding update you are making. |
|
Sweet, looking solid 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-28.12.29.01.movAndroid: mWeb Chrome2026-01-28.12.29.01.moviOS: HybridApp2026-01-28.12.16.34.moviOS: mWeb Safari2026-01-28.12.13.18.movMacOS: Chrome / Safari2026-01-28.11.35.01.mov |
|
LGTM |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-16 🚀
|












Explanation of Change
Fix the bottom clipping of the Manual/Scan tab buttons in the Create Expense flow
Adjust layout and spacing to ensure the Manual and Scan tab buttons
are fully visible and accessible across font sizes.
Fixed Issues
$ #79887
PROPOSAL: #79887 (comment)
Tests
Prerequisite: Use a medium font size in your Android
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-11-06.at.2.11.12.PM.mov
Android: mWeb Chrome
Screen.Recording.1404-11-06.at.2.13.32.PM.mov
iOS: Native
Screen.Recording.1404-11-06.at.2.17.56.PM.mov
iOS: mWeb Safari
Screen.Recording.1404-11-06.at.2.19.09.PM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-11-06.at.2.14.06.PM.mov