Fix incomplete BA doesn't open BA setup page in invoices page by bernhardoj · Pull Request #80594 · Expensify/App

bernhardoj · 2026-01-27T08:15:13Z

Explanation of Change

Fixed Issues

$ #79561
PROPOSAL: #79561 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

Have an incomplete and complete business BA setup
Invoice is enabled

Go to any workspace settings > Invoices
Verify the incomplete BA right icon is an arrow right (>) instead of 3-dot
Press on the complete BA
Verify a 3-dot/popover menu is shown
Press on the incomplete BA
Verify it opens the BA setup page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

wbe.mp4

melvin-bot · 2026-01-27T08:15:20Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-01-27T08:21:38Z

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

                shouldSkipDefaultAccountValidation={!isSupportedGlobalReimbursement}
                invoiceTransferBankAccountID={transferBankAccountID}
                activePaymentMethodID={transferBankAccountID}
-                actionPaymentMethodType={shouldShowDefaultDeleteMenu ? paymentMethod.selectedPaymentMethodType : ''}


actionPaymentMethodType controls which payment method is currently active. When it was first implemented, we changed the selected payment method background color and it's 3-dot icon.
https://github.com/Expensify/App/pull/7374/files

But now, we don't change the bg color anymore and 3-dot icon color is already handled in ThreeDotMenu itself. So, I removed this because this also causes a wrong icon to be highlighted.

bernhardoj · 2026-01-27T08:24:51Z

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

+                iconWidth: paymentMethod.formattedSelectedPaymentMethod.icon?.iconWidth ?? paymentMethod.formattedSelectedPaymentMethod.icon?.iconSize,
+                iconStyles: paymentMethod.formattedSelectedPaymentMethod.icon?.iconStyles,
+                description: paymentMethod.formattedSelectedPaymentMethod.description,
+                wrapperStyle: [styles.mb1, styles.ph5, styles.pt5],


This is the original style of the menu item.

wrapperStyle={[styles.mb4, styles.ph5, styles.pv0]}

I changed from pv0 to pt5 because previously we had pt5 style on the inner View of the Popover.

mb4 to mb1 because each item already have pv3 style.

codecov · 2026-01-27T08:26:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/settings/Wallet/PaymentMethodListItem.tsx	`0.00% <0.00%> (ø)`
.../workspace/invoices/WorkspaceInvoiceVBASection.tsx	`0.00% <0.00%> (ø)`
... and 20 files with indirect coverage changes

trjExpensify

Makes sense 👍

…-ba-page

bernhardoj · 2026-02-05T02:08:47Z

@situchan just merged with main, please review

situchan · 2026-02-05T14:41:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios1.mov

ios2.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web1.mov

web2.mov

chatgpt-codex-connector · 2026-02-05T15:01:45Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-02-05T15:27:44Z

There's minor style difference.

back account item background
popover position, width

This branch:

Staging:

This is fine as it's consistent with other places.

OSBotify · 2026-02-05T22:56:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-10T07:23:02Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-11T06:27:30Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

bernhardoj added 3 commits January 27, 2026 15:51

don't show 3-dot on an incomplete setup ba

5a719b6

fix pressing incomplete be on invoices page doesn't open BA page

68c7c0b

refactor to use PaymentMethodList own 3-dot menu

2826fb6

bernhardoj requested review from a team as code owners January 27, 2026 08:15

melvin-bot bot assigned bernhardoj Jan 27, 2026

melvin-bot bot requested review from situchan and trjExpensify January 27, 2026 08:15

melvin-bot bot removed request for a team January 27, 2026 08:15

simplify code

cedb419

bernhardoj commented Jan 27, 2026

View reviewed changes

bernhardoj added 2 commits January 27, 2026 16:39

lint

eb3f6db

lint

1709760

trjExpensify previously approved these changes Jan 28, 2026

View reviewed changes

Merge branch 'main' into fix/79561-incomplete-invoices-ba-doesnt-open…

6ee4cde

…-ba-page

bernhardoj dismissed trjExpensify’s stale review via 6ee4cde February 5, 2026 02:08

situchan approved these changes Feb 5, 2026

View reviewed changes

melvin-bot bot requested a review from francoisl February 5, 2026 15:36

francoisl approved these changes Feb 5, 2026

View reviewed changes

francoisl merged commit 4d7c647 into Expensify:main Feb 5, 2026
30 of 32 checks passed

OSBotify mentioned this pull request Feb 10, 2026

Deploy Checklist: New Expensify 2026-02-10 #81937

Closed

Conversation

bernhardoj commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

bernhardoj Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Feb 5, 2026

Uh oh!

situchan commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Feb 5, 2026

Uh oh!

situchan commented Feb 5, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

bernhardoj commented Jan 27, 2026 •

edited

Loading

codecov bot commented Jan 27, 2026 •

edited by github-actions bot

Loading

situchan commented Feb 5, 2026 •

edited

Loading