Fix SearchMoneyRequestReport page calls openReport at least once #80613

collectioneur · 2026-01-27T11:32:09Z

Explanation of Change

Context In PR #80107, a guard was added to useEffect to prevent redundant openReport calls when loading reports with a single expense. However, this guard inadvertently blocked openReport for reports with more than two transactions.

It turns out openReport is still required at least once, even for multi-transaction reports. I have updated the logic to use a ref variable, ensuring openReport is triggered at least once upon component mount. This ensures all reports now load correctly regardless of the transaction count.

Fixed Issues

$ #80572

Tests

Create a workspace report with 3 transactions.
Click Submit on the report.
Navigate to Settings.
Select Clear cache and restart.
Return to the Reports tab.
Open the report with the three transactions.
Verify that all data loads correctly and is displayed as expected.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.12.25.51.mov

…r mount

melvin-bot · 2026-01-27T13:03:32Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-27T13:03:38Z

@ZhenjaHorbach @inimaga One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 049ab73f53

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-27T13:08:49Z

src/pages/Search/SearchMoneyRequestReportPage.tsx

    useEffect(() => {
        // Guard prevents calling openReport for multi-transaction reports
-        if (visibleTransactions.length > 2) {
+        if (visibleTransactions.length > 2 && !isInitialMountRef.current) {
            return;


Reset initial-mount guard when report changes

Because isInitialMountRef is never reset when navigating to a new report, any subsequent visit to a report with visibleTransactions.length > 2 in the same mounted screen will hit the guard and skip openReport, leaving the report uninitialized. This only shows up when the screen stays mounted across route changes (common in React Navigation). Consider resetting the ref when reportIDFromRoute changes (or keying the guard to the report ID) so each report gets one initial openReport call.

Useful? React with 👍 / 👎.

I think this is a valid concern that needs to be accounted for.

Got it. I'll take care of it now.

ZhenjaHorbach · 2026-01-27T15:48:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-01-28.16.19.29.mov

Android: mWeb Chrome

2026-01-28.16.11.58.mov

iOS: HybridApp

2026-01-28.16.19.29.mov

iOS: mWeb Safari

2026-01-28.16.11.58.mov

MacOS: Chrome / Safari

2026-01-28.16.04.27.mov

inimaga

The Codex highlighted issue needs to be resolved

trjExpensify

Dang, nice catch!

…ports

collectioneur · 2026-01-28T11:08:00Z

@inimaga Fixed switching between multi-transaction reports. It should be working as expected now

Screen.Recording.2026-01-28.at.12.05.29.mov

ZhenjaHorbach · 2026-01-28T11:30:59Z

@collectioneur
We have jest issues
Could you try to update the branch to the latest version of main?

codecov · 2026-01-28T11:42:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/SearchMoneyRequestReportPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

ZhenjaHorbach · 2026-01-28T15:21:28Z

LGTM!

inimaga

Looks good. Thanks for handling.

OSBotify · 2026-01-28T17:35:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-28T23:22:55Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix SearchMoneyRequestReport page calls openReport at least once afte…

049ab73

…r mount

melvin-bot bot assigned collectioneur Jan 27, 2026

blazejkustra approved these changes Jan 27, 2026

View reviewed changes

collectioneur marked this pull request as ready for review January 27, 2026 13:03

collectioneur requested review from a team as code owners January 27, 2026 13:03

melvin-bot bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team January 27, 2026 13:03

melvin-bot bot requested review from a team and inimaga and removed request for a team January 27, 2026 13:03

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

inimaga reviewed Jan 27, 2026

View reviewed changes

inimaga mentioned this pull request Jan 27, 2026

OpenReport Not Triggered When Opening Reports from Reports → Approve Page #80572

Open

7 tasks

trjExpensify previously approved these changes Jan 27, 2026

View reviewed changes

add logic to handle cases when switching between multi-transaction re…

4e4c42a

…ports

collectioneur dismissed trjExpensify’s stale review via 4e4c42a January 28, 2026 11:04

Merge branch 'main' into collectioneur/follow-up-fix-open-report

c34df34

ZhenjaHorbach approved these changes Jan 28, 2026

View reviewed changes

melvin-bot bot requested a review from inimaga January 28, 2026 15:21

inimaga approved these changes Jan 28, 2026

View reviewed changes

inimaga merged commit 7b892d8 into Expensify:main Jan 28, 2026
30 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

marcochavezf mentioned this pull request Jan 29, 2026

[Insights] Reports - Expense report does not open #80814

Closed

7 tasks

Fix SearchMoneyRequestReport page calls openReport at least once #80613

Fix SearchMoneyRequestReport page calls openReport at least once #80613

Uh oh!

Conversation

collectioneur commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

inimaga Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

collectioneur Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

collectioneur commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

collectioneur commented Jan 27, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 27, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading