[Home Page][Bug] Two Nav Bars shown on inbox page on desktop #80701

WojtekBoman · 2026-01-28T00:20:46Z

Explanation of Change

This issue occurs when ReportsSplitNavigator is preloaded on a small screen and then the browser window is resized to a wide layout. When preloading on a narrow layout, the report page is not added to ReportsSplitNavigator.

To fix that, ReportsSplitNavigator is removed from preloadedRoutes when expanding the browser window.

Fixed Issues

$ #80679
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open the inbox page on a wide layout.
Resize the browser window to a narrow layout.
Switch to another tab.
Wait for a moment to make sure the inbox has been preloaded.
Resize the window to the narrow layout.
Navigate to the Inbox tab.
Verify if the page has been displayed correctly.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.16.29.38.mov

codecov · 2026-01-28T00:30:55Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...n/AppNavigator/useNavigationResetOnLayoutChange.ts	`64.28% <37.50%> (-35.72%)`	⬇️
... and 7 files with indirect coverage changes

mountiny · 2026-01-28T00:41:08Z

@codex review

github-actions · 2026-01-28T00:41:36Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-28T00:46:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80701.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://80701.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

chatgpt-codex-connector · 2026-01-28T00:48:12Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-01-28T02:10:10Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-28T02:12:05Z

src/libs/Navigation/AppNavigator/useNavigationResetOnLayoutChange.ts

+        }
+
        navigation.reset(navigation.getState());
        // eslint-disable-next-line react-hooks/exhaustive-deps


❌ CONSISTENCY-5 (docs)

The ESLint rule disable lacks justification explaining why react-hooks/exhaustive-deps is disabled. The effect now uses hasLayoutBeenExpanded (which depends on previousShouldUseNarrowLayout), navigation, and calls isRoutePreloaded, but the dependency array only includes shouldUseNarrowLayout.

Suggested fix:

Add a comment explaining the reasoning:

// eslint-disable-next-line react-hooks/exhaustive-deps // We only want to reset navigation when shouldUseNarrowLayout changes, not when navigation or other derived values change

Or better, fix the dependencies to be complete and add proper memoization if needed.

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

mountiny · 2026-01-28T02:36:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef0f28f183

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-28T02:50:22Z

src/libs/Navigation/AppNavigator/useNavigationResetOnLayoutChange.ts

+        // If the ReportsSplitNavigator has been preloaded on a narrow layout, the Report page won't be displayed on a wide screen.
+        if (hasLayoutBeenExpanded && isRoutePreloaded(NAVIGATORS.REPORTS_SPLIT_NAVIGATOR)) {
+            const currentState = navigation.getState() as StackNavigationState<ParamListBase> & {preloadedRoutes?: NavigationPartialRoute[]};
+            const stateWithoutPreloadedInbox = {
+                ...currentState,
+                preloadedRoutes: currentState.preloadedRoutes?.filter((route: NavigationPartialRoute) => route.name !== NAVIGATORS.REPORTS_SPLIT_NAVIGATOR),
+            };
+            navigation.reset(stateWithoutPreloadedInbox);
+            return;


Keep layout reset from being skipped in other navigators

Because isRoutePreloaded checks the root state, this early return can fire in every navigator that uses this hook (split/search/root) whenever ReportsSplitNavigator is preloaded. In split navigators that rely on a reset to rehydrate their state for the new layout, this short‑circuits the normal layout reset and can leave the current tab in its narrow‑layout state (no sidebar) after widening the window. Example: open Settings on a narrow layout, wait for the inbox preload (1s), then resize wide — the settings split can stay single‑pane because its reset was skipped. Consider limiting this to the root navigator or still performing the layout reset for non‑root navigators after filtering preloaded routes.

Useful? React with 👍 / 👎.

…narrow layout to wide

ZhenjaHorbach · 2026-01-28T09:45:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-01-28.11.16.45.mov

Android: mWeb Chrome

2026-01-28.11.18.15.mov

iOS: HybridApp

2026-01-28.11.16.45.mov

iOS: mWeb Safari

2026-01-28.11.18.15.mov

MacOS: Chrome / Safari

2026-01-28.11.10.39.mov

ZhenjaHorbach · 2026-01-28T10:19:08Z

LGTM

OSBotify · 2026-01-28T10:47:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-28T23:23:43Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned WojtekBoman Jan 28, 2026

WojtekBoman marked this pull request as ready for review January 28, 2026 02:10

WojtekBoman requested review from a team as code owners January 28, 2026 02:10

melvin-bot bot requested review from ZhenjaHorbach and joekaufmanexpensify and removed request for a team and joekaufmanexpensify January 28, 2026 02:10

melvin-bot bot removed the request for review from a team January 28, 2026 02:10

github-actions bot reviewed Jan 28, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

Remove ReportsSplitNavigator from preloadedRoutes when resizing from …

9139281

…narrow layout to wide

WojtekBoman force-pushed the nav/fix-navigating-to-home-after-resize branch from ef0f28f to 9139281 Compare January 28, 2026 03:30

ZhenjaHorbach approved these changes Jan 28, 2026

View reviewed changes

melvin-bot bot requested a review from grgia January 28, 2026 10:19

grgia approved these changes Jan 28, 2026

View reviewed changes

grgia merged commit 531bea2 into Expensify:main Jan 28, 2026
30 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

[Home Page][Bug] Two Nav Bars shown on inbox page on desktop #80701

[Home Page][Bug] Two Nav Bars shown on inbox page on desktop #80701

Conversation

WojtekBoman commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 28, 2026

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

mountiny commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WojtekBoman commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Jan 28, 2026 •

edited

Loading