"Change workspace" option is shown offline#80720
Merged
Beamanator merged 6 commits intoExpensify:mainfrom Feb 5, 2026
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
bot
requested review from
JmillsExpensify and
jjcoffee
and removed request for
a team
7 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| expect(result).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false if policy is pending delete', async () => { |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
This test case is missing the await Onyx.set() call that is present in all other test cases within the same describe block. While the function being tested (isWorkspaceEligibleForReportChange) doesn't actually read from Onyx (it just checks the object passed to it), maintaining consistency with the existing test pattern is important for maintainability.
Suggested fix:
it('returns false if policy is pending delete', async () => {
const currentUserLogin = employeeEmail;
const newPolicy = {
...createRandomPolicy(1, CONST.POLICY.TYPE.TEAM),
isPolicyExpenseChatEnabled: true,
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
};
await Onyx.set(`${ONYXKEYS.COLLECTION.POLICY}${newPolicy.id}`, newPolicy);
const result = isWorkspaceEligibleForReportChange(currentUserLogin, newPolicy);
expect(result).toBe(false);
});Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
There was a problem hiding this comment.
Onyx.set here is not really neccessary because we don't need to use storage data on this one.
Contributor
|
@mkzie2 Performance tests are failing. Any idea why? |
JmillsExpensify
approved these changes
Feb 2, 2026
Contributor
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
Agree that you can't change workspaces offline.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2026-02-03_15.36.21.mp4Android: mWeb Chromeandroid-chrome-2026-02-03_15.38.54.mp4iOS: HybridAppios-app-2026-02-03_15.31.37.mp4iOS: mWeb Safariios-safari-2026-02-03_15.33.35.mp4MacOS: Chrome / Safaridesktop-chrome-2026-02-03_15.28.40.mp4 |
jjcoffee
suggested changes
Feb 3, 2026
Contributor
jjcoffee
left a comment
jjcoffee
left a comment
There was a problem hiding this comment.
Tests well and code looks good. Just the perf tests need sorting - maybe merging main will do the trick?
Contributor
Author
|
All test passed 👍 |
Beamanator
approved these changes
Feb 5, 2026
Contributor
|
🚧 @Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.13-1 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.15-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #79075
PROPOSAL: #79075 (comment)
Tests
Precondition: Have 2 Workspaces
Offline tests
QA Steps
Precondition: Have 2 Workspaces
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-29.at.22.09.32.mov
Android: mWeb Chrome
Screen.Recording.2026-01-29.at.22.10.56.mov
iOS: Native
Screen.Recording.2026-01-29.at.22.12.01.mov
iOS: mWeb Safari
Screen.Recording.2026-01-29.at.22.13.58.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-29.at.22.15.19.mov