fix: preserve navigation state when opening settings from Onfido permission flow #80741

MobileMage · 2026-01-28T13:42:05Z

Explanation of Change

On iOS, when a user denies camera permission during Onfido identity verification and then taps "Settings" to grant it, the app restarts when the permission is changed. This causes the user to exit the verification flow and land on the home screen.

This PR adds a call to saveLastRoute() before opening settings, which preserves the navigation state. When the app restarts after the permission change, the user is returned to the verification screen instead of losing their progress.

Fixed Issues

$ #79661
PROPOSAL: #79661 (comment)

Tests

Open the app on iOS and start the Onfido identity verification flow
When prompted for camera permission, deny it
Tap "Settings" in the permission dialog
In iOS Settings, enable camera permission for the app
Verify the app returns to the verification flow (not the home screen)

Verify that no errors appear in the JS console

Offline tests

N/A - This change only affects the navigation state preservation when opening iOS Settings. The offline behavior is unchanged.

QA Steps

Same as Tests - this must be tested on a physical iOS device as the app restart behavior only occurs on real devices.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - This is an iOS-specific issue. The app restart behavior when changing permissions only occurs on iOS.

Android: mWeb Chrome

N/A - Native only change (index.native.tsx)

iOS: Native

79661-ios-native.mp4

iOS: mWeb Safari

N/A - Native only change (index.native.tsx)

MacOS: Chrome / Safari

N/A - Native only change (index.native.tsx)

melvin-bot · 2026-01-28T13:42:12Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-28T13:52:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Onfido/index.native.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

bernhardoj · 2026-01-29T07:18:53Z

src/components/Onfido/index.native.tsx

+                                                // Save the current route so the user can return to the verification flow
+                                                // after granting permissions in settings. On iOS, the app restarts when
+                                                // certain permissions are changed, so we need to preserve the navigation state.
+                                                saveLastRoute();


I forgot to say this, but let's use goToSettings function instead.

https://github.com/Expensify/App/blob/main/src/libs/goToSettings/index.native.tsx

bernhardoj · 2026-01-29T07:34:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

bernhardoj

Small comment left, gonna approve so it can be merged when I'm inactive

On iOS, when the user navigates to Settings to grant camera permissions, the app may restart when permissions are changed. This causes the user to lose their place in the verification flow. By calling saveLastRoute() before opening settings, we preserve the navigation state so the user returns to the verification screen after granting permissions.

…nSettings

MobileMage · 2026-01-31T09:04:51Z

@bernhardoj fixed

bernhardoj · 2026-02-01T14:51:50Z

@amyevans ready to merge

MobileMage requested review from a team as code owners January 28, 2026 13:42

melvin-bot bot assigned MobileMage Jan 28, 2026

melvin-bot bot requested review from JmillsExpensify and bernhardoj and removed request for a team and JmillsExpensify January 28, 2026 13:42

melvin-bot bot removed the request for review from a team January 28, 2026 13:42

bernhardoj reviewed Jan 29, 2026

View reviewed changes

bernhardoj approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot requested a review from amyevans January 29, 2026 07:35

MobileMage added 3 commits January 31, 2026 09:33

Use goToSettings helper instead of manual saveLastRoute + Linking.ope…

071c7a8

…nSettings

Retrigger CI checks

80b062e

MobileMage force-pushed the fix/79661-onfido-camera-permission branch from 33edeaf to 80b062e Compare January 31, 2026 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: preserve navigation state when opening settings from Onfido permission flow #80741

fix: preserve navigation state when opening settings from Onfido permission flow #80741

MobileMage commented Jan 28, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

Uh oh!

bernhardoj Jan 29, 2026

Uh oh!

bernhardoj commented Jan 29, 2026

Uh oh!

bernhardoj left a comment •

edited

Loading

Uh oh!

MobileMage commented Jan 31, 2026

Uh oh!

bernhardoj commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: preserve navigation state when opening settings from Onfido permission flow #80741

Are you sure you want to change the base?

fix: preserve navigation state when opening settings from Onfido permission flow #80741

Conversation

MobileMage commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jan 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MobileMage commented Jan 31, 2026

Uh oh!

bernhardoj commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MobileMage commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

bernhardoj left a comment •

edited

Loading