fix: prevent iOS crash when sharing images via AttachmentPreview by marcochavezf · Pull Request #80791 · Expensify/App

marcochavezf · 2026-01-28T20:21:09Z

Explanation of Change

The iOS app was crashing when users tried to share an image from their device's media library. The root cause was that useVideoPlayer(source) was being called unconditionally for all attachment sources (including images) in AttachmentPreview.tsx. When expo-video attempted to process a non-video file (like an image), it caused a crash on iOS.

This fix:

Moves the file type checks (isVideo, isFileImage) above the video hooks
Conditionally passes the source to useVideoPlayer only when it's actually a video file: useVideoPlayer(isVideo ? source : null)
Reuses the isVideo variable in the conditional render instead of duplicating the check

Fixed Issues

$ #80710
PROPOSAL: #80710 (comment)

Tests

On an iOS device, open the Photos app and select an image
Tap the Share button
Select "Expensify" from the share sheet
Select any contact or workspace to share to
Verify the app does NOT crash and the share flow completes successfully

Verify that no errors appear in the JS console

Offline tests

N/A - This fix is for the iOS Share Extension which requires network connectivity to function.

QA Steps

On an iOS device, open the Photos app and select an image
Tap the Share button
Select "Expensify" from the share sheet
Select any contact or workspace to share to
Verify the app does NOT crash and the share flow completes successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - iOS-specific Share Extension fix

Android: mWeb Chrome

N/A - iOS-specific Share Extension fix

iOS: Native

See video confirmation from @blazejkustra in issue: #80710 (comment)

iOS: mWeb Safari

N/A - iOS-specific Share Extension fix

MacOS: Chrome / Safari

N/A - iOS-specific Share Extension fix

melvin-bot · 2026-01-28T20:21:16Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Move file type checks (isVideo, isFileImage) above video hooks and conditionally pass source to useVideoPlayer only for video files. This prevents expo-video from attempting to process non-video sources which was causing iOS crashes when sharing images.

github-actions · 2026-01-28T20:24:48Z

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-01-28T20:33:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AttachmentPreview.tsx	`0.00% <0.00%> (ø)`
... and 6 files with indirect coverage changes

ZhenjaHorbach · 2026-01-28T20:38:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-01-28.22.27.08.mov

Android: mWeb Chrome

2026-01-28.22.13.10.mov

iOS: HybridApp

2026-01-28.22.27.08.mov

iOS: mWeb Safari

2026-01-28.22.13.10.mov

MacOS: Chrome / Safari

2026-01-28.22.10.05.mov

github-actions · 2026-01-28T21:05:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80791.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-10e20ebce2599e2bd40f9607adaa43645977e849/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://80791.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2026-01-28T21:28:58Z

LGTM!

ZhenjaHorbach · 2026-01-28T21:29:37Z

And the builds issue is known

melvin-bot · 2026-01-28T21:30:30Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2026-01-28T21:43:00Z

Confirmed that the remote iOS build failures are unrelated.

melvin-bot · 2026-01-28T21:43:40Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

…hare-crash-v2 fix: prevent iOS crash when sharing images via AttachmentPreview (cherry picked from commit daa914f) (cherry-picked to staging by roryabraham)

OSBotify · 2026-01-28T21:54:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-28T22:22:14Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:58:52Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T23:24:10Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:24:41Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

marcochavezf requested review from a team as code owners January 28, 2026 20:21

melvin-bot bot assigned marcochavezf Jan 28, 2026

melvin-bot bot requested review from shubham1206agra and trjExpensify and removed request for a team January 28, 2026 20:21

marcochavezf force-pushed the marcochavezf/fix-80710-ios-share-crash-v2 branch from cf077e8 to 5817bfb Compare January 28, 2026 20:23

marcochavezf requested review from ZhenjaHorbach and removed request for shubham1206agra January 28, 2026 20:45

ZhenjaHorbach approved these changes Jan 28, 2026

View reviewed changes

melvin-bot bot requested a review from MariaHCD January 28, 2026 21:30

roryabraham approved these changes Jan 28, 2026

View reviewed changes

roryabraham merged commit daa914f into main Jan 28, 2026
32 of 38 checks passed

roryabraham deleted the marcochavezf/fix-80710-ios-share-crash-v2 branch January 28, 2026 21:43

melvin-bot bot added the Emergency label Jan 28, 2026

roryabraham removed the Emergency label Jan 28, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 28, 2026

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Conversation

marcochavezf commented Jan 28, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026

Uh oh!

ZhenjaHorbach commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

roryabraham commented Jan 28, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Jan 28, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 28, 2026 •

edited

Loading