fix: unable to see the fourth split row while put cursor on it by daledah · Pull Request #80858 · Expensify/App

daledah · 2026-01-29T07:05:36Z

Explanation of Change

Fixed Issues

$ #79546
PROPOSAL: #79546 (comment)

Tests

Precondition: Create a manual expense to workspace chat

Open app
Navigate to workspace chat having a manual expense
Tap on expense preview for go to detail page
Tap More button and select Split
Tap two times on Add split
Put cursor on the last row
Slide up screen for see the last row
Put cursor on the last row
Verify that: User can see the last row while put cursor on it

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

am.mov

iOS: Native

result.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

codecov · 2026-01-29T07:15:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`66.35% <18.18%> (-6.42%)`	⬇️
... and 19 files with indirect coverage changes

melvin-bot · 2026-01-29T16:48:23Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-02-02T10:22:13Z

@hoangzinh i updated, please review again

hoangzinh · 2026-02-04T05:23:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-06.at.06.14.43.mov

Android: mWeb Chrome

Screen.Recording.2026-02-04.at.17.08.56.android.c.mov

iOS: HybridApp

Screen.Recording.2026-03-06.at.06.17.08.mov

iOS: mWeb Safari

Screen.Recording.2026-02-04.at.17.17.22.ios.s.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-04.at.16.45.38.web.mov

hoangzinh · 2026-02-04T10:22:56Z

@daledah sometimes, it didn't work on Android

Screen.Recording.2026-02-04.at.17.21.15.mov

daledah · 2026-02-07T13:12:19Z

@hoangzinh Do you have any steps that can be reliably reproduced?

hoangzinh · 2026-02-09T05:34:33Z

Honestly, I don't @daledah. Hmm, is it related to the device?

daledah · 2026-02-10T16:33:20Z

Honestly, I don't @daledah. Hmm, is it related to the device?

I've tried many times on Android but it won't reproduce.

hoangzinh · 2026-02-16T07:16:05Z

@daledah can you share your recording, please? Please merge the latest main again.

daledah · 2026-02-19T16:12:51Z

android.mov

This is the result on my end

hoangzinh · 2026-02-20T01:21:00Z

@daledah Do you mind to try if you can reproduce original issue on main branch?

daledah · 2026-02-23T08:56:22Z

Screen.Recording.2026-02-23.at.15.47.37.mov

Screen.Recording.2026-02-23.at.15.55.52.mov

@hoangzinh i can't reproduce this bug on Android but i can reproduce this bug on IOS

hoangzinh · 2026-02-26T07:33:58Z

@daledah it works on my simulator after I reverted this commit 0d65eb5. Does it help you find root cause?

daledah · 2026-03-02T07:29:08Z

thanks for your support, i'm checking now

daledah · 2026-03-02T07:40:07Z

android.mov

@hoangzinh i updated, please check again

hoangzinh · 2026-03-04T12:16:32Z

+                    scrollTimeoutRef.current = null;
+                }
+                // Add small delay after keyboard is shown for layout to settle
+                scrollTimeoutRef.current = setTimeout(performScroll, CONST.ANIMATION_IN_TIMING);


@daledah does it mean even keyboardDidShow is fired, but the layout is not ready yet?

Yes, exactly. Even after keyboardDidShow fires, the layout may not have fully adjusted yet

hoangzinh

LGTM 🚢

github-actions · 2026-03-06T14:54:42Z

🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T14:59:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80858.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c2280c3-5430cbd-9eba66f84415d5769f4f6c4deadc0b5869c2bc16/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c2280c3-5430cbd-40aca5860ad240782784277d27d7a632bce92337/index.html

Web 🕸️
https://80858.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T15:01:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T23:02:02Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:37:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: unable to see the fourth split row while put cursor on it

d48622f

melvin-bot Bot assigned daledah Jan 29, 2026

daledah marked this pull request as ready for review January 29, 2026 16:48

daledah requested review from a team as code owners January 29, 2026 16:48

melvin-bot Bot requested review from heyjennahay and hoangzinh and removed request for a team January 29, 2026 16:48

melvin-bot Bot removed the request for review from a team January 29, 2026 16:48

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/components/SelectionList/BaseSelectionList.tsx

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread src/components/SelectionList/BaseSelectionList.tsx

daledah added 2 commits February 2, 2026 17:07

Merge branch 'main' into fix/79546

11d07a0

remove useless timeout

0d65eb5

daledah added 2 commits February 19, 2026 10:21

Merge branch 'main' into fix/79546

12f918d

Merge branch 'main' into fix/79546

784242a

Merge branch 'main' into fix/79546

7a4d8e7

add delay for layout to settle

53c370a

hoangzinh reviewed Mar 4, 2026

View reviewed changes

Merge branch 'main' into fix/79546

5e369c6

hoangzinh approved these changes Mar 5, 2026

View reviewed changes

melvin-bot Bot requested a review from flodnv March 5, 2026 23:19

flodnv approved these changes Mar 6, 2026

View reviewed changes

flodnv merged commit c2280c3 into Expensify:main Mar 6, 2026
30 of 31 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

melvin-bot Bot mentioned this pull request Mar 9, 2026

[Due for payment 2026-03-16] [$250] iOS - Expense - Unable to see the fourth split row while put cursor on it #79546

Closed

7 tasks

Conversation

daledah commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

daledah commented Feb 2, 2026

Uh oh!

hoangzinh commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Feb 4, 2026

Uh oh!

daledah commented Feb 7, 2026

Uh oh!

hoangzinh commented Feb 9, 2026

Uh oh!

daledah commented Feb 10, 2026

Uh oh!

hoangzinh commented Feb 16, 2026

Uh oh!

daledah commented Feb 19, 2026

Uh oh!

hoangzinh commented Feb 20, 2026

Uh oh!

daledah commented Feb 23, 2026

Uh oh!

hoangzinh commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Mar 2, 2026

Uh oh!

daledah commented Mar 2, 2026

Uh oh!

hoangzinh Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jan 29, 2026 •

edited

Loading

codecov Bot commented Jan 29, 2026 •

edited by github-actions Bot

Loading

hoangzinh commented Feb 4, 2026 •

edited

Loading

hoangzinh commented Feb 26, 2026 •

edited

Loading