-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Fix app crashing when sharing videos on iOS #80884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix app crashing when sharing videos on iOS #80884
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridApp2026-01-29.15.01.37.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
LGTM! |
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix app crashing when sharing videos on iOS (cherry picked from commit e39919e) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.11-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.11-10 🚀
|
|
@blazejkustra @mountiny Crash issue is fixed, Able to reproduce the 1769723590208.CP_2.mp41769724122453.Screenrecorder-2026-01-29-23-59-36-20.mp4 |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.11-16 🚀
|
Explanation of Change
@daledah noticed a crash on ios when sharing a video to the app.
Turns out there is a bug in how generateThumbnailsAsync works on ios, casting from int to int array is currently broken.
Fixed Issues
$ #64846
PROPOSAL: N/A
Tests
Check on native android and iOS:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
untitled.webm
iOS: Native
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2026-01-29.at.14.30.18.mov