-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Sprint] Release 3.3 - Deleting Personal Card Feed #80927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f64ef7c2ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment was marked as resolved.
This comment was marked as resolved.
|
@situchan, comments addressed |
|
App freezes on iOS. This is because delete modal is opened immediately before option modal is fully dismissed. Screen.Recording.2026-01-30.at.7.26.33.AM.mov |
What about now? |
Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>
|
I'll move the delete button to the new Card details page |
trjExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core PR for a WN project. 👍
Actually, for now, let's keep the old menu for CSV cards. We can merge both projects once they are more stable. Ready for review! |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.11-16 🚀
|


Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/593054
PROPOSAL:
Tests
Log into oldDot and go to Account > Wallet > Import Transactions from File. You can use this file:
fake_transactions-2026-01-16 10_56_55.629.csv
After importing, Log into Newdot with the same account. Go to Account > Wallet and confirm you see the card like so:
Confirm the Associated transactions are displayed two
No click The 3-dot menu by the card and Select
delete. Complete the process.Confirm the card and the transactions are gone
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari