Skip to content

Conversation

@WojtekBoman
Copy link
Contributor

@WojtekBoman WojtekBoman commented Jan 30, 2026

Explanation of Change

This PR fixes a padding issue in the Home Page AnnouncementSection and DiscoverSection components and adds styling improvements for both sections.

Changes made:

  1. Fixed padding issue: Changed from pl5/pl8 (padding-left only) to ph5/ph8 (padding-horizontal) in both AnnouncementSection and DiscoverSection to ensure proper symmetric padding on both sides of the content.

  2. Added compact view mode: Applied viewMode={CONST.OPTION_MODE.COMPACT} and hasSubMenuItems to both sections for consistent compact styling.

  3. Added rightIconWrapperStyle prop to MenuItem: Introduced a new optional prop to allow custom styling for the right icon wrapper, enabling the sections to apply styles.pl2 spacing for proper alignment of the arrow icon.

Fixed Issues

$ #80139
$ #80873
PROPOSAL:

Tests

  1. Navigate to the Home Page
  2. Verify the Announcements section displays correctly with proper padding on both left and right sides
  3. Verify the Discover section displays correctly with proper padding on both left and right sides
  4. Verify the arrow icons on the right side of each menu item are properly aligned
  5. Resize the window between narrow and wide layouts to confirm padding adjusts appropriately (ph5 for narrow, ph8 for wide)
  6. Tap on an announcement item and verify it opens the correct URL
  7. Verify that no errors appear in the JS console

Offline tests

  1. Enable airplane mode / disconnect from the internet
  2. Navigate to the Home Page
  3. Verify the Announcements section still displays correctly with proper padding
  4. Verify the Discover section still displays correctly with proper padding

QA Steps

  1. Navigate to the Home Page
  2. Verify the Announcements section has proper horizontal padding (not just left padding)
  3. Verify the Discover section has proper horizontal padding (not just left padding)
  4. Verify arrow icons are properly aligned with consistent spacing
  5. Test on both narrow (mobile) and wide (desktop) layouts
  6. Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman WojtekBoman changed the title Adjust home widgets styles [Home Page] Remove Beta Gate for Release 1 Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.50% <ø> (ø)
src/ROUTES.ts 13.03% <ø> (-0.12%) ⬇️
src/components/FloatingActionButton.tsx 95.65% <100.00%> (-1.32%) ⬇️
.../FloatingCameraButton/BaseFloatingCameraButton.tsx 84.21% <ø> (-0.79%) ⬇️
src/components/MenuItem.tsx 87.80% <ø> (ø)
src/libs/Navigation/AppNavigator/AuthScreens.tsx 53.12% <ø> (ø)
src/libs/Navigation/AppNavigator/PublicScreens.tsx 100.00% <ø> (ø)
src/libs/Navigation/helpers/getRedirectedPath.ts 100.00% <100.00%> (ø)
src/libs/Navigation/helpers/getStateFromPath.ts 87.50% <100.00%> (+1.78%) ⬆️
src/pages/home/AnnouncementSection.tsx 87.50% <100.00%> (+87.50%) ⬆️
... and 10 more
... and 107 files with indirect coverage changes

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@WojtekBoman WojtekBoman force-pushed the home-page/remove-beta branch from e0259db to 268d095 Compare January 30, 2026 01:06
@WojtekBoman WojtekBoman marked this pull request as ready for review January 30, 2026 01:07
@WojtekBoman WojtekBoman requested review from a team as code owners January 30, 2026 01:07
@melvin-bot melvin-bot bot requested review from Ollyws and joekaufmanexpensify and removed request for a team January 30, 2026 01:07
@melvin-bot
Copy link

melvin-bot bot commented Jan 30, 2026

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@WojtekBoman
Copy link
Contributor Author

cc: @ZhenjaHorbach @grgia for review

@github-actions

This comment has been minimized.

@github-project-automation github-project-automation bot moved this to Backlog in Home page Jan 30, 2026
@mountiny mountiny moved this from Backlog to In review in Home page Jan 30, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 268d095c5a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 62 to +64
// This route renders the list of reports.
INBOX: 'home',
// @TODO: Rename it to 'home' and INBOX to 'inbox' when removing the newDotHome beta
HOME: 'home-page',
INBOX: 'inbox',
HOME: 'home',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep legacy /home-page route for existing links

This change drops the home-page path entirely by redefining ROUTES.HOME to home with no alias. Any users who had the beta enabled could have /home-page stored as their last visited path (restored on startup via NavigationRoot), and external links or bookmarks can still point to that URL. With no route match, those cases will now land on Not Found or fail to restore the last session. Consider adding a redirect/alias for home-page or migrating stored paths to home to avoid a regression for existing users.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@WojtekBoman WojtekBoman force-pushed the home-page/remove-beta branch from 41104bb to 5dc8055 Compare January 30, 2026 02:32
@github-actions
Copy link
Contributor

@mountiny
Copy link
Contributor

Asked for the testing

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 30, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-01-30.12.50.46.mov
Android: mWeb Chrome
2026-01-30.12.46.27.mov
iOS: HybridApp
2026-01-30.12.50.46.mov
iOS: mWeb Safari
2026-01-30.12.46.27.mov
MacOS: Chrome / Safari
2026-01-30.10.21.01.mov

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 30, 2026

I still can reproduce this issue
#80931 (comment)

The easiest way is with throttling enabled

2026-01-30.10.24.52.mov

@jponikarchuk
Copy link

Home - "Pay 1 report" is shown after approver leaves workspace

Version Number: v9.3.11-12 PR:80965
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): huisdhbisubhdiushuids2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

Precondition:

  • Admin invites non-admin approver and member to the workspace.
  1. Go to 80965.pr-testing.expensify.com/
  2. [Member] Go to workspace chat.
  3. [Member] Create an expense. Do not click Submit on the preview.
  4. [Non-admin approver] Open member's workspace chat.
  5. [Non-admin approver] Leave the workspace.
  6. [Non-admin approver] Go to Home.

Expected Result:

"Pay 1 report" will not appear on For you section.

Actual Result:

"Pay 1 report" appears on For you section after approver leaves workspace.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Inbox - Unending skeleton loader when opening inbox

Version Number: v9.3.11-12 PR:80965
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS chrome

Action Performed:

  1. Go to https://80965.pr-testing.expensify.com/
  2. Enter sign in email > Continue > Join
  3. Click Skip > Track and budget expense > Enter name > Continue > Skip
  4. Click on Inbox
  5. If there is no skeleton repeat step 1 to 4 one more time

Expected Result:

Chat should load

Actual Result:

Unending skeleton loader

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@mitarachim
Copy link

Onboarding - "This content is blocked" page opens when invited member opens onboarding

Version Number: v9.3.11-12 PR:80965
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): yonghongkok2+sdj11noisjndoinjs@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

Precondition:

  • Admin invites a new member (no Expensify account yet) to the workspace.
  1. Go to 80965.pr-testing.expensify.com/
  2. Log in as the invited member.
  3. Open FAB > Take a 2-minute test drive.

Expected Result:

Test drive page opens without issue.

Actual Result:

"This content is blocked" page opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7061849_1769771216471.2.mp4

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

@adamgrzybowski
Copy link
Contributor

Hey @ZhenjaHorbach, could you please retest this PR? I think we are so close to merging this!

@dannymcclain
Copy link
Contributor

Looking good! Mentioned this to Vit in person, but for posterity, I think the only thing we need is the hover state on the to-do rows that Shawn mentioned somewhere at some point.

@ZhenjaHorbach
Copy link
Contributor

About this issue
#80965 (comment)
https://swmansion.slack.com/docs/T03Q9AMJJ/F0ABVSK9S9H

Are we going to fix this or is it not ours? 😅

@ZhenjaHorbach
Copy link
Contributor

Weird
I can still reproduce this issue

#80965

2026-01-30.23.07.37.mov

@m-natarajan
Copy link

m-natarajan commented Jan 30, 2026

#80965 (comment)

Not repro, Win 11 chrome, v9.3.11-15 PR:80965

Recording.2323.mp4

#80965 (comment)
Not repro, Win 11 chrome, v9.3.11-15 PR:80965

Recording.2322.mp4

#80965 (comment)
Page is scrollable, Not sure where the truncation is (iPhone Xs)
Fixed

RPReplay_Final1769810493.MP4
IMG_1132

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 30, 2026

@dannymcclain
Do we need to update the image?
Since the elements are cut a bit unevenly 😅

image

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 30, 2026

#80965 (comment) Page is scrollable, Not sure where the truncation is (iPhone Xs)

RPReplay_Final1769810493.MP4

I talked about it 😅

Снимок экрана 2026-01-30 в 23 20 52

But everything's good now!

Снимок экрана 2026-01-30 в 23 21 44

@mountiny
Copy link
Contributor

Looking good! Mentioned this to Vit in person, but for posterity, I think the only thing we need is the hover state on the to-do rows that Shawn mentioned somewhere at some point.

Should be fixed

@dannymcclain
Copy link
Contributor

Do we need to update the image? Since the elements are cut a bit unevenly 😅

Yeah if we're using that thumbs up image anywhere let's try replacing it with this one if we can (this is not a blocker though).

simple-illustration__thumbsupstars-home.svg.zip

mountiny
mountiny previously approved these changes Jan 30, 2026
@mountiny mountiny merged commit 4c810b5 into Expensify:main Jan 30, 2026
42 of 46 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Home page Jan 30, 2026
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-17 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya
Copy link

Regression Ad-hoc is at 93%

Just 5 IOS slots and 1 Android pending validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.