-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Home Page] Remove Beta Gate for Release 1 #80965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Home Page] Remove Beta Gate for Release 1 #80965
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
e0259db to
268d095
Compare
|
cc: @ZhenjaHorbach @grgia for review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 268d095c5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // This route renders the list of reports. | ||
| INBOX: 'home', | ||
| // @TODO: Rename it to 'home' and INBOX to 'inbox' when removing the newDotHome beta | ||
| HOME: 'home-page', | ||
| INBOX: 'inbox', | ||
| HOME: 'home', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep legacy /home-page route for existing links
This change drops the home-page path entirely by redefining ROUTES.HOME to home with no alias. Any users who had the beta enabled could have /home-page stored as their last visited path (restored on startup via NavigationRoot), and external links or bookmarks can still point to that URL. With no route match, those cases will now land on Not Found or fail to restore the last session. Consider adding a redirect/alias for home-page or migrating stored paths to home to avoid a regression for existing users.
Useful? React with 👍 / 👎.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
41104bb to
5dc8055
Compare
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Asked for the testing |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-30.12.50.46.movAndroid: mWeb Chrome2026-01-30.12.46.27.moviOS: HybridApp2026-01-30.12.50.46.moviOS: mWeb Safari2026-01-30.12.46.27.movMacOS: Chrome / Safari2026-01-30.10.21.01.mov |
|
I still can reproduce this issue The easiest way is with throttling enabled 2026-01-30.10.24.52.mov |
Home - "Pay 1 report" is shown after approver leaves workspaceVersion Number: v9.3.11-12 PR:80965 Action Performed:Precondition:
Expected Result:"Pay 1 report" will not appear on For you section. Actual Result:"Pay 1 report" appears on For you section after approver leaves workspace. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Inbox - Unending skeleton loader when opening inboxVersion Number: v9.3.11-12 PR:80965 Action Performed:
Expected Result:Chat should load Actual Result:Unending skeleton loader Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Onboarding - "This content is blocked" page opens when invited member opens onboardingVersion Number: v9.3.11-12 PR:80965 Action Performed:Precondition:
Expected Result:Test drive page opens without issue. Actual Result:"This content is blocked" page opens. Workaround:Unknown Platforms:
Screenshots/VideosBug7061849_1769771216471.2.mp4 |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Hey @ZhenjaHorbach, could you please retest this PR? I think we are so close to merging this! |
|
Looking good! Mentioned this to Vit in person, but for posterity, I think the only thing we need is the hover state on the to-do rows that Shawn mentioned somewhere at some point. |
|
About this issue Are we going to fix this or is it not ours? 😅 |
|
Weird 2026-01-30.23.07.37.mov |
|
Not repro, Win 11 chrome, v9.3.11-15 PR:80965 Recording.2323.mp4#80965 (comment) Recording.2322.mp4#80965 (comment) RPReplay_Final1769810493.MP4 |
|
@dannymcclain
|
I talked about it 😅
But everything's good now!
|
Should be fixed |
Yeah if we're using that thumbs up image anywhere let's try replacing it with this one if we can (this is not a blocker though). |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-17 🚀
|
|
Regression Ad-hoc is at 93% Just 5 IOS slots and 1 Android pending validation. |



Explanation of Change
This PR fixes a padding issue in the Home Page
AnnouncementSectionandDiscoverSectioncomponents and adds styling improvements for both sections.Changes made:
Fixed padding issue: Changed from
pl5/pl8(padding-left only) toph5/ph8(padding-horizontal) in bothAnnouncementSectionandDiscoverSectionto ensure proper symmetric padding on both sides of the content.Added compact view mode: Applied
viewMode={CONST.OPTION_MODE.COMPACT}andhasSubMenuItemsto both sections for consistent compact styling.Added
rightIconWrapperStyleprop toMenuItem: Introduced a new optional prop to allow custom styling for the right icon wrapper, enabling the sections to applystyles.pl2spacing for proper alignment of the arrow icon.Fixed Issues
$ #80139
$ #80873
PROPOSAL:
Tests
ph5for narrow,ph8for wide)Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari