fix: Search not return group when entering user names#80968
Merged
blimpich merged 6 commits intoExpensify:mainfrom Feb 5, 2026
Merged
fix: Search not return group when entering user names#80968blimpich merged 6 commits intoExpensify:mainfrom
blimpich merged 6 commits intoExpensify:mainfrom
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Collaborator
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-search-usernames.movAndroid: mWeb Chromemweb-chrome-search-usernames.moviOS: HybridAppios-search-usernames.moviOS: mWeb Safarimweb-safari-search-usernames.movMacOS: Chrome / Safariweb-search-usernames.mov |
mananjadhav
approved these changes
Feb 3, 2026
Collaborator
mananjadhav
left a comment
There was a problem hiding this comment.
All good except for the pending comment here
Contributor
|
Can we please add unit tests so that we aren't decreasing code coverage? |
Contributor
Author
|
I just added unit test |
blimpich
approved these changes
Feb 5, 2026
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.13-1 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.15-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #80200
PROPOSAL: #80200 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-30.at.07.42.04.mov
Android: mWeb Chrome
Screen.Recording.2026-01-30.at.07.38.08.mov
iOS: Native
Screen.Recording.2026-01-30.at.07.40.39.mov
iOS: mWeb Safari
Screen.Recording.2026-01-30.at.07.35.35.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-30.at.07.32.53.mov