[CP Staging] Fix translating you
#80973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
abdulrahuman5196 and
joekaufmanexpensify
and removed request for
a team
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
7 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| callback: (value) => { | ||
| if (value ?? true) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-5
ESLint rule disables must include a comment explaining why the rule is being disabled. This helps team members understand the exception and ensures code quality is maintained.
Suggested fix:
// translateLocal is deprecated in favor of useLocalize hook, but this is a module-level
// initialization that cannot use hooks, so we must use the deprecated function
// eslint-disable-next-line @typescript-eslint/no-deprecated
youTranslation = translateLocal('common.you').toLowerCase();Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
src/libs/PersonalDetailsUtils.ts
Outdated
| if (!youTranslation) { | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated | ||
| youTranslation = translateLocal('common.you').toLowerCase(); | ||
| } |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-5
ESLint rule disables must include a comment explaining why the rule is being disabled. This helps team members understand the exception and ensures code quality is maintained.
Suggested fix:
// translateLocal is deprecated in favor of useLocalize hook, but this is a module-level
// initialization that cannot use hooks, so we must use the deprecated function
// eslint-disable-next-line @typescript-eslint/no-deprecated
hiddenTranslation = translateLocal('common.hidden');Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62d0adb060
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
blimpich
approved these changes
Jan 30, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
robertjchen
approved these changes
Jan 30, 2026
francoisl
approved these changes
Jan 30, 2026
OSBotify
pushed a commit
that referenced
this pull request
Jan 30, 2026
[CP Staging] Fix translating `you` (cherry picked from commit ece75f4) (cherry-picked to staging by francoisl)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.11-13 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.11-16 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
I think there is a race condition going on where if translations are loaded before we connect to it we will never update the
youtransalation.This PR aims to fix that, not sure what changed recently that this is more prominent, but it is.
Fixed Issues
$ #80836
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
(you)when seeing yourself in the contacts listPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-01-29.at.17.44.39.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari