refactor createWorkspace to use isSelfTourViewed from useOnyx by dukenv0307 · Pull Request #80979 · Expensify/App

dukenv0307 · 2026-01-30T01:53:28Z

Explanation of Change

Fixed Issues

$ #66424
PROPOSAL:

Tests

Create the new workspace
Verify the new workspace is created successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-30.at.08.50.46.mov

codecov · 2026-01-30T02:03:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/AppNavigator/AuthScreens.tsx	`53.33% <100.00%> (+0.20%)`	⬆️
src/libs/actions/App.ts	`47.34% <100.00%> (ø)`
src/libs/actions/Policy/Policy.ts	`37.91% <100.00%> (+0.94%)`	⬆️
src/components/SettlementButton/index.tsx	`0.00% <0.00%> (ø)`
...estedFeatures/BaseOnboardingInterestedFeatures.tsx	`0.00% <0.00%> (ø)`
...nfirmation/BaseOnboardingWorkspaceConfirmation.tsx	`0.00% <0.00%> (ø)`
...ages/Travel/WorkspaceConfirmationForTravelPage.tsx	`0.00% <0.00%> (ø)`
...c/pages/iou/request/step/IOURequestStepUpgrade.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/WorkspaceConfirmationPage.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

melvin-bot · 2026-01-30T02:28:24Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-02-02T05:13:07Z

@DylanDylann can you please review this PR?

JmillsExpensify

Product review not required.

DylanDylann · 2026-02-04T10:22:05Z

@dukenv0307 Please check this: #80979 (comment)

dukenv0307 · 2026-02-09T03:40:32Z

All tests passed on my end, will try to merge main soon cc @DylanDylann

dukenv0307 · 2026-02-12T10:30:02Z

@DylanDylann Kindly bump

DylanDylann · 2026-02-16T09:54:08Z

    onboardingPurposeSelected?: OnboardingPurpose;
    shouldAddGuideWelcomeMessage?: boolean;
    shouldCreateControlPolicy?: boolean;
+    // TODO: Make it required once we complete refactoring the buildPolicyData function to use isSelfTourViewed


Please link the issue where this will be addressed

DylanDylann · 2026-02-16T10:31:26Z

+type CreateWorkspaceDataOptions = Omit<BuildPolicyDataOptions, 'isSelfTourViewed'> & {
+    isSelfTourViewed: boolean;


Why do we need to remove isSelfTourViewed and add it again?

If this is just a temporary change to enforce that isSelfTourViewed always exists, please add a TODO comment to remove this type later

DylanDylann · 2026-02-16T10:37:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-02-16.at.17.36.36.mov

DylanDylann · 2026-02-16T10:38:17Z

@dukenv0307 Some minor comments. The rest looks fine to me

dukenv0307 · 2026-02-18T15:33:57Z

@DylanDylann I updated

DylanDylann · 2026-02-19T08:23:13Z

Looks like you've decreased code coverage for some files

dukenv0307 · 2026-02-22T05:38:09Z

@DylanDylann Done

DylanDylann

LGTM

melvin-bot · 2026-02-23T06:42:44Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #66424 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

DylanDylann · 2026-02-23T06:43:04Z

cc @tgolen

tgolen · 2026-02-23T23:35:34Z

@dukenv0307 Can you please fix the conflicts, then I'll review.

dukenv0307 · 2026-02-24T03:07:49Z

@tgolen I resolved the conflicts

tgolen · 2026-02-24T18:36:24Z

    const [initialLastUpdateIDAppliedToClient] = useOnyx(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT);
    const [modal] = useOnyx(ONYXKEYS.MODAL);
    const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);
+    const [isSelfTourViewed = false] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector});


I think having a default here is a slight anti-pattern (as you can see, not very many of the hooks being used will have a default value configured). What we typically do is let Onyx return whatever it will (which can be undefined) and then update the function parameters using the data to allow | undefined and then handle the undefined value inside of the function (where you can default it to false).

The benefit of this pattern is that it makes the function call very safe, and doesn't run the risk of someone forgetting to default the value to false if they add a new instance useOnyx() instance.

Would you mind changing this, please?

Make sense to me, I updated. Thank you @tgolen

melvin-bot · 2026-02-25T14:45:26Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #66424 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

tgolen

Looks great. Thank you!

github-actions · 2026-02-25T17:50:54Z

🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T17:57:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80979.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-27555ea-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-27555ea-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://80979.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:23:15Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:54:48Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor createWorkspace to use isSelfTourViewed from useOnyx

15a1820

melvin-bot Bot assigned dukenv0307 Jan 30, 2026

update code

ea6e43e

dukenv0307 marked this pull request as ready for review January 30, 2026 02:28

dukenv0307 requested review from a team as code owners January 30, 2026 02:28

melvin-bot Bot requested review from DylanDylann and removed request for a team January 30, 2026 02:28

melvin-bot Bot requested review from JmillsExpensify and removed request for a team January 30, 2026 02:28

JmillsExpensify reviewed Feb 2, 2026

View reviewed changes

dukenv0307 added 2 commits February 9, 2026 10:10

add more tests

7028e22

add sentryLabel

d46dcf4

dukenv0307 added 2 commits February 12, 2026 17:21

merge main

67ed991

lint fix

67adc90

DylanDylann reviewed Feb 16, 2026

View reviewed changes

dukenv0307 added 2 commits February 18, 2026 22:26

Merge branch 'main' into fix/66424-part-3

f3a3b49

add cmt

bd2a503

dukenv0307 added 2 commits February 22, 2026 11:46

Merge branch 'main' into fix/66424-part-3

927482a

add tests

5c8e374

DylanDylann approved these changes Feb 23, 2026

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg February 23, 2026 06:42

jasperhuangg requested review from tgolen and removed request for jasperhuangg February 23, 2026 17:04

dukenv0307 added 2 commits February 24, 2026 09:53

merge main

c8cd50c

remove canBeMissing

2d380e1

tgolen requested changes Feb 24, 2026

View reviewed changes

dukenv0307 added 3 commits February 25, 2026 11:11

Merge branch 'main' into fix/66424-part-3

5d16248

update isSelfTourViewed type

2b8bffe

update isSelfTourViewed type

a7b4153

DylanDylann approved these changes Feb 25, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski February 25, 2026 14:46

tgolen approved these changes Feb 25, 2026

View reviewed changes

tgolen merged commit 27555ea into Expensify:main Feb 25, 2026
30 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

DylanDylann mentioned this pull request Mar 5, 2026

refactor payMoneyRequest and payInvoice to use isSelfTourViewed from useOnyx #83785

Merged

52 tasks

dukenv0307 mentioned this pull request Apr 28, 2026

[Partial payment $3625] Remove Onyx.connect() for the key: ONYXKEYS.NVP_ONBOARDING in src/libs/ReportUtils.ts #66424

Open

		type CreateWorkspaceDataOptions = Omit<BuildPolicyDataOptions, 'isSelfTourViewed'> & {
		isSelfTourViewed: boolean;

Conversation

dukenv0307 commented Jan 30, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

dukenv0307 commented Feb 2, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 4, 2026

Uh oh!

dukenv0307 commented Feb 9, 2026

Uh oh!

dukenv0307 commented Feb 12, 2026

Uh oh!

DylanDylann Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Feb 16, 2026

Uh oh!

dukenv0307 commented Feb 18, 2026

Uh oh!

DylanDylann commented Feb 19, 2026

Uh oh!

dukenv0307 commented Feb 22, 2026

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 23, 2026

Uh oh!

DylanDylann commented Feb 23, 2026

Uh oh!

tgolen commented Feb 23, 2026

Uh oh!

dukenv0307 commented Feb 24, 2026

Uh oh!

tgolen Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 25, 2026

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

codecov Bot commented Jan 30, 2026 •

edited by github-actions Bot

Loading