[Sprint] Release 3.2 - Editing existing Personal Card Feed #81047

Gonals · 2026-01-30T19:04:31Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/593052
PROPOSAL:

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/593048
PROPOSAL:

Tests

Log into newDot and go to Wallet
Import a CSV card. You can use this file:
fake_transactions-2026-01-16 10_56_55.629.csv
Click on the card. You should see an option to add transactions:

click it and follow the process. You'll need to use a different file to avoid duplicate handling. You can use this one:
fakeyfakes.csv
Confirm the transactions are added

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-30T19:05:10Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a979556274

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/ImportTransactions.ts

codecov · 2026-01-30T19:25:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/PopoverMenu.tsx	`77.31% <0.00%> (ø)`
...tings/Wallet/ImportTransactionsSpreadsheetPage.tsx	`0.00% <0.00%> (ø)`
...pages/settings/Wallet/TransactionsImportedPage.tsx	`0.00% <0.00%> (ø)`
src/pages/settings/Wallet/WalletPage/index.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/ImportTransactions.ts	`0.00% <0.00%> (ø)`
... and 43 files with indirect coverage changes

Krishna2323 · 2026-01-30T20:36:29Z

Reviewing...

Krishna2323

Minor improvements.

src/pages/settings/Wallet/WalletPage/index.tsx

Krishna2323 · 2026-01-30T20:55:14Z

src/pages/settings/Wallet/TransactionsImportedPage.tsx

            <HeaderWithBackButton
                title={translate('workspace.companyCards.importTransactions.title')}
-                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_IMPORT_TRANSACTIONS_SPREADSHEET.getRoute())}
+                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_IMPORT_TRANSACTIONS_SPREADSHEET.getRoute(existingCardID ? Number(existingCardID) : undefined))}


existingCardID ? Number(existingCardID) : undefined is used twice, we can create a constant.

I think this is fine as-is 👍

Gonals · 2026-01-30T21:02:18Z

Comments addressed @Krishna2323 !

Krishna2323 · 2026-01-30T21:03:13Z

Recording platform videos. Checklist will be completed in 15-20 mins.

Krishna2323 · 2026-01-30T21:10:07Z

The key prop console error is still there:

Monosnap.screencast.2026-01-31.02-37-01.mp4

src/pages/settings/Wallet/WalletPage/index.tsx

Gonals · 2026-01-30T21:25:59Z

The key prop console error is still there:

Monosnap.screencast.2026-01-31.02-37-01.mp4

Do you know where this is coming from? I don't see it in the web console

Krishna2323 · 2026-01-30T21:27:45Z

Do you know where this is coming from? I don't see it in the web console

Let me check, this was happening on iOS native

Krishna2323 · 2026-01-30T21:58:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM! 🚀

melvin-bot · 2026-01-30T22:15:58Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-30T22:16:01Z

🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #81065.

OSBotify · 2026-01-31T00:20:42Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.3.11-17 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Gonals added 2 commits January 29, 2026 14:19

Better handling

5d30ea5

cleanup

a979556

Gonals self-assigned this Jan 30, 2026

Gonals requested review from a team as code owners January 30, 2026 19:04

melvin-bot bot requested review from joekaufmanexpensify and srikarparsi and removed request for a team January 30, 2026 19:04

prettier

91942bf

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

src/libs/actions/ImportTransactions.ts Outdated Show resolved Hide resolved

Gonals added 2 commits January 30, 2026 11:14

lint

72c5021

dependencie

c1a9176

types

ed73ba2

Gonals changed the title ~~[WIP] DO NOT REVIEW YET~~ [Sprint] Release 3.2 - Editing existing Personal Card Feed Jan 30, 2026

behind beta

9f53595

Gonals requested a review from Krishna2323 January 30, 2026 20:48

Krishna2323 reviewed Jan 30, 2026

View reviewed changes

rename flag

6497d01

Gonals requested a review from Krishna2323 January 30, 2026 21:02

Krishna2323 reviewed Jan 30, 2026

View reviewed changes

src/pages/settings/Wallet/WalletPage/index.tsx Outdated Show resolved Hide resolved

closemodals

45a5a12

prettier

553e9a4

This comment was marked as resolved.

Sign in to view

Krishna2323 mentioned this pull request Jan 30, 2026

[Sprint] Release 3.1 - Creating a new Personal Card Feed #80648

Merged

63 tasks

readd key

a32d393

Krishna2323 approved these changes Jan 30, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Jan 30, 2026

Payment issue for E/App PR#81047 #81065

Open

MarioExpensify approved these changes Jan 30, 2026

View reviewed changes

MarioExpensify merged commit 2d3cc34 into main Jan 30, 2026
34 checks passed

MarioExpensify deleted the alberto-release32 branch January 30, 2026 22:23

github-actions bot mentioned this pull request Jan 30, 2026

Investigate workflow job failing on main: chooseDeployActions #81067

Closed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

[Sprint] Release 3.2 - Editing existing Personal Card Feed #81047

[Sprint] Release 3.2 - Editing existing Personal Card Feed #81047

Uh oh!

Conversation

Gonals commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Jan 30, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Krishna2323 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Gonals Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Gonals commented Jan 30, 2026

Uh oh!

Krishna2323 commented Jan 30, 2026

Uh oh!

Krishna2323 commented Jan 30, 2026

Uh oh!

Uh oh!

Gonals commented Jan 30, 2026

Uh oh!

Krishna2323 commented Jan 30, 2026

Uh oh!

This comment was marked as resolved.

Krishna2323 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gonals commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading

Krishna2323 commented Jan 30, 2026 •

edited

Loading