fix: Screen Reader: Many Pages: Elements are focused in a confusing order#81063
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 303cd8b587
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine from a product perspective
…Reader-Many-Pages-Elements-are-focused-in-a-confusing-order
|
Can we get a video of this to hear how this works in practise? |
Sure @dubielzyk-expensify. Here iOS-Native.mp4 |
|
That looks good to me 👍 |
Reviewer Checklist
Screenshots/VideosiOS: HybridAppScreen.Recording.2026-02-05.at.09.32.15.mov |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.13-1 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.15-0 🚀
|




Explanation of Change
iOS VoiceOver determines reading order by element frame Y position (top-to-bottom), not DOM order. In the chat composer, buttons use alignSelf: 'flex-end' which positions them higher (lower Y value) than the text input.
This caused VoiceOver to read the Send button before the text input field, violating WCAG 2.4.3 Focus Order.
This fix applies a negative margin (marginTop: -5) to move the text input's accessible frame up, aligning it with the buttons so VoiceOver reads it first. The padding (paddingTop: 5) compensates visually so there's no visible layout change.
Fixed Issues
$ #77499
PROPOSAL: #77499 (comment)
Tests
Precondition: User is logged in
The text input field should receive focus before the Send button.
Screen reader users should encounter elements in the same order as sighted users.
Other Occurrences:
New Chat
Group Chat
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari