Fix optimistic transaction sign when merging by youssef-lr · Pull Request #81132 · Expensify/App

youssef-lr · 2026-02-02T03:17:53Z

Explanation of Change

This PR improves how we store the amount in the final transaction after merging, by keeping it the same as from the source transaction it came from without handling negating the sign. Instead we only handle that in display components.

Fixed Issues

$ #78176

Tests

Verify that no errors appear in the JS console

Create a couple transactions
Go offline and merge them
Verify the amount sign is preserved.
Test with negative transactions as well.

Offline tests

Included above.

QA Steps

Verify that no errors appear in the JS console

Create a couple transactions
Go offline and merge them
Verify the amount sign is preserved.
Test with negative transactions as well.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-02T03:51:44Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/MergeTransactionUtils.ts	`73.13% <100.00%> (+0.77%)`	⬆️
src/libs/actions/MergeTransaction.ts	`48.09% <100.00%> (-0.40%)`	⬇️
src/pages/TransactionMerge/DetailsReviewPage.tsx	`0.00% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`75.82% <87.50%> (+0.01%)`	⬆️
src/libs/actions/IOU/index.ts	`71.99% <0.00%> (-0.03%)`	⬇️
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.24% <0.00%> (+<0.01%)`	⬆️
... and 12 files with indirect coverage changes

youssef-lr · 2026-02-03T02:24:16Z

@hoangzinh assigning you since you have context

melvin-bot · 2026-02-03T02:24:25Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/MergeTransactionUtils.ts

src/libs/actions/MergeTransaction.ts

hoangzinh · 2026-02-04T10:26:39Z

@hoangzinh assigning you since you have context

Sure. I will review today

hoangzinh · 2026-02-05T00:14:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

hoangzinh

All goods. Going to test

src/components/ReportActionItem/MoneyRequestView.tsx

hoangzinh · 2026-02-05T09:40:31Z

Bug: [Offline] When merge 2 unreported expenses in offline mode, it displays negative amount after merge

Screen.Recording.2026-02-05.at.16.38.55.mov

hoangzinh · 2026-02-05T09:44:32Z

Bug: [Offline] When merging a normal expense with a negative amount expense, and keeping the negative amount, App displays a positive amount after merge

Screen.Recording.2026-02-05.at.16.41.08.mov

…action

youssef-lr · 2026-02-06T11:10:44Z

Should be fixed now!

hoangzinh · 2026-02-09T10:08:23Z

@youssef-lr did we fix this bug? I tried to reproduce on latest commit, but I still could

Screen.Recording.2026-02-09.at.17.06.54.mov

youssef-lr · 2026-02-09T16:43:56Z

I'm unable to reproduce weirdly

Screen.Recording.2026-02-09.at.17.43.32.mov

hoangzinh · 2026-02-09T22:21:05Z

Here are steps @youssef-lr. I'm unsure if it's related to the PR here:

Submit 3 expenses, 1st positive amount, 2nd & 3rd are negative amount
Merge 1st & 2nd (keep 2nd's amount)
Update to a positive amount after the merge
Go offline
Select 3rd and merge with previous merged expense in step 2 (keep negative amount)

Screen.Recording.2026-02-10.at.05.17.14.mov

hoangzinh · 2026-02-12T14:47:14Z

Hi @youssef-lr Could you reproduce this bug?

youssef-lr · 2026-02-12T19:08:23Z

I'm on it now

JmillsExpensify

Product review not required on this one.

youssef-lr · 2026-02-17T22:19:41Z

Sorry, I got caught up with higher priority stuff. I'm resuming work on this PR now.

hoangzinh · 2026-03-06T01:00:51Z

@youssef-lr, friendly remind that we still have this PR ;)

youssef-lr · 2026-03-16T21:57:29Z

Low priority, will resume tomorrow

hoangzinh · 2026-04-02T09:34:30Z

Hi @youssef-lr, just a friendly reminder that we still have this PR.

youssef-lr · 2026-04-08T11:17:07Z

Yes will resume this very soon, I need to finish some high priority stuff

youssef-lr added 2 commits February 2, 2026 04:05

Use original amount sign when storing merged amount

2449feb

No need to invert sign when merging

51115a6

melvin-bot bot assigned youssef-lr Feb 2, 2026

youssef-lr added 3 commits February 2, 2026 04:33

Show correct sign in merge details review page

2f68300

Fix test

2aa802b

Cleanup

1c2adbf

Use amount coming from getTransactionDetails to handle correct sign

24d875f

youssef-lr changed the title ~~Youssef fix optimistic amount sign~~ Fix optimistic transaction sign when merging Feb 2, 2026

Cleanup

59a17ab

youssef-lr requested a review from hoangzinh February 3, 2026 02:24

youssef-lr marked this pull request as ready for review February 3, 2026 02:24

youssef-lr requested review from a team as code owners February 3, 2026 02:24

melvin-bot bot requested a review from abdulrahuman5196 February 3, 2026 02:24

melvin-bot bot requested review from JmillsExpensify and removed request for a team February 3, 2026 02:24

youssef-lr removed the request for review from abdulrahuman5196 February 3, 2026 02:26

github-actions bot reviewed Feb 3, 2026

View reviewed changes

src/libs/MergeTransactionUtils.ts Outdated Show resolved Hide resolved

github-actions bot reviewed Feb 3, 2026

View reviewed changes

src/libs/actions/MergeTransaction.ts Outdated Show resolved Hide resolved

youssef-lr added 2 commits February 3, 2026 04:24

Perf fix: move getTransactionDetails out of loop

25b6fe4

Another similar perf fix

9bca750

hoangzinh reviewed Feb 5, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestView.tsx Outdated Show resolved Hide resolved

youssef-lr added 2 commits February 6, 2026 10:44

Merge branch 'main' into youssef_fix_optimistic_amount_sign

4ebe8cb

Preserve amount sign when generating optimistic data for merged trans…

2c28d84

…action

Remove unneeded comment

32fc456

JmillsExpensify reviewed Feb 13, 2026

View reviewed changes

Conversation

youssef-lr commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

youssef-lr commented Feb 3, 2026

Uh oh!

melvin-bot bot commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Feb 4, 2026

Uh oh!

hoangzinh commented Feb 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoangzinh commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Feb 5, 2026

Uh oh!

youssef-lr commented Feb 6, 2026

Uh oh!

hoangzinh commented Feb 9, 2026

Uh oh!

youssef-lr commented Feb 9, 2026

Uh oh!

hoangzinh commented Feb 9, 2026

Uh oh!

hoangzinh commented Feb 12, 2026

Uh oh!

youssef-lr commented Feb 12, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Feb 17, 2026

Uh oh!

hoangzinh commented Mar 6, 2026

Uh oh!

youssef-lr commented Mar 16, 2026

Uh oh!

hoangzinh commented Apr 2, 2026

Uh oh!

youssef-lr commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

youssef-lr commented Feb 2, 2026 •

edited

Loading

codecov bot commented Feb 2, 2026 •

edited by github-actions bot

Loading

hoangzinh commented Feb 5, 2026 •

edited

Loading