[No QA] Fix SVG icons intercepting clicks on buttons #81583
Draft
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent SVG click interception Browser automation tools (and potentially users) have trouble clicking on certain UI elements because SVG icons inside buttons/pressables intercept clicks. The SVG path elements become the click target instead of the parent pressable. This fix adds pointerEvents="none" to: - Icon component's View wrapper and ImageSVG (both main and inline rendering) - FloatingActionButton's Svg component Co-authored-by: Cursor <cursoragent@cursor.com>
melvin-bot
bot
requested review from
joekaufmanexpensify and
youssef-lr
and removed request for
a team
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
youssef-lr
approved these changes
Feb 5, 2026
Contributor
|
Tests failing @neil-marcellini |
Contributor
|
No product review needed |
Contributor
Author
|
Moving this to a draft, it's quite untested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Browser automation tools (and potentially users) have trouble clicking on certain UI elements because SVG icons inside buttons/pressables intercept clicks. The SVG
<path>elements become the click target instead of the parent pressable.Affected Components
src/components/Icon/index.tsx) - renders SVGs withoutpointerEvents="none"src/components/FloatingActionButton.tsx) - uses raw<Svg>and<AnimatedPath>without pointer-events handlingSolution
Added
pointerEvents="none"to:This ensures clicks pass through the SVG elements to the parent pressable components.
Test Plan
Made with Cursor