chore: deprecate timing.ts by adhorodyski · Pull Request #81691 · Expensify/App

adhorodyski · 2026-02-06T14:56:19Z

Explanation of Change

This PR deprecates the Timing.ts module as well as any performance tracking done with Firebase. It includes a patch removal.

Let's make sure this PR is well tested on an adhoc.

cleanup StartupTimer on iOS
cleanup StartupTimer on Android
cleanup StartupTimer on iOS (Hybrid)
cleanup StartupTimer on Android (Hybrid)
Needs https://github.com/Expensify/Mobile-Expensify/pull/13841 to work with Hybrid.

Previous attempt (#80659) was still referencing the StartupTimer in logs, so was a premature merge.

Fixed Issues

$ #80357
PROPOSAL: N/A

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13841

Tests

Open up the app.
Navigate to any report.
Send a message.
Navigate to the Reports page.
Navigate into any report from there.
The App should not crash during this whole time.
Open up Network tools, observe no calls to the /SendPerformanceTimings command have been made.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

This reverts commit 01056d4.

files and manifest

melvin-bot · 2026-02-06T14:56:27Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-06T14:56:31Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e29857395

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-06T14:58:48Z

src/libs/OptionsListUtils/index.ts

    );

-    Timing.end(CONST.TIMING.LOAD_SEARCH_OPTIONS);
    Performance.markEnd(CONST.TIMING.LOAD_SEARCH_OPTIONS);


Add matching markStart for LOAD_SEARCH_OPTIONS

Now that the only Performance.markStart(CONST.TIMING.LOAD_SEARCH_OPTIONS) was removed, Performance.markEnd here will always run without a matching start mark. The custom marks observer calls measureFailSafe on every “_end” mark, which will throw and be caught/logged when the start mark is missing, so each search-options build will both lose its timing metric and emit a debug error. This happens whenever getSearchOptions runs (e.g., opening the search UI). Consider reinstating a corresponding markStart or removing the end mark to avoid noisy logs and missing metrics.

Useful? React with 👍 / 👎.

src/libs/OptionsListUtils/index.ts

it back)

codecov · 2026-02-06T15:18:48Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/Expensify.tsx	`84.57% <ø> (-0.09%)`	⬇️
src/components/LHNOptionsList/OptionRowLHN.tsx	`95.71% <ø> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.05% <ø> (+0.20%)`	⬆️
...portActionItem/MoneyRequestReportPreview/index.tsx	`89.28% <ø> (ø)`
src/components/Search/SearchAutocompleteList.tsx	`32.40% <ø> (-0.11%)`	⬇️
...rc/components/Search/SearchRouter/SearchButton.tsx	`100.00% <ø> (ø)`
src/components/Search/index.tsx	`26.90% <ø> (+0.04%)`	⬆️
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/BootSplash/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/BootSplash/index.ts	`0.00% <ø> (ø)`
... and 14 more
... and 13 files with indirect coverage changes

github-actions · 2026-02-06T16:30:18Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

huult · 2026-02-06T16:32:47Z

Reviewing soon.

github-actions · 2026-02-06T17:03:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81691 Mobile-Expensify PR Expensify/Mobile-Expensify#13841.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-20c6eb2c718a7bed2cf5605c1b8b99725d7c2e34/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-84cd12d4ca3f136b1eac132f69e9ea41d8802bf3/index.html

Web 🕸️
https://81691.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

huult · 2026-02-09T06:03:36Z

@codex review

huult · 2026-02-09T06:10:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-09.at.21.45.52.mp4

Android: mWeb Chrome

Screen.Recording.2026-02-09.at.21.48.14.mp4

iOS: HybridApp

ScreenRecording_02-09-2026.22-04-12_1.MP4

iOS: mWeb Safari

Screen.Recording.2026-02-09.at.21.55.35.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-02-09.at.19.04.10.mp4

chatgpt-codex-connector · 2026-02-09T06:12:32Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

huult · 2026-02-09T08:35:46Z

@adhorodyski Have you tried building and running this on a physical iOS device?

adhorodyski · 2026-02-09T08:51:31Z

@huult building and running no, are you running into issues yourself? is everything ok with the adhoc?

huult · 2026-02-09T08:57:54Z

@huult building and running no, are you running into issues yourself? is everything ok with the adhoc?

I can’t install the adhoc build because my device UUID isn’t included in the adhoc list.
I tried building on a physical device, but I needed to rebuild main.jsbundle following this guide:

https://expensify.slack.com/archives/C01GTK53T8Q/p1754162292418269?thread_ts=1745474113.731259&cid=C01GTK53T8Q

However, I ran into the issues below.

How did you verify this? Are you still using an emulator or simulator?

huult · 2026-02-09T10:03:37Z

I can build on a physical device and start testing by following the steps above

huult · 2026-02-09T11:50:25Z

ios/NewExpensify.xcodeproj/project.pbxproj

 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
+			shellScript = "";


@adhorodyski You added shellScript = ""; intentionally, right? Just confirming.

Just the default after synchronizing in XCode (this is correct)

huult · 2026-02-09T11:52:25Z

ios/AppDelegate.swift

 import Firebase
 import Expo
- 
+


Please remove the added space in this file.

I believe the empty line formatting was off in the first place, I have only save the above diff (see hidden whitespaces).

huult

I built and tested the app on a physical iOS device and the emulator. The app did not crash.

@rlinoz If possible, could you ask someone on the AdHoc list to try testing it?

LGTM!

adhorodyski added 2 commits February 6, 2026 15:19

Reapply "chore: deprecate timing.ts"

cf58a4a

This reverts commit 01056d4.

Remove Firebase Performance plugin and dependencies from Android build

9e29857

files and manifest

adhorodyski requested review from a team as code owners February 6, 2026 14:56

melvin-bot bot assigned adhorodyski Feb 6, 2026

melvin-bot bot requested review from JmillsExpensify and huult and removed request for a team February 6, 2026 14:56

melvin-bot bot removed the request for review from a team February 6, 2026 14:56

chatgpt-codex-connector bot reviewed Feb 6, 2026

View reviewed changes

adhorodyski commented Feb 6, 2026

View reviewed changes

src/libs/OptionsListUtils/index.ts Show resolved Hide resolved

Mark the start of search options loading for performance tracking (bring

4d8984b

it back)

rlinoz self-requested a review February 6, 2026 16:30

Merge branch 'Expensify:main' into timing-module-deprecate

24cfe97

adhorodyski mentioned this pull request Feb 9, 2026

Improve ShouldReportBeInOptionList function #81551

Draft

53 tasks

huult reviewed Feb 9, 2026

View reviewed changes

huult approved these changes Feb 9, 2026

View reviewed changes

Conversation

adhorodyski commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

huult commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

huult commented Feb 9, 2026

Uh oh!

huult commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Feb 9, 2026

Uh oh!

huult commented Feb 9, 2026

Uh oh!

adhorodyski commented Feb 9, 2026

Uh oh!

huult commented Feb 9, 2026

Uh oh!

huult commented Feb 9, 2026

Uh oh!

huult Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adhorodyski commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited by github-actions bot

Loading

huult commented Feb 9, 2026 •

edited

Loading

adhorodyski Feb 9, 2026 •

edited

Loading

huult Feb 9, 2026 •

edited

Loading