[Snyk] Security upgrade webpack from 5.94.0 to 5.104.1#81696
[Snyk] Security upgrade webpack from 5.94.0 to 5.104.1#81696
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235959 - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235969
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
The webpack override in package.json was still at ^5.94.0 while the direct dependency was bumped to ^5.104.1, causing an npm EOVERRIDE conflict. This made npm ci fail on all CI checks.
|
🤖 Fixed the failing checks Root Cause: All CI checks were failing at the
Two issues were found:
Fix applied:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 805c7f6b77
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "typescript-eslint": "^8.45.0", | ||
| "wait-port": "^0.2.9", | ||
| "webpack": "^5.94.0", | ||
| "webpack": "^5.104.1", |
There was a problem hiding this comment.
Update package-lock.json for webpack bump
Because the root CI setup runs npm ci (see .github/actions/composite/setupNode/action.yml), changing the webpack version in package.json without updating package-lock.json will cause npm ci to fail with an out-of-date lockfile error on any workflow that installs dependencies. This makes the dependency bump effectively unbuildable until the lockfile is regenerated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This comment appears to be inaccurate. The package-lock.json is already updated in this PR alongside package.json. Both files are part of the diff — the lockfile shows webpack resolved to 5.105.0 (which satisfies the ^5.104.1 range in package.json), along with all transitive dependency updates. No additional action is needed for this comment.
|
🤖 Check Failure Analysis The only failing check is
This is not a code issue — it's a CI workflow that requires a human reviewer to post a reviewer checklist comment on the PR. All code-related checks are passing:
No code fix can resolve this. A reviewer needs to post their reviewer checklist comment on this PR to satisfy the check. |
|
The only failing check is
This is not a code issue — it's a workflow check that requires a human reviewer to post the PR Reviewer Checklist comment. All code-related checks (ESLint, typecheck, tests, builds, prettier, spellcheck, etc.) are passing. No code fix can resolve this. A reviewer needs to post the reviewer checklist comment to satisfy this check. |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari