Fix: Approvers Lose Ability to Reject Expenses When Acting as Vacation Delegates or After Being Removed From Approval Workflow by annaweber830 · Pull Request #81801 · Expensify/App

annaweber830 · 2026-02-08T16:30:14Z

Explanation of Change

Fix: Approvers Lose Ability to Reject Expenses When Acting as Vacation Delegates or After Being Removed From Approval Workflow

Fixed Issues

$ #79599
PROPOSAL: #79599 (comment)

Tests

Scenario 1: Approver Removed From Workflow
Preconditions:
Approvals enabled
Submissiomn set to Manual
Initial approval workflow: Submitter A → Approver A

Submitter A creates a report with multiple expenses
Submitter A submits the report to Approver A
Admin updates the approval workflow and changes the approver to Approver B
Approver A accesses the report
Check that an approver can reject individual expenses.

Scenario 2: Vacation Delegate Flow

Submitter A creates a report with multiple expenses
Submitter A submits the report to Approver A
Approver B is set as Approver A’s vacation delegate
Vacation delegation routes the report to Approver B
Approver B opens the report
Check that an approver can reject individual expenses.

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Scenario 1: Approver Removed From Workflow
Preconditions:
Approvals enabled
Submissiomn set to Manual
Initial approval workflow: Submitter A → Approver A

Submitter A creates a report with multiple expenses
Submitter A submits the report to Approver A
Admin updates the approval workflow and changes the approver to Approver B
Approver A accesses the report
Check that an approver can reject individual expenses.

Scenario 2: Vacation Delegate Flow

Submitter A creates a report with multiple expenses
Submitter A submits the report to Approver A
Approver B is set as Approver A’s vacation delegate
Vacation delegation routes the report to Approver B
Approver B opens the report
Check that an approver can reject individual expenses.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-08.at.7.58.48.AM.mp4

Screen.Recording.2026-02-08.at.8.08.33.AM.mp4

melvin-bot · 2026-02-08T16:30:21Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-08T16:34:40Z

-        // eslint-disable-next-line @typescript-eslint/no-deprecated
-        return getPlaidBalanceFailureMessage(translateLocal, parentReportAction);
-    }
+    // eslint-disable-next-line @typescript-eslint/no-deprecated


❌ CONSISTENCY-5 (docs)

ESLint rule disable lacks a justification comment explaining why translateLocal is still being used here.

Suggested fix:
Add a comment above the eslint-disable explaining why the deprecated translateLocal function is still necessary in this context. For example:

// translateLocal is still used here because this function hasn't been migrated yet // eslint-disable-next-line @typescript-eslint/no-deprecated const parentReportActionBasedName = computeReportNameBasedOnReportAction(translateLocal, parentReportAction, report, reportPolicy, parentReport);

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

codecov · 2026-02-08T16:35:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useSelectedTransactionsActions.ts	`85.22% <100.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`92.79% <100.00%> (+0.22%)`	⬆️
src/libs/ReportUtils.ts	`74.89% <ø> (+0.13%)`	⬆️
src/components/Search/index.tsx	`27.06% <0.00%> (ø)`
... and 90 files with indirect coverage changes

mkhutornyi · 2026-02-09T08:31:17Z

@annaweber830 last commit is bad one. Maybe wrongly fixed merge conflict?

…9599

mkhutornyi · 2026-02-11T11:57:57Z

@annaweber830 can you push changes? No files changed at the moment.

mkhutornyi · 2026-02-11T12:20:06Z

Lint error!

mkhutornyi · 2026-02-11T14:06:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

case 1:

web1.mov

case 2:

web2.mov

mkhutornyi · 2026-02-11T14:07:07Z

@annaweber830 please merge main

…9599

jasperhuangg

@heyjennahay off to you for the product review, thanks 🙇

jasperhuangg · 2026-02-18T20:35:39Z

@heyjennahay friendly bump on this product review!

cc @Expensify/product-pr if anyone has any spare cycles and can move this along

heyjennahay

Thanks for the bump @jasperhuangg

Produce change LGTM

OSBotify · 2026-02-19T00:23:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-19T00:48:52Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-19T01:14:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81801.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-be801ec-73d80f5-bbd60afc133cc4d899d6fd0e3734809d4f307068/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://81801.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-19T18:01:07Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.3.23-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-20T16:11:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

annaweber830 added 2 commits February 5, 2026 22:53

fix: init

02a9c5e

fix: init fix

3717eb6

annaweber830 requested review from a team as code owners February 8, 2026 16:30

melvin-bot Bot assigned annaweber830 Feb 8, 2026

melvin-bot Bot requested review from heyjennahay and mkhutornyi and removed request for a team February 8, 2026 16:30

github-actions Bot reviewed Feb 8, 2026

View reviewed changes

Merge branch 'main' of https://github.com/annaweber830/App into fix-7…

cda4ca5

…9599

annaweber830 added 2 commits February 11, 2026 04:05

fix: refix

c2a8a14

fix: prettier

54a8794

annaweber830 added 2 commits February 11, 2026 04:31

fix: lint error

d774fdb

fix: lint

7225ad9

Merge branch 'main' of https://github.com/annaweber830/App into fix-7…

f0d2f3f

…9599

mkhutornyi approved these changes Feb 11, 2026

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg February 11, 2026 16:28

jasperhuangg approved these changes Feb 13, 2026

View reviewed changes

heyjennahay approved these changes Feb 18, 2026

View reviewed changes

jasperhuangg merged commit be801ec into Expensify:main Feb 19, 2026
31 checks passed

OSBotify mentioned this pull request Feb 19, 2026

Deploy Checklist: New Expensify 2026-02-19 #82970

Closed

41 tasks

melvin-bot Bot mentioned this pull request Feb 20, 2026

[Due for payment 2026-02-27] [$250] Approvers Lose Ability to Reject Expenses When Acting as Vacation Delegates or After Being Removed From Approval Workflow #79599

Closed

7 tasks

Conversation

annaweber830 commented Feb 8, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 8, 2026

Uh oh!

github-actions Bot Feb 8, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

annaweber830 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mkhutornyi commented Feb 9, 2026

Uh oh!

mkhutornyi commented Feb 11, 2026

Uh oh!

mkhutornyi commented Feb 11, 2026

Uh oh!

mkhutornyi commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Feb 11, 2026

Uh oh!

jasperhuangg left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Feb 18, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Feb 8, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Feb 11, 2026 •

edited

Loading