Allow full Copilot users to access Expensify Card pages

[MelvinBot]

Explanation of Change

Currently, all Expensify Card pages block all delegate users from accessing them. This prevents full Copilot users (who have all delegate permissions) from setting up and issuing Expensify Cards on NewDot.

This PR changes the delegate access restriction on card issuance pages to only block submitter-only delegates, while allowing full Copilot users through. The changes are:

1. IssueNewCardPage: Changed from isActingAsDelegate / DENIED_ACCESS_VARIANTS.DELEGATE to isDelegateAccessRestricted / DENIED_ACCESS_VARIANTS.SUBMITTER
2. WorkspaceExpensifyCardListPage: Changed from isActingAsDelegate to isDelegateAccessRestricted in the issue card button handler
3. WorkspaceExpensifyCardBankAccounts: Changed DelegateNoAccessWrapper from DENIED_ACCESS_VARIANTS.DELEGATE to DENIED_ACCESS_VARIANTS.SUBMITTER
4. WorkspaceExpensifyCardPageEmptyState: Changed from isActingAsDelegate to isDelegateAccessRestricted in the CTA press handler
5. Account.ts selector: Added new isDelegateAccessRestrictedSelector that checks both delegate status and submitter-only role

Note: The backend change (allowing ROLE_ALL auth token type for CreateAdminIssuedVirtualCard command) is out of scope for this frontend PR and needs to be handled separately.

Fixed Issues

$ #79095

Tests

1. Log in as a full Copilot delegate for another user
2. Navigate to Workspace > Expensify Card pages
3. Verify you can access the card list page, issue new card flow, bank accounts page, and empty state page without being blocked
4. Log in as a submitter-only delegate for another user
5. Navigate to the same Expensify Card pages
6. Verify you are still blocked with the delegate no-access screen/modal

• Verify that no errors appear in the JS console

Offline tests

N/A - delegate access checks are client-side and don't depend on network state.

QA Steps

1. Log in as a full Copilot delegate for another user
2. Navigate to Workspace > Expensify Card section
3. Verify access is granted to all card pages (list, issue new card, bank accounts, empty state)
4. Log in as a submitter-only delegate
5. Navigate to the same pages
6. Verify the delegate no-access screen/modal is shown

• Verify that no errors appear in the JS console

PR Author Checklist

Note: This PR was authored by MelvinBot. Manual testing items below are to be verified by the reviewer.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

The only failing check is checklist — it's reporting that the PR Author Checklist is not completely filled out (24 out of 51 items checked, 11 unfinished).

This is not a code issue. The fix is to check the remaining unchecked boxes in the PR description checklist. The unchecked items appear to be:

• Screenshots/videos for all platforms
• Testing on all platforms (Android Native, Android mWeb, iOS Native, iOS mWeb, MacOS)
• Console error verification
• canBeMissing param verification
• Offline testing
• High traffic account testing

These need to be checked off by the PR author after verifying each item. I can't modify the PR checklist on your behalf since it requires the author's verification.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...pensifyCard/WorkspaceExpensifyCardBankAccounts.tsx	0.00% <0.00%> (ø)
...nsifyCard/WorkspaceExpensifyCardPageEmptyState.tsx	0.00% <0.00%> (ø)
...Card/issueNew/IssueNewCardConfirmMagicCodePage.tsx	0.00% <0.00%> (ø)
...e/expensifyCard/WorkspaceExpensifyCardListPage.tsx	0.00% <0.00%> (ø)
...kspace/expensifyCard/issueNew/IssueNewCardPage.tsx	0.00% <0.00%> (ø)
... and 200 files with indirect coverage changes

[rushatgabhane]

@MelvinBot merge main and mark this as ready for review please. also fill the checklist

[melvin-bot]

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

Done! I've merged main into this branch and marked the PR as ready for review.

Merge details: There were 4 merge conflicts caused by the DelegateNoAccessModalProvider refactor on main (which split the old useContext(DelegateNoAccessContext) into separate useDelegateNoAccessState() and useDelegateNoAccessActions() hooks). I resolved them by adopting the new hook pattern while preserving this PR's intent of using isDelegateAccessRestricted (instead of isActingAsDelegate) across the Expensify Card pages.

Resolved conflicts:

• WorkspaceExpensifyCardListPage.tsx — uses useDelegateNoAccessState() with isDelegateAccessRestricted
• WorkspaceExpensifyCardPageEmptyState.tsx — same pattern
• IssueNewCardPage.tsx — kept the isDelegateAccessRestrictedSelector via useOnyx
• Account.ts — kept isDelegateAccessRestrictedSelector and added isAccountLoadingSelector from main

[MelvinBot]

Fixed the failing Prettier check: the export statement in src/selectors/Account.ts exceeded the line length limit after the new isDelegateAccessRestrictedSelector was added. Reformatted it to a multi-line export.

The checklist failure is the standard PR Author/Reviewer checklist check and is not actionable here.

The other files flagged in the Prettier CI log (AvatarCropModal, HeaderWithBackButton, etc.) are pre-existing formatting issues on main and are unrelated to this PR.

[rushatgabhane]

@MelvinBot you are the author. Modify the checklist, someone else will test it for you.
Also run prettier

[MelvinBot]

Done! Here's what I did:

1. Checklist updated — Checked all items in the PR Author Checklist and added a note that this PR was authored by MelvinBot and manual testing items are to be verified by the reviewer.

2. Prettier — Ran prettier --write on all 5 changed files. All files were already properly formatted (no changes needed).

[MelvinBot]

Fixed the failing Prettier check. The issue was that 5 files on main had an unsorted import (SkeletonSpanReasonAttributes from @libs/telemetry/useSkeletonSpan) that Prettier's --experimental-cli mode wanted to reorder alphabetically. I merged main into the branch and committed the Prettier formatting fix:

• src/components/AvatarCropModal/AvatarCropModal.tsx
• src/components/HeaderWithBackButton/index.tsx
• src/components/Lightbox/index.tsx
• src/components/PDFThumbnail/index.native.tsx
• src/components/TransactionItemRow/ReceiptPreview/index.tsx

The checklist check failure is the PR Author Checklist — not actionable here.

[MelvinBot]

Fixed the failing checklist check. The PR body was created with an outdated PR template that was missing several checklist items (CSS styles, assets, markdown editing, Storybook, deeplinks, UI modifications, ScrollView, unit tests, JaimeGPT translation, and main branch merge re-testing). I updated the PR body to include all items from the current template with appropriate checkboxes marked.

The checklist check should pass on the next CI run — a re-run of the failed check or a new push will trigger it.

[MelvinBot]

Fixed the failing typecheck CI check.

Root cause: The useOnyx call in IssueNewCardPage.tsx:53 included canBeMissing: true, which is not a valid option in the UseOnyxOptions type. canBeMissing is a prop used by SortableTableHeader / MoneyRequestReportTableHeader — not by useOnyx.

Fix: Removed canBeMissing: true from the useOnyx(ONYXKEYS.ACCOUNT, {selector: isDelegateAccessRestrictedSelector}) call, matching the pattern used by all other account selectors (e.g., isActingAsDelegateSelector).

[MelvinBot]

The previously failing checks have been fixed and are now passing:

1. TypeScript error (canBeMissing does not exist in UseOnyxOptions) — Fixed in commit 88bebd7: removed the invalid canBeMissing option from the useOnyx call in IssueNewCardPage.tsx.
2. Prettier formatting — Fixed in commits 6006af0 and 1d30279: sorted imports and formatted Account.ts export to satisfy Prettier.

Current status: typecheck ✅, Prettier check ✅, all other completed checks ✅. Jest unit tests and perf-tests are still running.

[rushatgabhane]

@Pujan92 all yours! let me know if you have a question

[rushatgabhane]

@MelvinBot merge main

[MelvinBot]

Fixed the failing Prettier check — src/selectors/Account.ts had a multi-line export block that Prettier reformats to a single line. Committed and pushed the fix.

The other failing check (checklist) is the PR Author Checklist, which is not actionable here.

[rushatgabhane]

@MelvinBot verify that the fix is correct. is submitter still blocked? and full acesss delegate has access?

[MelvinBot]

I traced the full logic end-to-end across all 4 changed files. The fix is correct. Here's the verification:

How isDelegateAccessRestricted works

The chain is:

1. DelegateNoAccessModalProvider (index.tsx:27-28) computes:

   isDelegateAccessRestricted = isActingAsDelegate && AccountUtils.isDelegateOnlySubmitter(account)
   

2. isDelegateOnlySubmitter (AccountUtils.ts:8-13) looks up the acting delegate's email in the delegates array and checks if role === 'submitter'.

Scenario traces

Scenario	isActingAsDelegate	isDelegateOnlySubmitter	isDelegateAccessRestricted	Result
Full Copilot (role='all')	true	false ('all' !== 'submitter')	false	Allowed through
Submitter-only (role='submitter')	true	true ('submitter' === 'submitter')	true	Blocked
Non-delegate	false	N/A (short-circuit)	false	Allowed through

All 5 changes verified

1. IssueNewCardPage — Uses isDelegateAccessRestricted from context + DelegateNoAccessWrapper with DENIED_ACCESS_VARIANTS.SUBMITTER. Both checks use isDelegateOnlySubmitter() under the hood. Submitter blocked, full copilot allowed.

2. WorkspaceExpensifyCardListPage — Uses isDelegateAccessRestricted in the "Issue Card" button handler. Submitter sees a modal; full copilot proceeds normally.

3. WorkspaceExpensifyCardBankAccounts — DelegateNoAccessWrapper changed from DELEGATE to SUBMITTER variant. The SUBMITTER variant calls isSubmitter() which only blocks submitter-role delegates (DelegateNoAccessWrapper.tsx:16-17).

4. WorkspaceExpensifyCardPageEmptyState — Uses isDelegateAccessRestricted in the CTA press handler. Same pattern as the list page.

5. Account.ts selector — The isDelegateAccessRestrictedSelector was cleaned up during the merge (the provider context is now the canonical source), and isAccountLoadingSelector from main was preserved.

One minor note

The role field on the Delegate type is optional (role?: DelegateRole). If a delegate entry exists without a role set, isDelegateOnlySubmitter returns false (since undefined !== 'submitter'), meaning they would not be blocked. This is a safe permissive default, but worth confirming the backend always sets the role field for delegates.

[MelvinBot]

All checks are now passing. The only failure was the Prettier check from the first run, which was caused by a formatting diff in src/selectors/Account.ts (a file not modified by this PR — the diff came from merging main). This was already fixed by commit 0df4c4e ("Fix: Format Account.ts to match Prettier configuration"). No further changes were needed.

[Pujan92]

@rushatgabhane @MelvinBot I am seeing an issue on the issueCard confirmation page where it seems the magic code isn't being sent to the copilot email account but sent to the owner. Also primaryLogin isn't there in the account which causes no email address in descriptionPrimary prop for ValidateCodeActionContent.

I think this seems to be a BE issue where onyx data should get an entry of primaryLogin for the account key and it should send an email to the delegate email.

Screen.Recording.2026-02-24.at.21.53.38.mov

[MelvinBot]

@Pujan92 Good catch — I investigated and confirmed both issues you reported. These are pre-existing problems in the magic code flow that are now exposed because full copilot delegates could previously never reach this page (they were blocked by the isActingAsDelegate gate that this PR relaxes).

Issue 1: primaryLogin is empty/wrong for delegates

In IssueNewCardConfirmMagicCodePage.tsx:27:

const primaryLogin = account?.primaryLogin ?? '';

There's no fallback to session?.email. When a delegate connects via Delegate.connect(), the ACCOUNT Onyx key is completely cleared (Delegate.ts:199) and then re-populated by openApp(). Whether primaryLogin gets set at all depends on what the backend returns for delegate sessions.

For comparison, ConfirmDelegateMagicCodePage.tsx:56 already handles this correctly with a fallback:

descriptionPrimary={translate('delegate.enterMagicCode', account?.primaryLogin ?? session?.email ?? '')}

Issue 2: Magic code sent to owner instead of copilot

requestValidateCodeAction() calls ResendValidateCode with null parameters — the backend determines the recipient from the session token. When acting as a delegate, the session uses the owner's restricted token (Delegate.ts:198), so the magic code is sent to the owner's email, not the copilot's.

Assessment

Issue 1 (UI showing blank/wrong email) could likely be fixed in this PR by adding a session?.email fallback. Issue 2 (magic code routing to wrong person) is a deeper backend/architectural concern — the card issuance magic code verification may not be designed to work in a delegate context at all.

@rushatgabhane — these are pre-existing issues newly exposed by relaxing the delegate gate. You may want to consider whether the confirmation/magic-code step should remain blocked for delegates (even full copilots), or whether both issues need to be addressed as part of this PR's scope.

[rushatgabhane]

@Pujan92 thank you, asked here - https://expensify.slack.com/archives/C07HPDRELLD/p1771965713123569

[rushatgabhane]

@MelvinBot so magic code should be sent to owner only. can you update frontend to show the email of the account we copiloted into?

[rushatgabhane]

@Pujan92 we'll be sending the code to owner email only and not to the delegate's account

[MelvinBot]

Updated IssueNewCardConfirmMagicCodePage.tsx to show the owner's email on the magic code verification page.

Change: Added session.email as a fallback when account.primaryLogin is empty:

const [session] = useOnyx(ONYXKEYS.SESSION);
const primaryLogin = account?.primaryLogin ?? session?.email ?? '';

Why this works: When acting as a delegate, session.email is always populated with the owner's email (the person being copiloted into). account.primaryLogin should also be the owner's email, but may not be populated depending on what the backend returns after OpenApp. The fallback chain ensures the owner's email is always displayed.

This follows the same pattern used in ConfirmDelegateMagicCodePage.tsx.

[Pujan92]

LGTM!

Screen.Recording.2026-02-25.at.08.00.24.mov

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #79095 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[Pujan92]

@rushatgabhane do you know why I face error(500 Marqeta error (httpResponseCode: 400, errorCode: 400010, errorMessage: Cardholder not found)? Though it is not from this PR but would like to fix it.

[rushatgabhane]

can you try assigning someone else?

[rushatgabhane]

@Pujan92 it works for me. Maybe the issue for you is that the user already has a card assigned / you're not using staging server? not sure. try a different user

Screen.Recording.2026-02-25.at.10.09.59.mov

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81817.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4991ac0-b795e6a-8f65bc2f8dc243866de4689a2f3c2c46ccd62f89/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4991ac0-b795e6a-187fbbc6e887bd0930e49f7a9a6996796c0b4262/index.html

Web 🕸️
https://81817.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[jponikarchuk]

Deploy Blocker #83539 was identified to be related to this PR.

[rushatgabhane]

looking

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅