Make NewChatPage use new SelectionListWithSections#81869
Make NewChatPage use new SelectionListWithSections#81869grgia merged 17 commits intoExpensify:mainfrom
NewChatPage use new SelectionListWithSections#81869Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
bot
requested review from
dukenv0307 and
heyjennahay
and removed request for
a team
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bcee02b24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <SelectionListWithSections<OptionWithKey> | ||
| ref={selectionListRef} | ||
| ListItem={UserListItem} | ||
| sections={areOptionsInitialized ? sections : CONST.EMPTY_ARRAY} | ||
| textInputValue={searchTerm} | ||
| textInputHint={isOffline ? `${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}` : ''} | ||
| onChangeText={setSearchTerm} | ||
| textInputLabel={translate('selectionList.nameEmailOrPhoneNumber')} | ||
| headerMessage={headerMessage} | ||
| sections={areOptionsInitialized ? sections : getEmptyArray<Section<OptionWithKey>>()} | ||
| onSelectRow={selectOption} |
There was a problem hiding this comment.
This migration removed firstKeyForList/initiallyFocusedOptionKey and the new list call no longer provides initiallyFocusedItemKey, so the section list starts with focusedIndex = -1. In BaseSelectionListWithSections, Enter-based row selection is gated on focusedIndex >= 0, so keyboard users who open Start Chat and press Enter no longer select the first result until they manually move focus first; previously the first item was pre-focused.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I checked the behaviour of NewChatPage and I don't think that initiallyFocusedOptionKey is needed here as it is list with multiple selection
|
hi @grgia could you create an ad hoc build for testing this PR? 😊 |
…tware-mansion-labs/expensify-app-fork into @zfurtak/migrate-NewChatPage
| return; | ||
| } | ||
|
|
||
| const hasMoreToLoad = options.reports.length < totalReports; |
There was a problem hiding this comment.
Why do we remove this check?
There was a problem hiding this comment.
I noticed we check the same thins twice, this condition is being checked here, so I thought it's not needed here
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-21.at.11.18.59.movAndroid: mWeb ChromeScreen.Recording.2026-02-21.at.11.12.31.moviOS: HybridAppScreen.Recording.2026-02-21.at.11.17.40.moviOS: mWeb SafariScreen.Recording.2026-02-21.at.11.11.54.movMacOS: Chrome / SafariScreen.Recording.2026-02-21.at.11.10.18.mov |
|
@zfurtak Looks good, can you please resolve the conflicts? |
|
It must be some issue with Prettier check because I run |
|
@zfurtak I can see the diff, can you please apply this change? diff --git a/src/pages/NewChatPage.tsx b/src/pages/NewChatPage.tsx |
heyjennahay
left a comment
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
|
Not sure why my prettier doesn't work... The diff helped though, thank you @dukenv0307! |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.28-0 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.31-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
…s/@zfurtak/migrate-NewChatPage" This reverts commit 1f133a0.
6 participants
Explanation of Change
Fixed Issues
$ #65658
PROPOSAL:
Tests
+buttonStart chatOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-18.at.16.32.59.mov