Fix missing Concierge Chat in LHN when accessing via DM link#81934
Conversation
|
@marufsharifi how's it going? |
|
Resolved the conflicts, I will finish the tests soon. thanks |
|
@aimane-chnaif, this will be ready for review. Today, it takes time to get the email. i tested on some platforms. i will do the others asap. thanks. |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-02-17.at.4.30.15.pm.mov |
|
@aimane-chnaif, thanks for your patience. This is ready for your review. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
@marufsharifi please add unit test |
@aimane-chnaif, could you please specify the test cases that should be covered here? thanks. |
|
App/tests/unit/ReportUtilsTest.ts Line 4416 in c835e8d Add concierge report case here using updated |
|
@marcochavezf, kindly bump. thanks. |
|
The codecov/patch check is stuck, could you merge from main to see if that resolves it? |
|
@marcochavezf, merged the main. thanks. |
|
@marcochavezf, kindly bump. thanks. |
|
🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
Explanation of Change
Align LHN initialization for DM deep-link entry with the standard app entry flow so Concierge Chat is consistently shown for eligible users.
Fixed Issues
$ #73278
PROPOSAL: #73278 (comment)
Tests
Offline tests
Same as Tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-11-27.at.7.36.07.AM.mov
Android: mWeb Chrome
Screen.Recording.1404-11-27.at.7.39.55.AM.mov
iOS: Native
Screen.Recording.1404-11-27.at.5.57.11.PM.mov
iOS: mWeb Safari
Screen.Recording.1404-11-27.at.6.03.58.PM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-11-27.at.7.44.46.AM.mov