fix: keep user in ND until they setup 2FA when required#81984
fix: keep user in ND until they setup 2FA when required#81984cead22 merged 3 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce811b18ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Tests well! |
I think it depends on their
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppvideo_2026-02-13_14-36-49.mp4Android: mWeb ChromeScreen.Recording.2026-02-13.at.14.18.26.moviOS: HybridAppScreen.Recording.2026-02-13.at.14.32.38.moviOS: mWeb SafariScreen.Recording.2026-02-13.at.14.07.45.movMacOS: Chrome / SafariScreen.Recording.2026-02-13.at.14.03.13.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #80226 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Good product change that prevents users getting into a weird situation.
|
🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀
|
Explanation of Change
When domain requires 2FA we should handle 2FA setup on ND side in HybridApp. This PR modifies HybridApp.ts to open AuthScreens when 2FA required but not setup yet.
Fixed Issues
$ #80226
PROPOSAL:
Tests
Prerequisites:
Steps:
Offline tests
QA Steps
Prerequisites:
Steps:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260211_104506_Expensify.Adhoc.mp4
Android: mWeb Chrome
iOS: Native
D7C891CB-372C-47F8-AC55-D56BE42D6C2F.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari