No QA: Implement success/failure callback#82017
Merged
rafecolton merged 11 commits intoExpensify:mainfrom Feb 16, 2026
Merged
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
DylanDylann
commented
Feb 10, 2026
Contributor
Author
|
Testing on the test biomimetic flow: Screen.Recording.2026-02-11.at.01.41.54.mov |
DylanDylann
changed the title
melvin-bot
bot
requested review from
hoangzinh and
trjExpensify
and removed request for
a team and
trjExpensify
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 similar comment
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@chuckdries @JakubKorytko Could you please review this PR? |
Contributor
Author
|
@hoangzinh Sorry, please ignore this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e356e6193
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
rafecolton
requested review from
JakubKorytko,
chuckdries,
dariusz-biela and
rafecolton
and removed request for
hoangzinh
JakubKorytko
suggested changes
Feb 11, 2026
src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts
Outdated
Show resolved
Hide resolved
tests/unit/components/MultifactorAuthentication/config/scenarios/index.test.ts
Show resolved
Hide resolved
chuckdries
reviewed
Feb 12, 2026
rafecolton
requested changes
Feb 12, 2026
src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts
Outdated
Show resolved
Hide resolved
tests/unit/components/MultifactorAuthentication/config/scenarios/index.test.ts
Show resolved
Hide resolved
Contributor
Author
|
All comments are resolved |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.failure.callback.mp4android.success.callback.mp4iOS: HybridAppios.success.callback.mp4ios.failure.callback.mp4MacOS: Chrome / Safariweb.failure.callback.mp4 |
chuckdries
previously approved these changes
Feb 13, 2026
Contributor
chuckdries
left a comment
chuckdries
left a comment
There was a problem hiding this comment.
Looks good to me!
For testing videos above, I just adding some logging in the default callback
diff --git a/src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts b/src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts
index f929fb2b96b..4407beaed4f 100644
--- a/src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts
+++ b/src/components/MultifactorAuthentication/config/scenarios/DefaultUserInterface.ts
@@ -13,8 +13,10 @@ import CONST from '@src/CONST';
* Scenarios can override this with their own callback to handle custom navigation logic.
*/
// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const defaultCallback = (isSuccessful: boolean, callbackInput: MultifactorAuthenticationCallbackInput): Promise<MultifactorAuthenticationCallbackResponse> =>
- Promise.resolve(CONST.MULTIFACTOR_AUTHENTICATION.CALLBACK_RESPONSE.SHOW_OUTCOME_SCREEN);
+const defaultCallback = (isSuccessful: boolean, callbackInput: MultifactorAuthenticationCallbackInput): Promise<MultifactorAuthenticationCallbackResponse> => {
+ console.log('this is the default callback!', callbackInput);
+ return Promise.resolve(CONST.MULTIFACTOR_AUTHENTICATION.CALLBACK_RESPONSE.SHOW_OUTCOME_SCREEN);
+}
/**
* Default UI configuration for all multifactor authentication scenarios with modals and outcomes.
rafecolton
reviewed
Feb 13, 2026
Member
rafecolton
left a comment
rafecolton
left a comment
There was a problem hiding this comment.
Please add comments to the unit tests
Contributor
Author
|
@rafecolton All good to merge? Just want to make sure I didn't miss any comments |
Contributor
|
@DylanDylann it would be good if you merged this PR, because then I could start resolving conflicts with error handling. |
Contributor
Author
|
Looks like we need to wait for @rafecolton to come online |
52 tasks
Contributor
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
51 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.20-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #80693
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari