[PR 3 of 15] Remove global Onyx reference from getOriginalReportID #82058
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
tgolen
changed the title
tgolen
changed the base branch from
main
to
tgolen-refactorOnyxConnection-reportactions-2and3
tgolen
changed the title
melvin-bot
bot
requested review from
aldo-expensify and
heyjennahay
and removed request for
a team
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 similar comment
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return {}; | ||
| } | ||
| const filteredReportActions: OnyxCollection<ReportActions> = {}; | ||
| for (const reportID of reportIDs) { |
There was a problem hiding this comment.
❌ PERF-13 (docs)
The string interpolation ONYXKEYS.COLLECTION.REPORT_ACTIONS is called on every iteration of the for loop but does not depend on the reportID iterator variable. The constant prefix should be hoisted outside the loop.
Suggested fix:
function getReportActionsForReportIDs(allReportActions: OnyxCollection<ReportActions>, reportIDs: string[]): OnyxCollection<ReportActions> {
if (\!allReportActions || reportIDs.length === 0) {
return {};
}
const filteredReportActions: OnyxCollection<ReportActions> = {};
const collectionKey = ONYXKEYS.COLLECTION.REPORT_ACTIONS; // Hoist outside loop
for (const reportID of reportIDs) {
const key = `${collectionKey}${reportID}`;
filteredReportActions[key] = allReportActions[key];
}
return filteredReportActions;
}Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
This seems so low value as to not be worth it.
| ); | ||
|
|
||
| const ancestorReportActionsSelector = useCallback( | ||
| (allReportActions: OnyxCollection<OnyxTypes.ReportActions>) => { |
There was a problem hiding this comment.
❌ PERF-13 (docs)
The .map() callback accesses ancestor.report.reportID on each iteration. While ancestor.report is iterator-dependent, repeatedly accessing the .reportID property inside the map is still correct usage since it depends on the iterator. However, if reportID extraction could be done in a more performant way or if there are other optimizations possible, they should be considered.
Actually, upon closer inspection, this is NOT a violation. The .map() is correctly extracting reportID from each ancestor, which is iterator-dependent. This is the proper usage pattern.
No action needed - this is correct usage.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
OK, sounds like you talked yourself out of your own suggestion. Haha, I agree with you. It is fine as it is.
| const originalReportID = getOriginalReportID( | ||
| ancestorReport.reportID, | ||
| ancestorReportAction, | ||
| ancestorsReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${ancestorReport.reportID}`], |
There was a problem hiding this comment.
❌ PERF-13 (docs)
The string interpolation ONYXKEYS.COLLECTION.REPORT_ACTIONS is accessed on every iteration of the ancestors.map() but does not depend on the ancestor iterator variable. The constant prefix should be hoisted outside the map callback.
Suggested fix:
const reportActionsCollectionKey = ONYXKEYS.COLLECTION.REPORT_ACTIONS;
return (
<View style={[styles.pRelative]}>
<AnimatedEmptyStateBackground />
<OfflineWithFeedback
shouldDisableOpacity
errors={
report?.errorFields?.createChatThread ?? (report?.errorFields?.createChat ? getMicroSecondOnyxErrorWithTranslationKey('report.genericCreateReportFailureMessage') : null)
}
errorRowStyles={[styles.ml10, styles.mr2]}
onClose={() => navigateToConciergeChatAndDeleteReport(report?.reportID, conciergeReportID, undefined, true)}
>
{ancestors.map((ancestor) => {
const {report: ancestorReport, reportAction: ancestorReportAction} = ancestor;
const canUserPerformWriteAction = canUserPerformWriteActionReportUtils(ancestorReport, isReportArchived);
const shouldDisplayThreadDivider = !isTripPreview(ancestorReportAction);
const isAncestorReportArchived = isArchivedReport(ancestorsReportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${ancestorReport.reportID}`]);
const originalReportID = getOriginalReportID(
ancestorReport.reportID,
ancestorReportAction,
ancestorsReportActions?.[`${reportActionsCollectionKey}${ancestorReport.reportID}`],
);
// ...
})}
</OfflineWithFeedback>
</View>
);Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
Nah, too low value to be worth it.
|
@situchan Could you please review this as a C+? |
Sure |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@codex review |
Should we add unit test? |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
tgolen
deleted the
tgolen-refactorOnyxConnection-reportactions-2and3b
branch
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
4 participants
Explanation of Change
This is part of the process to remove a global reference from
getOriginalReportID()(18 references). Here is the full refactoring plan:reportActionsParamparameter and fallback to the global Onyx value forallReportActionsundefinedfor the parameterreportActionsavailable to pass that as the parameterreportActionsas the parameterreportActionsParamtoreportActionsallReportActionsand the Onyx connectionFixed Issues
Part of #66419
Tests
Open a threaded conversation
Multi-level thread ancestry
Thread in expense reports
Thread navigation
What to look for:
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari