[NoQA] API integration for freeze card#82199
Merged
MariaHCD merged 3 commits intoExpensify:mainfrom Feb 13, 2026
Merged
Conversation
ShridharGoel
changed the title
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 475ddec0ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const previousFrozen = card?.nameValuePairs?.frozen ?? null; | ||
|
|
||
| const frozenData: PartialDeep<Card> = { | ||
| state: CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED, |
There was a problem hiding this comment.
Setting state to STATE_SUSPENDED here will make the card disappear from workspace card selectors as soon as freezeCard() runs, because filterInactiveCards() treats suspended cards as inactive (src/libs/CardUtils.ts:798-811) and getAllCardsForWorkspace() applies that filter before details rendering (src/libs/CardUtils.ts:831-833). In that flow, the details page can immediately lose card and render NotFoundPage (src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx:99-101), leaving no in-app path to unfreeze.
Useful? React with 👍 / 👎.
Contributor
There was a problem hiding this comment.
We need to show the frozen card in the list and will be handled in a future PR.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Pujan92
reviewed
Feb 12, 2026
Comment on lines
+56
to
+58
| type CardListUpdateData = Omit<PartialDeep<Card>, 'errors'> & { | ||
| errors?: Card['errors'] | null; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| type CardListUpdateData = Omit<PartialDeep<Card>, 'errors'> & { | |
| errors?: Card['errors'] | null; | |
| }; | |
| type CardListUpdateData = PartialDeep<Card>; |
Can we do this and set errors: undefined in building optimistic data?
Contributor
Author
There was a problem hiding this comment.
Isn't it true that Onyx.merge() can ignore top-level undefined changes? And setting to null is better?
Contributor
There was a problem hiding this comment.
Ah, Ok. I thought to keep the same type of Card errors prop.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #81642 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
MariaHCD
approved these changes
Feb 13, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
65 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.19-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
API integration for freeze card feature.
Fixed Issues
$ #81642
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari