Skip to content

[No QA] Help site updates for new feature: Home R2-4 [New Expensify] #82341

Merged
stephanieelliott merged 3 commits intomainfrom
Helpsite-updates-Home-R2-4
Feb 16, 2026
Merged

[No QA] Help site updates for new feature: Home R2-4 [New Expensify] #82341
stephanieelliott merged 3 commits intomainfrom
Helpsite-updates-Home-R2-4

Conversation

@stephanieelliott
Copy link
Contributor

@stephanieelliott stephanieelliott commented Feb 13, 2026

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR restructures the Navigating New Expensify article to focus on the new Home tab and provide clearer, more task-oriented guidance. The changes improve organization by breaking down each navigation tab into dedicated sections with clear "what it's used for" headings. However, there are several issues with metadata accuracy, heading structure, terminology consistency, and content clarity that need to be addressed before publication.

Scores Summary

  • Readability: 7/10 - Good structural improvements with clear section breaks, but some content is repetitive, vague, or inconsistent. The article uses clearer language overall but loses some helpful context from the original version.

  • AI Readiness: 5/10 - The YAML metadata contains contradictions. The description references navigation tabs but the internalScope says it does not explain the detailed behavior of the Home tab sections. Heading hierarchy is inconsistent (uses single # for main title but also for subsections, should use ## for subsections).

  • Style Compliance: 6/10 - Terminology is mostly consistent but there are issues with button naming consistency, unverified article references, and unclear admin permissions.

Key Findings

Critical issues that must be addressed:

  1. YAML Metadata Accuracy (Critical): The internalScope field contradicts the content - says it does not explain Home tab behavior but Home tab is included. All subsections use single # instead of ## which breaks heading hierarchy.

  2. Heading Hierarchy (Critical): The article uses single # for 7 subsections after the main title. These should all be ## for proper hierarchy and AI parsing.

  3. Content Redundancy (Important): Multiple sections repeat the same information. The How to navigate Expensify quickly section adds no new value.

  4. Terminology Inconsistencies (Important): Receipt button vs Camera/Receipt button - confirm correct UI label. Create button formatting varies throughout.

  5. Vague References (Important): References Expensify Home Overview article without confirmation or link.

Recommendations

Priority 1 (Must fix before merge):

  • Fix YAML metadata internalScope field to accurately describe content
  • Change all 7 subsection headings from # to ##
  • Standardize button terminology
  • Verify and link to referenced article or remove reference

Priority 2 (Should fix):

  • Reduce or remove redundant How to navigate quickly section
  • Clarify Home tab vs Inbox relationship
  • Restore helpful details about smart reminders and workspace filters

Files Reviewed

  • docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md - Improved structure but needs metadata, hierarchy, and consistency fixes

@github-actions github-actions bot changed the title Help site updates for new feature: Home R2-4 [New Expensify] [No QA] Help site updates for new feature: Home R2-4 [New Expensify] Feb 13, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Feb 13, 2026

@stephanieelliott
Copy link
Contributor Author

This is ready for you @JmillsExpensify

Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both articles look great to me. The navigational one could probably benefit from screenshots though ultimately we have a lot of UI changing so I'm fine keeping them out for now.

@JmillsExpensify
Copy link
Contributor

The checklist requirement on these PRs is a bit heavy. Where am I supposed to copy that from again?

@stephanieelliott
Copy link
Contributor Author

@JmillsExpensify images are cooking in https://github.com/Expensify/Expensify/issues/597062! They were just linked to an earlier release.

Re: the PR checklist, there is an issue to skip this test for docs files: #82600

@stephanieelliott
Copy link
Contributor Author

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@stephanieelliott stephanieelliott merged commit 8ae94b0 into main Feb 16, 2026
13 of 14 checks passed
@stephanieelliott stephanieelliott deleted the Helpsite-updates-Home-R2-4 branch February 16, 2026 22:03
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants