Removed useOptionsList from IOURequestEditReportCommon.tsx#82506
Removed useOptionsList from IOURequestEditReportCommon.tsx#82506mountiny merged 2 commits intoExpensify:mainfrom
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 874b90d4d4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
| policyID: matchingOption?.policyID ?? report.policyID, | ||
| policyID: report.policyID, | ||
| reportID: report.reportID, | ||
| icons: getIconsForExpenseReport(report, personalDetails, policy), |
There was a problem hiding this comment.
Did we miss: errors, invitedSecondaryLogin, accountID, pendingAction, isBold that are gonna be used in InviteMemberListItem
There was a problem hiding this comment.
@hoangzinh, are you seeing any difference in the list from staging? If yes, lemme know; otherwise, these fields are fine.
There was a problem hiding this comment.
I couldn't find any regression. Let's keep current attributes mapping.
There was a problem hiding this comment.
I am not very clear on this change either, I feel like it might bring some regressions but let's see
| expect(ReportUtils.getIconsForPolicyExpenseChat).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('does not export getIconsForExpenseReport', () => { |
There was a problem hiding this comment.
I don't object to exporting this function for use elsewhere. However, should we investigate why the author doesn't want to export it?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-16.at.16.05.03.android.movAndroid: mWeb ChromeScreen.Recording.2026-02-16.at.16.06.30.android.c.moviOS: HybridAppScreen.Recording.2026-02-16.at.16.12.35.moviOS: mWeb SafariScreen.Recording.2026-02-16.at.16.09.33.ios.s.movMacOS: Chrome / SafariScreen.Recording.2026-02-16.at.16.00.09.web.mov |
| policyID: matchingOption?.policyID ?? report.policyID, | ||
| policyID: report.policyID, | ||
| reportID: report.reportID, | ||
| icons: getIconsForExpenseReport(report, personalDetails, policy), |
There was a problem hiding this comment.
I am not very clear on this change either, I feel like it might bring some regressions but let's see
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Explanation of Change
Fixed Issues
$ #82183
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-02-15.at.11.26.33.AM.mov