Conversation
melvin-bot
bot
requested review from
ikevin127 and
joekaufmanexpensify
and removed request for
a team
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf374fa9d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <ConfirmModal | ||
| isVisible={isSwitchSingleToMultipleLevelTagWarningModalVisible} | ||
| onConfirm={() => { | ||
| cleanPolicyTags(policyID); |
There was a problem hiding this comment.
This modal replaced showConfirmModal, but unlike useConfirmModal it does not set shouldHandleNavigationBack; that means pressing browser/history back while it is open navigates away instead of taking the cancel path. In this flow setImportedSpreadsheetIsImportingMultiLevelTags(true) is already set before opening the modal, and only onCancel clears it, so backing out can leave ONYXKEYS.IMPORTED_SPREADSHEET.isImportingMultiLevelTags stuck as true and cause later imports to use multi-level behavior unexpectedly.
Useful? React with 👍 / 👎.
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
[CP Staging] Revert "fix: refactor ConfirmModal usage to useConfirmModal in workspace tags pages" (cherry picked from commit 03b867b) (cherry-picked to staging by mountiny)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.19-2 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
3 participants
Reverts #77913
Fixed Issues
$ #82456