feat: [CFI] Add Approver row on the member invite confirmation page by TaduJR · Pull Request #82683 · Expensify/App

TaduJR · 2026-02-17T16:20:20Z

Explanation of Change

This PR adds an Approver row to the member invite confirmation page for Control workspaces with advanced approvals enabled.

Fixed Issues

$ #79157
PROPOSAL: #79157 (comment)

Tests

Prerequisites

Create a Control workspace
Add at least 3 members to the workspace (including yourself)
Go to Workflows > Enable Workflows
Under Approvals, select Advanced Approval
Add at least 2 approval workflows (one default + one custom approver)
Workspace has a company card direct feed with at least one unassigned card

Test 1: Approver row visibility

Go to workspace Members > Invite member
Select a user > tap Next
Verify the Approver row appears below the Role row on the confirmation page
Verify it's populated with the workspace's default approver

Test 2: Approver selection

Tap on the Approver row
Verify the approver selection page opens with a list of workspace members
Select a different approver
Verify you're navigated back and the new approver is displayed

Test 3: Approver row should NOT appear for

Test on a Collect workspace → Verify Approver row is hidden
Test on a Control workspace with Basic Approvals → Verify Approver row is hidden
Test on a Control workspace with Workflows disabled → Verify Approver row is hidden

Test 4: Multiple invitees share same approver

Select multiple members to invite (e.g., 3 people)
Go to confirmation page
Verify the Approver row appears
Select an approver (e.g., Alice)
Complete invite
Check all 3 members' details
Verify: All 3 invitees have Alice as their approver

Test 5: Regression — Navigation back from approver page (#81594)

Go to workspace Members > Invite member
Enter any email > select user > Next
On confirm page, click Approver row
Change approver > select any member
Verify: RHP returns to the Confirm details page (not a duplicate)
On confirm page, click Approver row again
Press the RHP Back button
Verify: RHP returns to the Confirm details page (not the invite list)
Click Members row to go back to invite list
Verify: Navigation flows correctly without any loops or duplicate pages

Test 6: Regression — Search field threshold on approver page (#81598)

Go to workspace Members > Invite member (workspace has fewer than 12 members)
Enter any email > select user > Next
On confirm page, click Approver row
Verify: Search field does NOT appear when there are fewer than 12 workspace members
(Optional) If you have a workspace with 12+ members, verify the search field does appear

Test 7: Regression — Company Cards assign card flow (#81601)

Go to workspace settings > Company cards
Click Assign card on an unassigned card
Enter a non-member email and select the user
On the invite-new-member confirm page, click the Approver field
Select any member as approver
Verify: RHP returns to the invite-new-member confirm page (still in Company Cards context)
Verify: The selected approver is displayed correctly
Click Invite
Verify: The flow proceeds to the card assignment confirmation (does NOT redirect to Members page)

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome.mp4

Regression Tests:

Mac-Chrome.mp4

melvin-bot · 2026-02-17T16:20:28Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4d364f6df

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-02-17T16:44:17Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/actions/Policy/Member.ts	`74.15% <100.00%> (+1.95%)`	⬆️
src/libs/actions/Report/index.ts	`63.54% <ø> (-0.13%)`	⬇️
src/pages/workspace/withPolicy.tsx	`100.00% <ø> (ø)`
src/ROUTES.ts	`13.86% <0.00%> (-0.02%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.48% <0.00%> (-0.02%)`	⬇️
...s/workspace/WorkspaceInviteMessageApproverPage.tsx	`94.44% <94.44%> (ø)`
...kspace/members/WorkspaceInviteMessageComponent.tsx	`0.00% <0.00%> (ø)`
... and 35 files with indirect coverage changes

…d-Approver-row-on-the-member-invite-confirmation-page

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a610cbeea6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Ollyws · 2026-02-23T15:00:18Z

@TaduJR We have some conflicts if you could take a look, thanks.

…d-Approver-row-on-the-member-invite-confirmation-page # Conflicts: # src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

TaduJR · 2026-02-25T07:44:51Z

@TaduJR We have some conflicts if you could take a look, thanks.

Done @Ollyws

Thanks!

Ollyws · 2026-02-25T11:20:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: HybridApp

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

…d-Approver-row-on-the-member-invite-confirmation-page

Ollyws

All regressions fixed, LGTM.

OSBotify · 2026-02-25T14:36:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-25T14:45:31Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T14:49:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82683.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-460e4c4-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-460e4c4-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://82683.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:25:22Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-02-25T19:51:47Z

Deploy Blocker #83474 was identified to be related to this PR.

jponikarchuk · 2026-02-25T20:12:27Z

Deploy Blocker #83484 was identified to be related to this PR.

nlemma · 2026-02-25T20:21:39Z

Deploy Blocker #83472 was identified to be related to this PR.

OSBotify · 2026-02-27T14:56:42Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: [CFI] Add Approver row on the member invite confirmation page

b4d364f

TaduJR requested review from a team as code owners February 17, 2026 16:20

melvin-bot Bot assigned TaduJR Feb 17, 2026

melvin-bot Bot requested review from Ollyws and heyjennahay February 17, 2026 16:20

melvin-bot Bot removed request for a team February 17, 2026 16:20

TaduJR marked this pull request as draft February 17, 2026 16:20

chatgpt-codex-connector Bot reviewed Feb 17, 2026

View reviewed changes

Comment thread src/pages/workspace/WorkspaceInviteMessageApproverPage.tsx Outdated

Comment thread src/pages/workspace/WorkspaceInviteMessageApproverPage.tsx Outdated

TaduJR added 5 commits February 17, 2026 22:00

fix: base approver search visibility on unfiltered member count

632fa83

fix: add backTo param to approver page for correct refresh navigation

87e47da

Merge branch 'main' of https://github.com/TaduJR/App into feat-CFI-Ad…

ab8eef7

…d-Approver-row-on-the-member-invite-confirmation-page

Merge branch 'main' of https://github.com/TaduJR/App into feat-CFI-Ad…

bd01e1a

…d-Approver-row-on-the-member-invite-confirmation-page

fix: use navigate for Members row to match Role/Approver pattern

a610cbe

TaduJR marked this pull request as ready for review February 19, 2026 06:27

chatgpt-codex-connector Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

Comment thread src/pages/workspace/WorkspaceInviteMessageApproverPage.tsx

Merge branch 'main' of https://github.com/TaduJR/App into feat-CFI-Ad…

d86ab16

…d-Approver-row-on-the-member-invite-confirmation-page # Conflicts: # src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

TaduJR added 2 commits February 25, 2026 14:34

fix: remove canBeMissing

b03d851

Merge branch 'main' of https://github.com/TaduJR/App into feat-CFI-Ad…

025b961

…d-Approver-row-on-the-member-invite-confirmation-page

Ollyws approved these changes Feb 25, 2026

View reviewed changes

melvin-bot Bot requested a review from inimaga February 25, 2026 12:00

inimaga approved these changes Feb 25, 2026

View reviewed changes

inimaga merged commit 460e4c4 into Expensify:main Feb 25, 2026
36 of 37 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

nlemma mentioned this pull request Feb 25, 2026

[$250] Missing Approver field on confirm page after deleting workflow and inviting member #83472

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 25, 2026

[$250] Approver field is shown on confirm page when second approver is removed offline #83474

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 25, 2026

[$250] RHP reopens confirm page after changing member and clicking back button twice #83484

Closed

7 tasks

inimaga mentioned this pull request Feb 25, 2026

[CP Staging] Revert "feat: [CFI] Add Approver row on the member invite confirmation page" #83490

Merged

50 tasks

Conversation

TaduJR commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Prerequisites

Test 1: Approver row visibility

Test 2: Approver selection

Test 3: Approver row should NOT appear for

Test 4: Multiple invitees share same approver

Test 5: Regression — Navigation back from approver page (#81594)

Test 6: Regression — Search field threshold on approver page (#81598)

Test 7: Regression — Company Cards assign card flow (#81601)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Feb 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Ollyws commented Feb 23, 2026

Uh oh!

TaduJR commented Feb 25, 2026

Uh oh!

Ollyws commented Feb 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

jponikarchuk commented Feb 25, 2026

Uh oh!

jponikarchuk commented Feb 25, 2026

Uh oh!

nlemma commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TaduJR commented Feb 17, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited by github-actions Bot

Loading