Skip to content

[No QA] Update Merging-expenses.md#82949

Merged
twisterdotcom merged 4 commits intomainfrom
OfstadC-patch-1
Feb 25, 2026
Merged

[No QA] Update Merging-expenses.md#82949
twisterdotcom merged 4 commits intomainfrom
OfstadC-patch-1

Conversation

@OfstadC
Copy link
Copy Markdown
Contributor

@OfstadC OfstadC commented Feb 19, 2026

Adding the remaining section

Explanation of Change

We launched this page last fall, but one feature wasn't live - so just updating the page to add that section now that it's live

Fixed Issues

$https://github.com/Expensify/Expensify/issues/515362
PROPOSAL: https://github.com/Expensify/Expensify/issues/515362#issuecomment-3102500670

Tests

  • Verify that no errors appear in the JS console

No Tests Required

Offline tests

No Offline Tests Required

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

NO QA Steps Required

PR Author Checklist

Redacted PR Checklist based on SO

Add a quick note in the PR body about what you updated (no need to complete the checklist, you can delete it)

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Adding the remaining section
Comment thread docs/articles/new-expensify/reports-and-expenses/Merging-expenses.md Outdated

## Merging from the Reports or Expenses page

1. In the left-hand menu, select **Reports > Expense Reports** or **Reports > Expenses**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent navigation terminology: This step references "the left-hand menu," but the existing section above (line 16) describes the same area as "the navigation tabs (on the left on web, and at the bottom on mobile)." Using "left-hand menu" is platform-specific to web/desktop and does not account for mobile users where navigation appears at the bottom.

Consider aligning with the existing phrasing, e.g.:
1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Reports > Expense Reports** or **Reports > Expenses**.

Or use a shorter platform-neutral version like:
1. Select **Reports > Expense Reports** or **Reports > Expenses**.

Comment thread docs/articles/new-expensify/reports-and-expenses/Merging-expenses.md Outdated
Comment thread docs/articles/new-expensify/reports-and-expenses/Merging-expenses.md Outdated
…ses.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new section documenting how to merge expenses from the Reports or Expenses page (bulk selection flow), complementing the existing "Merging from an individual expense" section. The addition is well-structured and follows the established pattern of the file. A few minor formatting inconsistencies should be addressed before merging.

Recommendation: REQUEST_CHANGES (minor issues only)

Scores Summary

  • Accuracy: 4/5 - The steps appear correct for a bulk-select merge flow. One small concern: Step 1 references both Reports > Expense Reports and Reports > Expenses, but the existing section ("Merging from an individual expense") only references Reports > Expenses. It would be helpful to confirm both paths are valid entry points for this flow, and clarify when a user would choose one over the other.
  • Clarity: 4/5 - The instructions are concise and easy to follow. The sub-steps under step 4 (receipt handling) are clear and mirror the pattern used in the existing section.
  • Completeness: 4/5 - The new section covers the key steps well. One gap: it does not mention how to select two expenses (e.g., via checkboxes), while the existing Delete-Expenses article (a comparable bulk-action flow) explicitly says "Check the box next to the expense(s)." Adding similar guidance would help users unfamiliar with multi-select.
  • Formatting: 3/5 - There are formatting inconsistencies that should be corrected (detailed below).
  • Consistency: 3/5 - Some deviations from the conventions used in both this file and peer articles.

Key Findings

Issues to address:

  1. Missing period at end of step 1. Step 1 ends with **Reports > Expenses** with no trailing period. The existing section in this same file consistently ends each step with a period (e.g., "Tap the expense you would like to merge from."). The Delete-Expenses article also uses periods at the end of every step. Step 1 should end with a period for consistency.

  2. Inconsistent navigation language. The existing section in this file says "In the navigation tabs (on the left on web, and at the bottom on mobile)," while the new section says "In the left-hand menu." The Delete-Expenses article also uses "In the left-hand menu." While "left-hand menu" is used elsewhere in the docs, it is inconsistent within this file. Consider aligning the new section with the existing section in this article, or updating both to use the same phrasing.

  3. Selection mechanism not specified. The existing section and the Delete-Expenses article both describe the mechanism for selecting items (e.g., "Check the box next to the expense(s)"). The new section says "Select two eligible expenses" without specifying how. Consider "Check the box next to two eligible expenses." for clarity, matching the pattern in Delete-Expenses.

  4. Heading style for AI readiness. The heading "Merging from the Reports or Expenses page" is reasonably descriptive. However, for improved AI discoverability, consider "How to merge expenses from the Reports or Expenses page" to match the question-style phrasing used in some peer articles (e.g., Create-an-Expense uses "How to..." headings). This is optional.

Positive aspects:

  • The new section fills a genuine documentation gap -- the bulk-select merge flow was previously undocumented.
  • The receipt-handling sub-steps (step 4) are well-organized and mirror the existing section approach.
  • The section is placed logically between the individual merge flow and the eligibility criteria.
  • The writing is concise and avoids unnecessary jargon.

Recommendations

  1. [Required] Add a period at the end of step 1.
  2. [Suggested] Align navigation language within the file (either update the existing section to say "left-hand menu" or update the new section to match the existing phrasing).
  3. [Suggested] Clarify the selection mechanism in step 2 (e.g., "Check the box next to two eligible expenses.").
  4. [Optional] Consider a "How to..." heading prefix for AI readiness consistency with peer articles.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Merging-expenses.md -- New "Merging from the Reports or Expenses page" section added (11 lines). Minor formatting and consistency issues identified.

Note: This review evaluates only the proposed changes in the diff, not the unchanged portions of the file.

…ses.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot changed the title Update Merging-expenses.md [No QA] Update Merging-expenses.md Feb 19, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Feb 19, 2026

A preview of your ExpensifyHelp changes have been deployed to https://b118e1dd.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
Copy link
Copy Markdown
Contributor

I applied the AI reviewer changes and reformatted this a bit based on the newer formatting standards. @OfstadC feel free to merge it yourself if it looks ok to you!

@OfstadC
Copy link
Copy Markdown
Contributor Author

OfstadC commented Feb 20, 2026

Thanks @stephanieelliott !

I'm seeing that Merging is blocked 🤔

@stephanieelliott stephanieelliott requested a review from a team February 25, 2026 02:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Feb 25, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @twisterdotcom

@melvin-bot melvin-bot Bot requested a review from twisterdotcom February 25, 2026 02:59
@stephanieelliott
Copy link
Copy Markdown
Contributor

Hm weird. Adding another reviewer to merge.

@melvin-bot melvin-bot Bot removed the request for review from a team February 25, 2026 02:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Feb 25, 2026

@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom twisterdotcom merged commit 004811e into main Feb 25, 2026
15 checks passed
@twisterdotcom twisterdotcom deleted the OfstadC-patch-1 branch February 25, 2026 10:10
@OfstadC
Copy link
Copy Markdown
Contributor Author

OfstadC commented Feb 25, 2026

Thanks @twisterdotcom & @stephanieelliott ! Much appreciated ❤️

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.26-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants