[No QA] Update Merging-expenses.md#82949
Conversation
Adding the remaining section
|
|
||
| ## Merging from the Reports or Expenses page | ||
|
|
||
| 1. In the left-hand menu, select **Reports > Expense Reports** or **Reports > Expenses** |
There was a problem hiding this comment.
Inconsistent navigation terminology: This step references "the left-hand menu," but the existing section above (line 16) describes the same area as "the navigation tabs (on the left on web, and at the bottom on mobile)." Using "left-hand menu" is platform-specific to web/desktop and does not account for mobile users where navigation appears at the bottom.
Consider aligning with the existing phrasing, e.g.:
1. In the navigation tabs (on the left on web, and at the bottom on mobile), select **Reports > Expense Reports** or **Reports > Expenses**.
Or use a shorter platform-neutral version like:
1. Select **Reports > Expense Reports** or **Reports > Expenses**.
…ses.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new section documenting how to merge expenses from the Reports or Expenses page (bulk selection flow), complementing the existing "Merging from an individual expense" section. The addition is well-structured and follows the established pattern of the file. A few minor formatting inconsistencies should be addressed before merging. Recommendation: REQUEST_CHANGES (minor issues only) Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Note: This review evaluates only the proposed changes in the diff, not the unchanged portions of the file. |
…ses.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://b118e1dd.helpdot.pages.dev ⚡️ Updated articles: |
|
I applied the AI reviewer changes and reformatted this a bit based on the newer formatting standards. @OfstadC feel free to merge it yourself if it looks ok to you! |
|
Thanks @stephanieelliott ! I'm seeing that Merging is blocked 🤔 |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
Hm weird. Adding another reviewer to merge. |
|
@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Thanks @twisterdotcom & @stephanieelliott ! Much appreciated ❤️ |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
Adding the remaining section
Explanation of Change
We launched this page last fall, but one feature wasn't live - so just updating the page to add that section now that it's live
Fixed Issues
$https://github.com/Expensify/Expensify/issues/515362
PROPOSAL: https://github.com/Expensify/Expensify/issues/515362#issuecomment-3102500670
Tests
No Tests Required
Offline tests
No Offline Tests Required
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
NO QA Steps Required
PR Author Checklist
Redacted PR Checklist based on SO
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari