Conversation
…in when opened. "
melvin-bot
Bot
requested review from
situchan
and removed request for
a team
melvin-bot
Bot
requested review from
a team,
joekaufmanexpensify and
lakchote
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7c685c8c7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const animation = requestAnimationFrame(() => { | ||
| timer = setTimeout(() => { | ||
| mergeTransactionIdsHighlightOnSearchRoute(queryJSON.type, Object.fromEntries(highlightedTransactionIDs.map((id) => [id, false]))); | ||
| }, CONST.ANIMATED_HIGHLIGHT_START_DURATION); |
There was a problem hiding this comment.
By starting mergeTransactionIdsHighlightOnSearchRoute(...false) inside requestAnimationFrame, this timeout is scheduled about one frame later than the setNewSearchResultKeys(null) timeout (which now starts immediately with the same delay). In the common case, newSearchResultKeys becomes null first, this effect re-runs because it depends on newSearchResultKeys, and the cleanup clears the pending timeout before it executes, so transactionIDsToHighlight is never reset and the same expense gets highlighted again on later opens.
Useful? React with 👍 / 👎.
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
[CP Staging] Revert "fix: Expense created while on "Reports", gets highlighted again when opened. " (cherry picked from commit 2251855) (cherry-picked to staging by mountiny)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.23-3 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.24-1 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀
|
3 participants
Reverts #82538
Fixed issues
$ #83004