Fix: “Reimbursable” column width is wider than necessary on report page#83124
Fix: “Reimbursable” column width is wider than necessary on report page#83124JS00001 merged 15 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Taking a look |
@twilight2294 How is it going? |
|
Have a fix ready, pushing in an hour |
|
@shawnborton can you please give feedback for the new change: New change:
On staging:
If the above is also not correct, can you tell me exactly what you expect, i made the change from the expected result of the issue. Also please trigger adhoc build if you want to test latest changes |
|
test failures are on main branch |
|
I iterated a few variations, posting in an hour |
|
@shawnborton can you trigger adhoc build please ? I updated the width to |
|
Test failure seems unrelated |
|
Can do. |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@twilight2294 can you complete the screenshots/videos? |
Uploaded, looking at the failing tests now |
|
@hungvu193 PR is ready for your review |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2026-03-16.at.14.36.50.moviOS: mWeb SafarimSafar.mov |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.40-0 🚀
|
|
Deploy Blocker ##85655 was identified to be related to this PR. |
Thanks for reminding. We're working on a fix |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.40-0 🚀
|








Explanation of Change
Fixed Issues
$ #82667
PROPOSAL: #82667 (comment)
Tests
Offline tests
QA Steps
Verify that:
The Reimbursable column should use a fixed width.
Width should be just wide enough to comfortably fit the word “Reimbursable” (header) and values “Yes” / “No”.
The column should not occupy unnecessary horizontal space.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
|MacOS: Chrome / Safari