[NO QA] Enhance telemetry spans for HybridApp transitions by kubabutkiewicz · Pull Request #83218 · Expensify/App

kubabutkiewicz · 2026-02-23T15:46:33Z

Explanation of Change

Fixed Issues

$#77172
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-23T15:46:41Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/HybridApp.ts

abzokhattab · 2026-02-23T15:52:55Z

Hi does it need C+ review?

I will check it later today

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 376d5a21c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-23T15:56:14Z

src/libs/Navigation/AppNavigator/AuthScreens.tsx

+        if (CONFIG.IS_HYBRID_APP) {
+            const parentTransitionSpan = getSpan(CONST.TELEMETRY.SPAN_OD_ND_TRANSITION) ?? getSpan(CONST.TELEMETRY.SPAN_OD_ND_TRANSITION_LOGGED_OUT);
+            startSpan(CONST.TELEMETRY.SPAN_OD_ND_TRANSITION_STAGES.AUTH_SCREENS_MOUNT, {


Start auth mount span after transition sign-out check

This span is started before the isLoggingInAsNewUser && isTransitioning guard, but that guard returns early via Session.signOutAndRedirectToSignIn(...), so the endSpan(CONST.TELEMETRY.SPAN_OD_ND_TRANSITION_STAGES.AUTH_SCREENS_MOUNT) call at the bottom of the effect is skipped. In account-switch transition flows, OdNdAuthScreensMount remains open (or gets canceled later), which corrupts the stage timing this change is trying to capture.

Useful? React with 👍 / 👎.

codecov · 2026-02-23T17:05:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.56% <ø> (+0.12%)`	⬆️
src/Expensify.tsx	`88.88% <100.00%> (+0.09%)`	⬆️
src/HybridAppHandler.tsx	`52.94% <57.14%> (+2.94%)`	⬆️
src/libs/HybridApp.ts	`47.27% <0.00%> (-2.73%)`	⬇️
src/libs/Navigation/AppNavigator/AuthScreens.tsx	`53.04% <40.00%> (-0.29%)`	⬇️
src/libs/actions/Session/index.ts	`41.53% <0.00%> (-1.26%)`	⬇️
... and 48 files with indirect coverage changes

joekaufmanexpensify · 2026-02-23T17:54:23Z

No product review needed

src/HybridAppHandler.tsx

github-actions · 2026-02-23T21:23:01Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Julesssss · 2026-02-23T21:23:04Z

Hi @abzokhattab we will skip C+ review here, thank you

Julesssss

Nice improvement. Prettier check is unrelated and we will ignore. (unless merging main tomorrow resolves this)

github-actions · 2026-02-23T21:44:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83218.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-376d5a2-921b623-e79e6e5885885e30cd491b8756af1ff87df2f40a/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://83218.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…dler

…to od-nd-transition-add-split-spans-to-the-transition-metrics

kubabutkiewicz · 2026-02-24T17:19:26Z

@Julesssss Lets not merge it yet, I just realised that I dont see in the console the logs for the spans added for some reason even though yesterday it was there

Julesssss · 2026-02-24T18:11:37Z

Lets not merge it yet,

No problem!

kubabutkiewicz · 2026-02-25T13:26:27Z

@Julesssss we can merge, something was off in my local env yesterday

src/libs/actions/Session/index.ts

…n in HybridAppHandler

Julesssss

@kubabutkiewicz just a conflict to resolve

…to od-nd-transition-add-split-spans-to-the-transition-metrics

kubabutkiewicz added 3 commits February 23, 2026 16:42

Enhance telemetry spans for HybridApp transitions

f6d4d60

remove unnecessary comment

a58023c

.

376d5a2

kubabutkiewicz requested review from a team as code owners February 23, 2026 15:46

melvin-bot bot assigned kubabutkiewicz Feb 23, 2026

melvin-bot bot requested review from abzokhattab and joekaufmanexpensify and removed request for a team February 23, 2026 15:46

melvin-bot bot removed the request for review from a team February 23, 2026 15:46

kubabutkiewicz mentioned this pull request Feb 23, 2026

[Metrics] Improve OD → ND Transition Performance #77172

Closed

github-actions bot reviewed Feb 23, 2026

View reviewed changes

src/libs/HybridApp.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 23, 2026

View reviewed changes

joekaufmanexpensify removed their request for review February 23, 2026 17:54

Julesssss reviewed Feb 23, 2026

View reviewed changes

src/HybridAppHandler.tsx Show resolved Hide resolved

Julesssss removed the request for review from abzokhattab February 23, 2026 21:23

Julesssss reviewed Feb 23, 2026

View reviewed changes

kubabutkiewicz added 2 commits February 24, 2026 15:33

Enhance telemetry span handling during Onyx hydration in HybridAppHan…

a7f1ffd

…dler

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

212b791

…to od-nd-transition-add-split-spans-to-the-transition-metrics

Julesssss marked this pull request as draft February 24, 2026 23:55

kubabutkiewicz marked this pull request as ready for review February 25, 2026 13:25

github-actions bot reviewed Feb 25, 2026

View reviewed changes

src/libs/actions/Session/index.ts Show resolved Hide resolved

Implement enhanced telemetry spans for JS execution and Onyx hydratio…

9bee61d

…n in HybridAppHandler

Julesssss previously approved these changes Feb 25, 2026

View reviewed changes

Julesssss reviewed Feb 25, 2026

View reviewed changes

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

198135d

…to od-nd-transition-add-split-spans-to-the-transition-metrics

kubabutkiewicz dismissed Julesssss’s stale review via 198135d February 26, 2026 11:53

fix typecheck

57a5478

Conversation

kubabutkiewicz commented Feb 23, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 23, 2026

Uh oh!

Uh oh!

abzokhattab commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify commented Feb 23, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Julesssss commented Feb 23, 2026

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

kubabutkiewicz commented Feb 24, 2026

Uh oh!

Julesssss commented Feb 24, 2026

Uh oh!

kubabutkiewicz commented Feb 25, 2026

Uh oh!

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 23, 2026 •

edited by github-actions bot

Loading