[No QA] Refactor OptionListContextProvider for React Compiler compatibility

[roryabraham]

Explanation of Change

Refactors OptionListContextProvider.tsx for React Compiler compatibility by:

1. Fixing React Compiler warning: Removed the eslint-disable-next-line react-hooks/exhaustive-deps suppression that was blocking compilation.
2. Removing dead code: Eliminated unused prevReports variable and its usage in changedReportsEntries.
3. Deriving options during render: Replaced 5 useEffect hooks and associated state management with a single derived createOptionList() call during render. This relies on React Compiler's automatic memoization to avoid redundant computation. Changed areOptionsInitialized from useRef to useState to properly trigger re-renders.
4. Removing manual memoization: Removed all useMemo, useCallback, and useRef usage since the file now compiles with React Compiler.
5. Initializing consumer state from context: areInternalOptionsInitialized in useOptionsList now initializes from the context value instead of hardcoded false, preventing consumers that mount after initialization from getting stuck in a loading state.

This is a performance-oriented refactor. By removing 5 effect hooks that were causing unnecessary re-renders and relying on React Compiler's auto-memoization, we expect a net improvement despite calling createOptionList() during render instead of incrementally updating via effects.

Split out from #83382.

Fixed Issues

$

Tests

• Verify that no errors appear in the JS console
• Open the app and navigate to a chat — verify the LHN (Left Hand Navigation) loads correctly with all reports listed
• Search for a user in the new chat/search flow — verify options appear correctly
• Verify that switching between chats works without delays or stale data

Offline tests

• Open the app while offline, verify the LHN still displays cached reports
• Go offline after the app has loaded, verify navigation and chat switching still works

QA Steps

Same as tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

Screenshots/Videos

Android: Native

N/A - no UI changes

Android: mWeb Chrome

N/A - no UI changes

iOS: Native

N/A - no UI changes

iOS: mWeb Safari

N/A - no UI changes

MacOS: Chrome / Safari

N/A - no UI changes

Made with Cursor