[No QA] ci: don't fail iOS build when IPA is missing on Rock cache hits#83647
Open
roryabraham wants to merge 1 commit intomainfrom
Open
[No QA] ci: don't fail iOS build when IPA is missing on Rock cache hits#83647roryabraham wants to merge 1 commit intomainfrom
roryabraham wants to merge 1 commit intomainfrom
Conversation
The set-ipa-filename step hard-failed for non-Adhoc builds when no local IPA was found. This broke verifyHybridApp CI checks which call buildIOS with variant=Release -- on Rock remote-cache hits the IPA isn't materialized locally, but that's fine because the build still succeeded. Warn instead of failing. deploy.yml still validates the IPA path downstream before uploading to TestFlight, so deploys won't silently pass with a missing IPA. Made-with: Cursor
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR #83350 added a
set-ipa-filenamestep tobuildIOS.ymlthat hard-fails when no.ipais found locally for non-Adhoc builds. However, Rock remote-cache hits don't materialize the IPA locally — they confirm the build succeeded without re-building. This causesverifyHybridApp.yml(which callsbuildIOS.ymlwithvariant: Release) to fail on cache hits, breaking CI for unrelated PRs like #83256.The fix changes the step to always warn (never fail) when the IPA is missing. Deploy safety is preserved because
deploy.ymlindependently validates the IPA path before uploading to TestFlight.Fixed Issues
Fixes CI regression introduced in #83350.
Tests
verifyHybridAppCI passes.Offline tests
None
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A