[No QA] Remove Individual Workspace references from help pages#83648
[No QA] Remove Individual Workspace references from help pages#83648garrettmknight merged 15 commits intomainfrom
Conversation
As part of the migration of paid personal plan users to Collect workspaces (Expensify/Expensify#588858), remove references to Individual Workspaces across 6 help pages: - Change-Plan-Or-Subscription: Remove Individual Plan subscription and downgrade sections - Create-a-workspace-for-yourself: Remove Individual vs Group distinction, simplify workspace creation - Expense-Types: Simplify workspace filter label - Expense-Settings: Remove individual/group workspace distinction - Navigate-multiple-workspaces: Simplify intro wording - Personal-and-Corporate-Karma: Update settings path, remove Individual workspace screenshot, fix Sign in URL Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Personal-and-Corporate-Karma.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/getting-started/Create-a-workspace-for-yourself.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3939b31275
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Show resolved
Hide resolved
…docs - Simplify section headings in Change-Plan-Or-Subscription.md to remove Group Plan references that were inconsistent with the updated intro - Align Corporate Karma navigation path to match Personal Karma pattern in Personal-and-Corporate-Karma.md - Tighten FAQ wording in Create-a-workspace-for-yourself.md
HelpDot Documentation ReviewOverall AssessmentThis PR systematically removes references to Individual Workspaces across 6 Expensify Classic help pages, aligning documentation with the migration of paid personal plan users to Collect workspaces. The changes are well-scoped and consistently applied. The net result is 16 additions and 70 deletions -- the documentation becomes noticeably simpler and easier to follow. The PR also includes a welcome bug fix (adding Scores Summary
Key FindingsPositive aspects:
Items to note (unchanged portions outside the diff scope, flagged for awareness only):
One issue within the diff:
Recommendations
Files Reviewed
This review assessed only the proposed changes (diff). Residual references in unchanged portions of the files are noted for awareness but not scored against this PR. |
Connects the FAQ answers to the plan types (Collect, Control, Free) listed in the intro, and removes the "Group Workspace" reference to match the simplified language used throughout the page.
garrettmknight
left a comment
There was a problem hiding this comment.
@MelvinBot please review the comments and update your PR.
| @@ -20,13 +20,11 @@ The fund from your Personal Karma is determined by the expense's MCC (Merchant C | |||
|
|
|||
| ## Setting Up Personal Karma Donations | |||
There was a problem hiding this comment.
I think we need to create a new help page for this one. We're changing Personal Karma to only be downgraded via New Expensify. Users will be able do enable/disable in Settings > Save the World > Personal Karma. That's being implemented here: https://github.com/Expensify/Expensify/issues/601130
There was a problem hiding this comment.
Then we'll want to link that help page here.
There was a problem hiding this comment.
Created a new help page at docs/articles/new-expensify/settings/Personal-Karma.md documenting the New Expensify path (Settings > Save the World > Personal Karma) for enabling/disabling Personal Karma.
Updated the classic article's "Setting Up Personal Karma Donations" section to link to the new page instead of showing the old workspace setup instructions.
There was a problem hiding this comment.
Done — the classic article now links to the new help page at articles/new-expensify/settings/Personal-Karma.
Create a new help page for Personal Karma under New Expensify settings,
documenting the new Settings > Save the World > Personal Karma path.
Update the classic article to link to the new page instead of showing
the old workspace setup instructions.
Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>
|
@stephanieelliott I think this is ready to go! |
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/expensify-billing/Change-Plan-Or-Subscription.md
Outdated
Show resolved
Hide resolved
| Setting a default workspace ensures that new expenses and reports are automatically assigned to the correct workspace, reducing the chance of submitting expenses under the wrong account. This is especially useful if you frequently switch between multiple workspaces. | ||
|
|
||
| 1. Hover over **Settings** and click **Workspaces**. | ||
| 2. Click the **Group** tab on the left. |
|
Thanks @garrettmknight! Looking good - I requested a few changes, we were still referencing Group in a lot of the navigation paths. Also, I went ahead and updated the new article directly. |
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
…Or-Subscription.md Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
|
Thanks @stephanieelliott - changes committed, ready for another review. |
|
Approved! Not sure if these changes are all live so will not merge just in case. @garrettmknight you (or anyone) should be able to merge this whenever you are ready! |
|
Merging, we're migrating the rest of the users today! |
|
🚀 Deployed to staging by https://github.com/garrettmknight in version: 9.3.40-0 🚀
|
|
🚀 Deployed to staging by https://github.com/garrettmknight in version: 9.3.40-0 🚀
|
Summary
Removes references to Individual Workspaces from 6 ExpensifyHelp pages as part of the migration of paid personal plan users to Collect workspaces (Expensify/Expensify#588858).
Changes by file:
Change-Plan-Or-Subscription
Create-a-workspace-for-yourself
Expense-Types
Expense-Settings (Expense Rules)
Navigate-multiple-workspaces
Personal-and-Corporate-Karma
Related Issues
Expensify/Expensify#588858
Test plan