fix: Travel opens travel.expensify.com in external browser instead of in-app webview by nkdengineer · Pull Request #83657 · Expensify/App

nkdengineer · 2026-02-27T07:39:02Z

Explanation of Change

fix: Travel opens travel.expensify.com in external browser instead of in-app webview

Fixed Issues

$ #82362
PROPOSAL: #82362 (comment)

Tests

Precondition: has a WS, and has enabled "Travel" feature

Click on the Travel menu option > Let's Go
Verify you are prompted to add a company address
Set the following Company Address "548 Market St San Francisco, CA 94104, United States"
Click "Save"
Check the terms box and continue
On web/mweb, verify that a new tab is opened with the travel page
On the Android/IOS app, verify that the Book travel in-app webview is opened

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-27.at.14.28.08.mov

Android: mWeb Chrome

Screen.Recording.2026-02-27.at.14.34.11.mov

iOS: Native

Screen.Recording.2026-02-27.at.14.27.22.mov

iOS: mWeb Safari

Screen.Recording.2026-02-27.at.14.35.15.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-27.at.14.29.49.mov

… in-app webview

codecov · 2026-02-27T07:48:35Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/Travel/TravelTerms.tsx	`0.00% <0.00%> (ø)`
src/libs/openTravelDotLink/index.native.ts	`14.28% <25.00%> (-3.90%)`	⬇️
src/libs/openTravelDotLink/index.ts	`0.00% <0.00%> (ø)`
... and 13 files with indirect coverage changes

melvin-bot · 2026-02-27T08:14:38Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc55485f1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T08:21:43Z

src/libs/openTravelDotLink/index.ts

-const openTravelDotLink = (activePolicyID?: string, postLoginPath?: string) => {
+const openTravelDotLink = (activePolicyID?: string, postLoginPath?: string, spotnanaToken?: string, isTestAccount?: boolean) => {
+    if (spotnanaToken) {
+        asyncOpenURL(Promise.resolve(), () => buildTravelDotURL(spotnanaToken, isTestAccount ?? false, postLoginPath));


Preserve Safari popup flow when opening travel URL

When spotnanaToken is present, this path calls asyncOpenURL with Promise.resolve(), but it is invoked only after acceptSpotnanaTerms() finishes in TravelTerms, not directly in the original click event. In Safari, that loses the user-gesture context needed for window.open(), so the popup is blocked and the fallback opens in _self (same tab) instead of a new tab, which regresses web/mWeb Safari behavior for the Travel terms flow.

Useful? React with 👍 / 👎.

ZhenjaHorbach · 2026-03-02T10:14:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

trjExpensify

Did anyone look into this comment from QA on the parent issue? It's allegedly not reproducible anymore.

nkdengineer · 2026-03-03T05:38:07Z

@trjExpensify No recent change on this page, so this issue is still reproducible

trjExpensify · 2026-03-03T20:50:36Z

Asked for you: #82362 (comment)

nkdengineer added 2 commits February 25, 2026 14:22

fix: Travel opens travel.expensify.com in external browser instead of…

708f524

… in-app webview

Merge branch 'main' into fix/82362

cc55485

melvin-bot bot assigned nkdengineer Feb 27, 2026

nkdengineer marked this pull request as ready for review February 27, 2026 08:14

nkdengineer requested review from a team as code owners February 27, 2026 08:14

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team February 27, 2026 08:14

melvin-bot bot requested review from trjExpensify and removed request for a team February 27, 2026 08:14

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

trjExpensify reviewed Mar 2, 2026

View reviewed changes

Merge branch 'main' into fix/82362

0542a87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Travel opens travel.expensify.com in external browser instead of in-app webview#83657

fix: Travel opens travel.expensify.com in external browser instead of in-app webview#83657
nkdengineer wants to merge 3 commits intoExpensify:mainfrom
nkdengineer:fix/82362

nkdengineer commented Feb 27, 2026

Uh oh!

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

ZhenjaHorbach commented Mar 2, 2026 •

edited

Loading

Uh oh!

trjExpensify left a comment

Uh oh!

nkdengineer commented Mar 3, 2026

Uh oh!

trjExpensify commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nkdengineer commented Feb 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Mar 3, 2026

Uh oh!

trjExpensify commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Mar 2, 2026 •

edited

Loading