Add tooltip on hover of labels#83704
Conversation
|
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bbc98b4b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0f65ffffe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ShridharGoel it should be ready for re-re-review 🚀 |
mateuuszzzzz
left a comment
There was a problem hiding this comment.
I left minor remarks regarding missing spaces and comments. Otherwise, the code looks great!
|
fixed review comments, it's good to go 🚀 |
puneetlath
left a comment
There was a problem hiding this comment.
Wow, this really took me back to geometry class.
|
@borys3kk looks good to me, but prettier is failing. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
tooltip for the corresponding data point, with hit-testing that correctly handles 0°, 45°, and 90° label rotations.
data point during continuous hover movement.
correct tick X before passing it to Victory's touch handler, correcting its nearest-point-by-X algorithm for labels whose bounding boxes
extend past the midpoint to an adjacent tick.
matchedIndex directly from its shared value, causing the tooltip to miss on the first frame after a new point was matched.
rotatedLabelYOffset, per-label scaled widths, and the O(n) Math.max spread out of the worklet hot path so they are recalculated only when
font, rotation, or label data changes rather than on every hover event.
Fixed Issues
$ #82317
PROPOSAL:
Tests
All of the following testcases are to be tested on web!
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bar:
Screen.Recording.2026-03-05.at.13.02.41.mov
Line:
Screen.Recording.2026-03-04.at.17.04.18.mov
Pie:
Screen.Recording.2026-03-04.at.13.29.40.mov