perf: Stabilize TransactionPreview by rlinoz · Pull Request #84067 · Expensify/App

rlinoz · 2026-03-03T19:39:00Z

Explanation of Change

This PR helps stop re-rendering TransactionPreview when not needed, helping with the manual open report metric.

Fixed Issues

#84148
PROPOSAL:

Tests

Create a report and add transactions to it in the policy expense chat
Verify the transactions are updated and highlighted

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a report and add transactions to it in the policy expense chat
Verify the transactions are updated and highlighted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-03-03.at.16.46.32.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

rlinoz · 2026-03-03T19:52:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 862ac6c3ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kacper-mikolajczak · 2026-03-03T23:32:02Z

Thanks for the improvements @rlinoz!

I wonder, how would the performance change if instead of adding more manual memoization, we dropped the existing manual memoization to let React Compiler automatically optimize the component?

Here are some insight I've gathered when running compiler health check on those components:

Currently TransactionPreview has React Compiler compliance warnings because the manual useMemo/useCallback conflict with the compiler's analysis, causing it to skip optimizing the entire component:

src/components/ReportActionItem/TransactionPreview/index.tsx:71:31
    React Compiler has skipped optimizing this component because the existing 
    manual memoization could not be preserved.

src/components/ReportActionItem/TransactionPreview/index.tsx:86:47
    React Compiler has skipped optimizing this component because the existing 
    manual memoization could not be preserved. The inferred dependencies did not 
    match the manually specified dependencies.

If we remove these two manual memoizations, the compiler should fully optimize TransactionPreview on its own:

Line 71 - drop useMemo:

-    const transactionDetails = useMemo(() => getTransactionDetails(transaction), [transaction]);
+    const transactionDetails = getTransactionDetails(transaction);

Line 86-90 - drop useCallback:

-    const navigateToReviewFields = useCallback(() => {
+    const navigateToReviewFields = () => {
         Navigation.navigate(
             getReviewNavigationRoute(Navigation.getActiveRoute(), route.params?.threadReportID, transaction, duplicates, policy, policyCategories, policyTags ?? {}, transactionReport),
         );
-    }, [route.params?.threadReportID, transaction, duplicates, policy, policyCategories, policyTags, transactionReport]);
+    };

With the compiler fully optimizing the component, the memo() wrapper and the new useMemo for transactionPreviewContainerStyles in MoneyRequestReportPreview might not even be needed - the compiler would handle prop stability internally. Worth checking if this simpler approach achieves the same (or better) perf results.

Let me know what you think, thanks!

rlinoz · 2026-03-04T12:26:56Z

Ah nice! As far as I can tell that gets the same result, updated.

kacper-mikolajczak · 2026-03-04T13:14:49Z

@rlinoz FYI, there's something up with linter after the changes - could that be caused by not all the commits present on remote?

…uestReportPreview-2

melvin-bot · 2026-03-04T17:39:25Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz · 2026-03-05T20:23:06Z

My check here was fake #84067 (comment)

For some reaosn that I can't figure out adding the memo there still makes a difference for this not to re-render @kacper-mikolajczak

rlinoz · 2026-03-05T20:23:17Z

@hungvu193 if you could continue with the review 🙇

codecov · 2026-03-05T20:31:29Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...portActionItem/MoneyRequestReportPreview/index.tsx	`90.00% <100.00%> (+0.34%)`	⬆️
...ents/ReportActionItem/TransactionPreview/index.tsx	`78.78% <100.00%> (-2.47%)`	⬇️
... and 262 files with indirect coverage changes

hungvu193 · 2026-03-06T03:05:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-06.at.10.44.12.mov

Android: mWeb Chrome

Screen.Recording.2026-03-06.at.10.39.56.mov

iOS: HybridApp

Screen.Recording.2026-03-06.at.10.33.46.mov

iOS: mWeb Safari

Screen.Recording.2026-03-06.at.10.32.14.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-06.at.10.05.14.mov

melvin-bot · 2026-03-06T03:45:47Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-06T03:45:49Z

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #84353.

amyevans

LGTM!

Though looks like #84067 (comment) is still pending

rlinoz · 2026-03-06T14:26:55Z

I will go ahead and merge and address that in a follow up if necessary, thanks!

github-actions · 2026-03-06T14:27:33Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T14:32:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84067.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f95a157-5430cbd-9eba66f84415d5769f4f6c4deadc0b5869c2bc16/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f95a157-5430cbd-40aca5860ad240782784277d27d7a632bce92337/index.html

Web 🕸️
https://84067.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T14:34:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-06T23:02:50Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:38:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rlinoz added 2 commits March 3, 2026 16:25

stable should highlight

32f1e5d

avoid transactionpreview re-renders

862ac6c

rlinoz self-assigned this Mar 3, 2026

rlinoz changed the title ~~Rodrigo perf money request report preview 2~~ perf: Stabilize TransactionPreview Mar 3, 2026

chatgpt-codex-connector Bot reviewed Mar 3, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx Outdated

stop creating actions map

5d0493a

rlinoz added 2 commits March 4, 2026 09:25

make TransactionPreview react compiler compatible

0556b55

make TransactionPreview react compiler compatible

94bb38b

rlinoz added 4 commits March 4, 2026 10:28

Merge remote-tracking branch 'origin/main' into rodrigo-perf-MoneyReq…

e241bfd

…uestReportPreview-2

remove unused import

bfb3b6c

merge main

2ade08d

Merge remote-tracking branch 'origin/main' into rodrigo-perf-MoneyReq…

d28c53a

…uestReportPreview-2

rlinoz marked this pull request as ready for review March 4, 2026 17:38

rlinoz requested review from a team as code owners March 4, 2026 17:38

melvin-bot Bot requested review from amyevans and heyjennahay and removed request for a team March 4, 2026 17:38

rlinoz requested a review from hungvu193 March 4, 2026 17:49

hungvu193 reviewed Mar 5, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx Outdated

rlinoz added 3 commits March 5, 2026 11:23

leveraging react compiler for styles too

23e3531

Merge branch 'main' into rodrigo-perf-MoneyRequestReportPreview-2

0b067a2

rollback removin memo

fe7f87c

hungvu193 approved these changes Mar 6, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath March 6, 2026 03:45

melvin-bot Bot mentioned this pull request Mar 6, 2026

[HOLD for payment 2026-03-16] Payment issue for E/App PR#84067 #84353

Closed

amyevans approved these changes Mar 6, 2026

View reviewed changes

rlinoz merged commit f95a157 into main Mar 6, 2026
34 checks passed

rlinoz deleted the rodrigo-perf-MoneyRequestReportPreview-2 branch March 6, 2026 14:27

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

Conversation

rlinoz commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

rlinoz commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kacper-mikolajczak commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rlinoz commented Mar 4, 2026

Uh oh!

kacper-mikolajczak commented Mar 4, 2026

Uh oh!

melvin-bot Bot commented Mar 4, 2026

Uh oh!

Uh oh!

rlinoz commented Mar 5, 2026

Uh oh!

rlinoz commented Mar 5, 2026

Uh oh!

codecov Bot commented Mar 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hungvu193 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 6, 2026

Uh oh!

melvin-bot Bot commented Mar 6, 2026

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Mar 6, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rlinoz commented Mar 3, 2026 •

edited

Loading

kacper-mikolajczak commented Mar 3, 2026 •

edited

Loading

codecov Bot commented Mar 5, 2026 •

edited by github-actions Bot

Loading

hungvu193 commented Mar 6, 2026 •

edited

Loading