fix: Report - Formula report field initial value {report:i} is not persisted & resets to {report:id} by annaweber830 · Pull Request #84207 · Expensify/App

annaweber830 · 2026-03-04T22:56:10Z

Explanation of Change

fix: Report - Formula report field initial value {report:i} is not persisted & resets to {report:id}

Fixed Issues

$ #79855
PROPOSAL: #79855 (comment)

Tests

Pre-condition: report field is enabled

Launch app
Go to workspace settings
Tapping add field
Select type - formula
Tap initial value and change it to {report:i} and save
Enter a name and save
Created report field is not shown in list
Tap add field
Enter a name, select type formula and save
Tap the report field created
Tap initial value and change it to {report:i} and save
Show validation error.

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Pre-condition: report field is enabled

Launch app
Go to workspace settings
Tapping add field
Select type - formula
Tap initial value and change it to {report:i} and save
Enter a name and save
Created report field is not shown in list
Tap add field
Enter a name, select type formula and save
Tap the report field created
Tap initial value and change it to {report:i} and save
Show validation error.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.2.50.25.PM.mov

melvin-bot · 2026-03-04T22:56:15Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-03-04T22:56:16Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-04T23:07:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/WorkspaceReportFieldUtils.ts	`62.12% <94.11%> (+33.99%)`	⬆️
...pages/workspace/reports/CreateReportFieldsPage.tsx	`0.00% <0.00%> (ø)`
...workspace/reports/ReportFieldsInitialValuePage.tsx	`0.00% <0.00%> (ø)`
... and 213 files with indirect coverage changes

linhvovan29546 · 2026-03-06T10:34:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

linhvovan29546 · 2026-03-06T10:37:04Z

@annaweber830 Do you have access to the open-source Slack channel?
https://app.slack.com/client/E047TPA624F/C01GTK53T8Q?_gl=1*ie6zjd*_gcl_au*MjM3MzE4ODQ4LjE3NzE3NjMzMDY.

linhvovan29546 · 2026-03-06T10:38:04Z

Could you please address this comment?

#84207 (comment)

linhvovan29546

@annaweber830 Could you please merge main and resolve conflict?

linhvovan29546 · 2026-03-06T10:43:48Z

src/languages/en.ts

            reportFieldNameRequiredError: 'Please enter a report field name',
            reportFieldTypeRequiredError: 'Please choose a report field type',
            circularReferenceError: "This field can't refer to itself. Please update.",
+            unsupportedFormulaValueError: ({value}: UnsupportedFormulaValueErrorParams) => `Unsupported formula token(s): ${value}. Use supported tokens such as {report:id}.`,


I think we should use the same error message as in OD: Formula field {report:i} not recognized

linhvovan29546 · 2026-03-06T10:47:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0979fb0b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-06T11:12:19Z

src/libs/WorkspaceReportFieldUtils.ts

+            const submitField = rest.at(1)?.trim().toLowerCase();
+            if (!submitField || !supportedSubmitPersonFields.has(submitField)) {


Permit {report:submit:from}/{report:submit:to} tokens

This validation now treats report:submit:from and report:submit:to as invalid unless a third segment is present, so formulas using those 2-segment tokens will be blocked with unsupportedFormulaValueError. That conflicts with our documented/embedded formula vocabulary where both tokens are valid (see docs/articles/new-expensify/reports-and-expenses/Customize-and-Enforce-Report-Titles.md lines 62-63 and src/languages/en.ts line 5404), so this introduces a regression by rejecting formulas users are told to use.

Useful? React with 👍 / 👎.

linhvovan29546 · 2026-03-06T10:53:43Z

src/libs/WorkspaceReportFieldUtils.ts

+        FORMULA_PART_TYPES: {REPORT: string};
+    };
+
+    const supportedReportFields = new Set([


Looks like we're missing some accepted formulas. Can you check here and test adding them?

https://help.expensify.com/articles/expensify-classic/spending-insights/Export-Expenses-And-Reports#formulas

fix: init

d0979fb

annaweber830 requested review from a team as code owners March 4, 2026 22:56

melvin-bot bot assigned annaweber830 Mar 4, 2026

melvin-bot bot requested a review from linhvovan29546 March 4, 2026 22:56

melvin-bot bot requested review from heyjennahay and removed request for a team March 4, 2026 22:56

linhvovan29546 suggested changes Mar 6, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

linhvovan29546 reviewed Mar 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Report - Formula report field initial value {report:i} is not persisted & resets to {report:id}#84207

fix: Report - Formula report field initial value {report:i} is not persisted & resets to {report:id}#84207
annaweber830 wants to merge 1 commit intoExpensify:mainfrom
annaweber830:fix-79855

annaweber830 commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

codecov bot commented Mar 4, 2026 •

edited by github-actions bot

Loading

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

linhvovan29546 left a comment

Uh oh!

linhvovan29546 Mar 6, 2026

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Uh oh!

linhvovan29546 Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const submitField = rest.at(1)?.trim().toLowerCase();
		if (!submitField \|\| !supportedSubmitPersonFields.has(submitField)) {

Conversation

annaweber830 commented Mar 4, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

codecov bot commented Mar 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linhvovan29546 commented Mar 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 4, 2026 •

edited by github-actions bot

Loading