Skip to content

Create per-diem in selfDM if auto reporting is disabled (2)#84226

Merged
chuckdries merged 2 commits intoExpensify:mainfrom
s77rt:auto-reporting-per-diem-2
Mar 6, 2026
Merged

Create per-diem in selfDM if auto reporting is disabled (2)#84226
chuckdries merged 2 commits intoExpensify:mainfrom
s77rt:auto-reporting-per-diem-2

Conversation

@s77rt
Copy link
Copy Markdown
Member

@s77rt s77rt commented Mar 5, 2026

Explanation of Change

2nd attempt of #82230 after fixing regression #84167

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/595920
PROPOSAL:

Tests

Test 1:

  • Enable auto reporting on the default workspace
  • Enable Per-Diem only on the default workspace and add rates
  1. Click on FAB > Create expense > Per diem
  2. Complete process
  3. Verify the per-diem expense is created on the default workspace's expense chat
Screen.Recording.2026-02-23.at.4.06.29.PM.mov

Test 2:

  • Enable auto reporting on the default workspace
  • Enable Per-Diem on the multiple workspaces and add rates
  1. Click on FAB > Create expense > Per diem
  2. Select any workspace
  3. Complete process
  4. Verify the per-diem expense is created on the selected workspace's expense chat
Screen.Recording.2026-02-23.at.4.03.53.PM.mov

Test 3:

  • Disable auto reporting on the default workspace
  • Enable Per-Diem only on the default workspace and add rates
  1. Click on FAB > Create expense > Per diem
  2. Complete process
  3. Verify the per-diem expense is created unreported (in your selfDM)
Screen.Recording.2026-02-23.at.4.07.08.PM.mov

Test 4:

  • Disable auto reporting on the default workspace
  • Enable Per-Diem on the multiple workspaces and add rates
  1. Click on FAB > Create expense > Per diem
  2. Select any workspace
  3. Complete process
  4. Verify the per-diem expense is created unreported (in your selfDM)
Screen.Recording.2026-02-23.at.4.02.23.PM.mov

Test 5:

  • Disable auto reporting on the default workspace
  • Enable Per-Diem on the multiple workspaces and add rates
  1. Open workspace expense chat
  2. Click on + grey button > Create expense (Per diem)
  3. Complete process
  4. Verify the per-diem expense is created on the opened workspace expense chat
Screen.Recording.2026-03-05.at.3.21.10.AM.mov
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@s77rt s77rt marked this pull request as ready for review March 5, 2026 02:32
@s77rt s77rt requested review from a team as code owners March 5, 2026 02:32
@melvin-bot melvin-bot Bot requested review from suneox and removed request for a team March 5, 2026 02:32
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Mar 5, 2026

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from JmillsExpensify and removed request for a team March 5, 2026 02:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026 •
edited by github-actions Bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ou/request/step/IOURequestStepPerDiemWorkspace.tsx 0.00% <0.00%> (ø)
...ges/iou/request/step/IOURequestStepDestination.tsx 2.59% <0.00%> (-0.04%) ⬇️
src/libs/IOUUtils.ts 72.58% <0.00%> (-5.46%) ⬇️
... and 201 files with indirect coverage changes

@s77rt s77rt requested review from QichenZhu and chuckdries and removed request for suneox March 5, 2026 02:32
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c6a8c76dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/iou/request/step/IOURequestStepDestination.tsx
JmillsExpensify
JmillsExpensify approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good for product behavior.

@QichenZhu
Copy link
Copy Markdown
Contributor

QichenZhu commented Mar 6, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-06.at.3.01.18.PM.mov
Screen.Recording.2026-03-06.at.3.13.37.PM.mov
Screen.Recording.2026-03-06.at.3.34.58.PM.mov
Screen.Recording.2026-03-06.at.3.39.07.PM.mov
Screen.Recording.2026-03-06.at.3.47.57.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-03-06.at.3.07.41.PM.mov
Screen.Recording.2026-03-06.at.3.19.25.PM.mov
Screen.Recording.2026-03-06.at.3.36.34.PM.mov
Screen.Recording.2026-03-06.at.3.42.45.PM.mov
Screen.Recording.2026-03-06.at.3.50.35.PM.mov
iOS: HybridApp
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.00.23.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.15.49.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.24.45.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.38.42.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.47.01.mov
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.04.53.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.17.47.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.36.22.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.40.26.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-06.at.15.49.56.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-06.at.2.57.39.PM.mov
Screen.Recording.2026-03-06.at.3.08.53.PM.mov
Screen.Recording.2026-03-06.at.3.21.22.PM.mov
Screen.Recording.2026-03-06.at.3.37.30.PM.mov
Screen.Recording.2026-03-06.at.3.43.37.PM.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Mar 6, 2026

🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #84351.

@melvin-bot melvin-bot Bot mentioned this pull request Mar 6, 2026
Closed
@chuckdries chuckdries merged commit d9288c0 into Expensify:main Mar 6, 2026
32 of 34 checks passed
This was referenced Mar 6, 2026
Closed
Closed
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84226.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d9288c0-f7a5906-188063da0b044aea8b30376c807c763becd3709f/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d9288c0-f7a5906-5b53ec7a5dd18d9637584379319437ca6d0131b3/index.html
Android iOS
Web 🕸️
https://84226.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Mar 6, 2026
Closed
52 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@chuckdries chuckdries mentioned this pull request Mar 9, 2026
Closed
7 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 9, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@api-claude-dev api-claude-dev mentioned this pull request Mar 14, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@JmillsExpensify JmillsExpensify JmillsExpensify approved these changes

@chuckdries chuckdries chuckdries approved these changes

+1 more reviewer

@QichenZhu QichenZhu QichenZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@s77rt s77rt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@s77rt @QichenZhu @OSBotify @JmillsExpensify @chuckdries