[ON HOLD] Fix false offline state on web (Safari)

[adhorodyski]

Explanation of Change

Before setting offlineStatus to true based on NetInfo's Ping failure, we check navigator.onLine. If the browser reports the network adapter is connected (navigator.onLine === true) but NetInfo's Ping timed out (isInternetReachable === false), we skip setting offline — it's a false positive from Ping contention (e.g., during a large upload).

The guard only activates on web (where navigator exists). On native, navigator is undefined so the guard never fires. Real disconnects still work because the browser fires an offline event setting navigator.onLine = false.

Only one file was changed: src/libs/NetworkConnection.ts — added a navigator.onLine guard in the NetInfo event listener to prevent false offline state in Safari during upload contention.

Fixed Issues

$ #83780
PROPOSAL:

Tests

1. Reproduce the false-positive offline scenario:

   • Log in to the app
   • Open DevTools → Console (to watch the [NetworkConnection] log messages)
   • Trigger a large upload (e.g., attach a big receipt image) — this can cause NetInfo's ping to fail due to network contention
   • Before the fix: The app would briefly show the offline banner even though you're online
   • After the fix: You should see the log NetInfo says unreachable but navigator.onLine is true — skipping offline to avoid false positive and no offline banner

2. Verify real offline still works:

   • In DevTools → Network tab, set throttling to Offline
   • The app should still correctly show the offline indicator (because navigator.onLine will also be false)

3. Safari-specific testing (if available):

   • Safari lacks the Network Information API, making it more prone to false-positive ping failures
   • Repeat the large upload test in Safari to confirm the fix helps there too

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/NetworkConnection.ts	65.85% <0.00%> (-0.61%)	⬇️
... and 11 files with indirect coverage changes

[melvin-bot]

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[adhorodyski]

@m-natarajan are you able to reproduce this please with this PRs fix? Unfortunately I wasn't able to reproduce the OG bug myself.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a2706407b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Keep server-outage offline updates despite navigator guard

This early return bypasses the existing setOfflineStatus(state.isInternetReachable === false || !isServerUp, ...) path whenever navigator.onLine is true, so a backend outage (where reachabilityTest sets isServerUp = false but the browser still reports online) will no longer mark the app offline. In that scenario users stay in an online state while API calls fail, which is a regression introduced by this guard.

Useful? React with 👍 / 👎.

[m-natarajan]

@m-natarajan are you able to reproduce this please with this PRs fix? Unfortunately I wasn't able to reproduce the OG bug myself.

@adhorodyski Is this PR ready for retest? or Do we have to wait till the status change to Merged?

[truph01]

@adhorodyski @m-natarajan I think we should create an ad hoc build for this PR and ask QA to test it.

[adhorodyski]

Ready for testing, you need an adhoc right? Cc @mountiny

[joekaufmanexpensify]

No product review needed

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84277.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2a27064-1ad3cfa-856fdef0a74be50c9ab95b88929815fa8a8f3d56/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2a27064-1ad3cfa-5113c5a2d1113938cb19b41d782964dff956bd11/index.html

Web 🕸️
https://84277.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[truph01]

@m-natarajan Could you test the issue with the ad hoc build here?

[m-natarajan]

Chrome / Safari - v9.3.31-4 PR:84277
Failed: no expected log NetInfo says unreachable but navigator.onLine is true — skipping offline to avoid false positive

09.59.57.mp4

[adhorodyski]

@mjasikowski should we hold off here and retest with #84760 soon?

[mjasikowski]

@adhorodyski I assume if we push #84760, then this will be redundant, so let's hold off here for now

[mountiny]

Lets add this PR on HOLD then to make it clear from the title