Skip amount conversion for recent searches in SearchRouter by MelvinBot · Pull Request #84295 · Expensify/App

MelvinBot · 2026-03-05T17:37:39Z

Explanation of Change

When selecting a recent search containing an amount filter (e.g. amount:6) from the SearchRouter, the amount was being double-converted to backend format — 6 became 600 (correct), but then 600 became 60000 on the next selection from recent searches.

This happened because submitSearch in SearchRouter.tsx always called getQueryWithUpdatedValues without the shouldSkipAmountConversion flag, even for stored queries that were already in backend format.

This PR adds the shouldSkipAmountConversion parameter to submitSearch and passes true for non-findItem selections (recent and saved searches), matching the existing pattern already used in SearchPageHeaderInput.tsx.

Fixed Issues

$ #79934
PROPOSAL: #79934 (comment)

Tests

Open the app and tap on Search
Type amount:6 in the search input and press Enter
Verify the search results page shows amount:6 in the search query
Open Search again
From Recent Searches, select the type:expense amount:6 entry
Verify the search results page shows amount:6 (not amount:600)

Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects query string formatting for search navigation; no network requests are modified.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web: Chrome

Tested via Playwright browser automation. Selecting recent search "type:expense amount:6" correctly shows "amount:6" in the search bar — no double conversion to "amount:600".

When selecting a recent search containing an amount filter (e.g. amount:6), the amount was being converted to backend format twice (6 → 600 → 60000). This happened because submitSearch in SearchRouter.tsx always ran amount conversion via getQueryWithUpdatedValues, even for stored queries that were already in backend format. Pass shouldSkipAmountConversion=true for non-findItem selections (recent and saved searches) to match the existing pattern in SearchPageHeaderInput. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

codecov · 2026-03-05T18:23:04Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
.../Search/SearchPageHeader/SearchPageHeaderInput.tsx	`48.90% <0.00%> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`0.00% <0.00%> (ø)`
... and 250 files with indirect coverage changes

DylanDylann · 2026-03-06T06:11:22Z

                    setFocusAndScrollToRight();
                } else {
-                    submitSearch(item.searchQuery);
+                    submitSearch(item.searchQuery, item.keyForList !== 'findItem');


@MelvinBot Please put findItem into CONST and update other places to use this new CONST

Done! Added FIND_ITEM to CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE and updated all 4 usages across both SearchRouter.tsx and SearchPageHeaderInput.tsx to reference the new constant.

DylanDylann · 2026-03-06T06:12:01Z

@MelvinBot Mark this PR as ready for review

MelvinBot · 2026-03-06T06:13:22Z

Done! This PR has been marked as ready for review. 🤖

DylanDylann · 2026-03-06T06:14:33Z

@MelvinBot Please put findItem into CONST and update other places to use this new CONST

…ITEM Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

DylanDylann · 2026-03-06T06:57:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-06.at.14.06.29.mov

Android: mWeb Chrome

Screen.Recording.2026-03-06.at.14.05.23.mov

iOS: HybridApp

Screen.Recording.2026-03-06.at.14.06.58.mov

iOS: mWeb Safari

Screen.Recording.2026-03-06.at.14.04.24.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-06.at.14.01.41.mov

DylanDylann

LGTM

trjExpensify

What a weird bug!

CC: @JS00001 @luacmartins for vis

OSBotify · 2026-03-06T16:21:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-06T16:21:49Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-06T16:27:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84295.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b6c5561-7710bef-3824d58575d9342ac6b00cca8ff89dce642d6eb9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b6c5561-7710bef-faafd939ac2c436088162658d08c5625c6bfe385/index.html

Web 🕸️
https://84295.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T23:03:20Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-03-09T20:38:36Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned DylanDylann Mar 5, 2026

MelvinBot requested a review from a team March 5, 2026 17:37

MelvinBot mentioned this pull request Mar 5, 2026

[Due for payment 2026-03-16] [$250] Search - Expense search shows incorrect amount from recent searches #79934

Closed

7 tasks

DylanDylann reviewed Mar 6, 2026

View reviewed changes

MelvinBot marked this pull request as ready for review March 6, 2026 06:13

MelvinBot requested a review from a team as a code owner March 6, 2026 06:13

melvin-bot Bot requested review from trjExpensify and removed request for a team March 6, 2026 06:13

Extract findItem string to CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_…

9c680d5

…ITEM Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

DylanDylann approved these changes Mar 6, 2026

View reviewed changes

melvin-bot Bot requested a review from madmax330 March 6, 2026 07:07

trjExpensify approved these changes Mar 6, 2026

View reviewed changes

JS00001 approved these changes Mar 6, 2026

View reviewed changes

luacmartins approved these changes Mar 6, 2026

View reviewed changes

luacmartins merged commit b6c5561 into main Mar 6, 2026
36 of 37 checks passed

luacmartins deleted the claude-fixRecentSearchAmountDoubleConversion branch March 6, 2026 16:10

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

Conversation

MelvinBot commented Mar 5, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Mar 6, 2026

Uh oh!

MelvinBot commented Mar 6, 2026

Uh oh!

DylanDylann commented Mar 6, 2026

Uh oh!

DylanDylann commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Mar 5, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Mar 6, 2026 •

edited

Loading